Skip to content

Add ability to pass options to addEventListener in from-event #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdbenito
Copy link

This PR

  • Extends from-event to accept an optional third arg with options for addEventListener. This is useful e.g. to listen to wheel events in a non-passive way so as to be able to stop them from propagating.
  • Adds a unit test (although I wonder about the usefulness of such a test given that the target is mocked... 🤷🏽)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant