Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case for 360 sphere #308

Closed
wants to merge 2 commits into from
Closed

Conversation

shimwell
Copy link
Member

@generein I had a quick look at issue #305 and wonder if we need a special case for the 360 degree sphere.

I've modified your original class to have a special route for the 360 degree rotated sphere

I've also added a few more tests to check volumes and number of faces on the result

I have not yet run this through the neutronics workflow, any chance you could test it for your use case

@shimwell shimwell closed this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (ac99619) to head (0956cba).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #308   +/-   ##
========================================
  Coverage    95.61%   95.61%           
========================================
  Files           83       83           
  Lines         5445     5451    +6     
========================================
+ Hits          5206     5212    +6     
  Misses         239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant