Added meeting reminder #10
Merged
+264
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mburtscher
reviewed
Jul 16, 2018
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash -e | |||
|
|
|||
| # Privileged is needed for being able to inspect packages in the host system | |||
| docker run -it --rm --net=host --privileged -v $(pwd)/config.json:/config.json -v ${PWD}/files/opt/dash-button/scripts:/opt/dash-button/scripts dev/dash-buttons | |||
| docker run -it --rm --net=host --privileged -v $(pwd)/config:/opt/dash-button/config -v ${PWD}/files/opt/dash-button/scripts:/opt/dash-button/scripts dev/dash-buttons | |||
There was a problem hiding this comment.
Why do we need to mount the directory now? Just to export the credentials file? Why not print it to the console instead?
There was a problem hiding this comment.
If I remember correctly @rponudic said that we should place the config into a separate folder and we mount the hole directory so that a provider can write a configuration, if needed. The config is written back because we thought it would be easier to transfer, but we could also print the credentials into the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5. Added
meetingReminderProvider. It takes an event from GoogleCal and sends a reminder to attendants.