Merge branch pull request trusteddomainproject#230 from futatuki/issu…

…e229-fix-signingtable-verification

Fix issue trusteddomainproject#229: fix db handling on verification of SigningTable
in dkimf_config_load

- check error on calling dkimf_db_walk()
- fix request parameter for "signer" field in SigningTable

trusteddomainproject#230
trusteddomainproject#229

opendkim/opendkim.c

@@ -8352,20 +8352,23 @@ dkimf_config_load(struct config *data, struct dkimf_config *conf,
 			char keydata[BUFRSZ + 1];
 			char signalgstr[BUFRSZ + 1];
 			char signer[BUFRSZ + 1];
+			int db_stat;
 
-			dbd[0].dbdata_flags = 0;
-
 			memset(keyname, '\0', sizeof keyname);
+			/*
+			** As we don't care signer values here,
+			** we don't need to clear it.
+			*/
 
 			dbd[0].dbdata_buffer = keyname;
 			dbd[0].dbdata_buflen = sizeof keyname - 1;
 			dbd[0].dbdata_flags = 0;
 			dbd[1].dbdata_buffer = signer;
 			dbd[1].dbdata_buflen = sizeof signer - 1;
-			dbd[1].dbdata_flags = 0;
+			dbd[1].dbdata_flags = DKIMF_DB_DATA_OPTIONAL;
 
-			while (dkimf_db_walk(conf->conf_signtabledb, first,
-			                     NULL, NULL, dbd, 2) == 0)
+			while ((db_stat = dkimf_db_walk(conf->conf_signtabledb,
+			                                first, NULL, NULL, dbd, 2)) == 0)
 			{
 				first = FALSE;
 				found = FALSE;
@@ -8381,6 +8384,11 @@ dkimf_config_load(struct config *data, struct dkimf_config *conf,
 				dbd[3].dbdata_buffer = signalgstr;
 				dbd[3].dbdata_buflen = sizeof signalgstr - 1;
 				dbd[3].dbdata_flags = DKIMF_DB_DATA_OPTIONAL;
+				/*
+				** As we don't care for values of the entry
+				** in KeyTable here, we don't need to clear
+				** buffers for them.
+				*/
 
 				if (dkimf_db_get(conf->conf_keytabledb,	
 				                 keyname, strlen(keyname),
@@ -8401,6 +8409,16 @@ dkimf_config_load(struct config *data, struct dkimf_config *conf,
 				dbd[0].dbdata_buffer = keyname;
 				dbd[0].dbdata_buflen = sizeof keyname - 1;
 				dbd[0].dbdata_flags = 0;
+				dbd[1].dbdata_buffer = signer;
+				dbd[1].dbdata_buflen = sizeof signer - 1;
+				dbd[1].dbdata_flags = DKIMF_DB_DATA_OPTIONAL;
+			}
+			if (db_stat == -1)
+			{
+				snprintf(err, errlen,
+				         "error on retrieving an entry from \"%s\"",
+				         conf->conf_signtable);
+				return -1;
 			}
 		}
 	}