Skip to content

v13 Compatibility #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Doresain
Copy link
Contributor

(Closed and recreated due to some additional fixes found)

Many changes to A) make compatible with Foundry Core v13 and B) resolve future deprecation warnings, primarily due to v13 namespace changes.

  • I did not preserve v12 compatibility - this release and forward would be v13 only.
  • Fixed chat roll messages and styling.
  • Removed usage of <#select> hbs helper, deprecated in v13
  • Lots of other miscellaneous fixes

Functionality should be identical, and I don't think there are any breaking changes for the premium modules in these system changes.

If the PR is approved, I strongly recommend a v13-only beta release that is NOT on the package manager yet but can be distributed via url to folks who are interested in testing, with a warning to back up world data - I don't have an existing FBL world to test on.

Premium modules:
The premium modules all DO need to be updated, primarily to remove their attempts to set the now-nonexistent logo - this breaks the import scripts entirely. There are also several macros in the premium modules that are broken, I have fixes for all of those as well.

Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: e7daba9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Doresain Doresain force-pushed the v13-compatibility branch from 93d5a70 to e7daba9 Compare May 28, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant