Factor out Bluetooth transports into separate package #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
factor-out-bluetooth
branch
from
47bebec to
906f136
Compare
This functionality is apparently handled internally now, we might want to test this further though.
Since we unfortunately no longer get notified about disconnects, we rename this to avoid confusion, since discovered peripherals will be kept even after they disconnect.
There seems to be some trouble with Xcode package resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the two Bluetooth backends (
BluetoothLinuxandCoreBluetooth) into a separate package,DistributedChatBluetoothto make it easier to share them e.g. across the CLI and the app. In the future we may also want to expose a platform-independent interface fromDistributedChatBluetooth, currently platforms still have to instantiate the corresponding transport.The Linux implementation is also migrated to the new async API, though would likely deserve some testing.