Fix binary literals with underscores (BIN_DIGITS regex) #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes binary literals with underscore separators. Problem: BIN_DIGITS used /[01]/ instead of /[01]+/ causing parse errors: val x = 0b1101_0010 // ERROR - couldn't parse The regex matched single digits only, not digit groups. Changes: - grammar.js: Changed BIN_DIGITS from /[01]/ to /[01]+/ Now matches one or more binary digits, consistent with: - DEC_DIGITS: /[0-9]+/ - HEX_DIGITS: /[0-9a-fA-F]+/ Example: val binary = 0b11010010_01101001 // Now works val hex = 0xFF_EC_DE_5E // Already worked val dec = 1_000_000 // Already worked Tests: 111/111 pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes binary literals with underscore separators.
Problem:
BIN_DIGITS used /[01]/ instead of /[01]+/ causing parse errors:
val x = 0b1101_0010 // ERROR - couldn't parse
The regex matched single digits only, not digit groups.
Changes:
Now matches one or more binary digits, consistent with:
Example:
val binary = 0b11010010_01101001 // Now works
val hex = 0xFF_EC_DE_5E // Already worked
val dec = 1_000_000 // Already worked
Tests: 111/111 pass