Skip to content

Commit

Permalink
test: QBO Dashboard (#984)
Browse files Browse the repository at this point in the history 
* Unit Test for Integrations APP

* lint fix

* QBO Landing

* qbo component

* QBO Employee settings spec

* removed comments

* lint fix

* unskipped few tests

* unskip qbo landing

* qbo component

* qbo employee setting

* lint fix

* Unit Test: Export Settings QBO

* lint fix

* 28 qbo export settings spec

* qbo fixture

* lint fix

* qboExportSettingsfixture

* updated fixtures and export settings

* lint fix

* lint fix

* working specs

* lint fix

* fix for path changes/name changes of QBD

* pr comments

* moved fixtures

* minor fixes

* updated tests

* lint fix

* additional tests

* qbo component

* qbo onboarding

* lint fix

* lint fix

* lint fixes

* qbo export settings improvised UTs

* updated fixtures and improvised tests

* lint fix

* added it off to fixtures

* updated fixtures

* updated tests for export settings

* lint fix and refactor

* Fixture

* import settings qbo fixtures and tests

* updated tests for import settings

* tests for watchers

* setup watchers tests

* 100% code coverage

* lint fix

* updated tests for advanced settings

* fixed tests qbo advanced settings

* updated tests for advanced settings

* to fix assertions

* advanced settings

* lint fixes

* pr comments

* navigate Function

* lint fixes removed trailing spaces

* merge conflicts

* pr comments

* pr comments

* lint fix removed trailing spaces

* pr comments, use patch values

* merge conflict

* QBO Dashboard

* qbo additional fixtures

* lint fix

* pr comment
  • Loading branch information
@anishfyle
anishfyle authored Oct 2, 2024
1 parent b323ce4 commit 1493a07
Show file tree
Hide file tree
Showing 2 changed files with 792 additions and 11 deletions.
258 changes: 250 additions & 8 deletions src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -1,23 +1,265 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';

/* eslint-disable max-lines */
/* eslint-disable dot-notation */
import { ComponentFixture, TestBed, discardPeriodicTasks, fakeAsync, tick } from '@angular/core/testing';
import { QboDashboardComponent } from './qbo-dashboard.component';
import { AccountingExportService } from 'src/app/core/services/common/accounting-export.service';
import { DashboardService } from 'src/app/core/services/common/dashboard.service';
import { WorkspaceService } from 'src/app/core/services/common/workspace.service';
import { QboExportSettingsService } from 'src/app/core/services/qbo/qbo-configuration/qbo-export-settings.service';
import { QboImportSettingsService } from 'src/app/core/services/qbo/qbo-configuration/qbo-import-settings.service';
import { of, throwError } from 'rxjs';
import { AppName, TaskLogState, QBOTaskLogType, ReimbursableImportState, CCCImportState } from 'src/app/core/models/enum/enum.model';
import { mockWorkspaceGeneralSettingsForDashboard, mockExportableExpenseGroup, mockExportSettingsForDashboard, mockImportSettingsForDashboard, mockExportErrors, mockQBOTaskResponse, mockAccountingExportSummary, mockExportSettings, mockQBOEnqueuedTaskResponse, mockQBOCompletedTaskResponse } from 'src/app/integrations/qbo/qbo.fixture';
import { DashboardModel } from 'src/app/core/models/db/dashboard.model';
import { AccountingExportSummary, AccountingExportSummaryModel } from 'src/app/core/models/db/accounting-export-summary.model';
import { NO_ERRORS_SCHEMA } from '@angular/core';
import { QBOImportSettingGet } from 'src/app/core/models/qbo/qbo-configuration/qbo-import-setting.model';
import { QBOExportSettingGet } from 'src/app/core/models/qbo/qbo-configuration/qbo-export-setting.model';

xdescribe('QboDashboardComponent', () => {
describe('QboDashboardComponent', () => {
let component: QboDashboardComponent;
let fixture: ComponentFixture<QboDashboardComponent>;
let accountingExportService: jasmine.SpyObj<AccountingExportService>;
let dashboardService: jasmine.SpyObj<DashboardService>;
let workspaceService: jasmine.SpyObj<WorkspaceService>;
let qboExportSettingsService: jasmine.SpyObj<QboExportSettingsService>;
let importSettingService: jasmine.SpyObj<QboImportSettingsService>;

beforeEach(async () => {
const accountingExportServiceSpy = jasmine.createSpyObj('AccountingExportService', ['getAccountingExportSummary', 'importExpensesFromFyle']);
const dashboardServiceSpy = jasmine.createSpyObj('DashboardService', ['getExportErrors', 'getAllTasks', 'getExportableAccountingExportIds', 'triggerAccountingExport']);
const workspaceServiceSpy = jasmine.createSpyObj('WorkspaceService', ['getWorkspaceGeneralSettings']);
const qboExportSettingsServiceSpy = jasmine.createSpyObj('QboExportSettingsService', ['getExportSettings']);
const importSettingServiceSpy = jasmine.createSpyObj('QboImportSettingsService', ['getImportSettings']);

await TestBed.configureTestingModule({
declarations: [ QboDashboardComponent ]
})
.compileComponents();
declarations: [ QboDashboardComponent ],
providers: [
{ provide: AccountingExportService, useValue: accountingExportServiceSpy },
{ provide: DashboardService, useValue: dashboardServiceSpy },
{ provide: WorkspaceService, useValue: workspaceServiceSpy },
{ provide: QboExportSettingsService, useValue: qboExportSettingsServiceSpy },
{ provide: QboImportSettingsService, useValue: importSettingServiceSpy }
],
schemas: [NO_ERRORS_SCHEMA]
}).compileComponents();

accountingExportService = TestBed.inject(AccountingExportService) as jasmine.SpyObj<AccountingExportService>;
dashboardService = TestBed.inject(DashboardService) as jasmine.SpyObj<DashboardService>;
workspaceService = TestBed.inject(WorkspaceService) as jasmine.SpyObj<WorkspaceService>;
qboExportSettingsService = TestBed.inject(QboExportSettingsService) as jasmine.SpyObj<QboExportSettingsService>;
importSettingService = TestBed.inject(QboImportSettingsService) as jasmine.SpyObj<QboImportSettingsService>;
});

beforeEach(() => {
fixture = TestBed.createComponent(QboDashboardComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

it('should create', () => {
expect(component).toBeTruthy();
});
});

it('should initialize with correct default values', () => {
expect(component.isLoading).toBeTrue();
expect(component.appName).toBe(AppName.QBO);
expect(component.isImportInProgress).toBeTrue();
expect(component.isExportInProgress).toBeFalse();
expect(component.exportableAccountingExportIds).toEqual([]);
expect(component.failedExpenseGroupCount).toBe(0);
expect(component.exportProgressPercentage).toBe(0);
expect(component.accountingExportSummary).toBeUndefined();
expect(component.processedCount).toBe(0);
});

it('should setup page correctly', fakeAsync(() => {
dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
accountingExportService.getAccountingExportSummary.and.returnValue(of(mockAccountingExportSummary));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));
qboExportSettingsService.getExportSettings.and.returnValue(of(mockExportSettingsForDashboard as QBOExportSettingGet));
importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));
qboExportSettingsService.getExportSettings.and.returnValue(of(mockExportSettings));
component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

component.ngOnInit();
tick();
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);
expect(component.errors).toEqual(DashboardModel.parseAPIResponseToGroupedError(mockExportErrors));
expect(component.isImportItemsEnabled).toBe(mockWorkspaceGeneralSettingsForDashboard.import_items);
expect(component.accountingExportSummary).toEqual(AccountingExportSummaryModel.parseAPIResponseToAccountingSummary(mockAccountingExportSummary));
expect(component.destinationFieldMap).toEqual({
EMPLOYEE: mockWorkspaceGeneralSettingsForDashboard.employee_field_mapping,
CATEGORY: 'ACCOUNT'
});
expect(component.isLoading).toBeFalse();
expect(component.importCodeFields).toEqual(mockImportSettingsForDashboard.workspace_general_settings.import_code_fields);
expect(component.exportableAccountingExportIds).toEqual(mockExportableExpenseGroup.exportable_expense_group_ids);
expect(component.failedExpenseGroupCount).toBe(12);
expect(component.reimbursableImportState).toBe(ReimbursableImportState.PROCESSING);
expect(component.cccImportState).toBe(CCCImportState.APPROVED);
expect(component.isImportInProgress).toBeFalse();
}));

it('should set reimbursableImportState to null when reimbursable_expenses_object is falsy', fakeAsync(() => {
const modifiedSettings = { ...mockExportSettingsForDashboard };
modifiedSettings.workspace_general_settings.reimbursable_expenses_object = null as unknown as string;

dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
accountingExportService.getAccountingExportSummary.and.returnValue(of(mockAccountingExportSummary));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));
qboExportSettingsService.getExportSettings.and.returnValue(of(modifiedSettings as QBOExportSettingGet));
importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));

component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

component.ngOnInit();
tick();

expect(component.reimbursableImportState).toBeNull();
}));

it('should set cccImportState to null when corporate_credit_card_expenses_object is falsy', fakeAsync(() => {
const modifiedSettings = { ...mockExportSettingsForDashboard };
modifiedSettings.workspace_general_settings.corporate_credit_card_expenses_object = null as unknown as string;

dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
accountingExportService.getAccountingExportSummary.and.returnValue(of(mockAccountingExportSummary));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));
qboExportSettingsService.getExportSettings.and.returnValue(of(modifiedSettings as QBOExportSettingGet));
importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));

component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

component.ngOnInit();
tick();

expect(component.cccImportState).toBeNull();
}));

it('should handle error in getAccountingExportSummary', fakeAsync(() => {
dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));
qboExportSettingsService.getExportSettings.and.returnValue(of(mockExportSettingsForDashboard as QBOExportSettingGet));
importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));

component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = throwError(() => new Error('API error'));

component.ngOnInit();
tick();

expect(component.accountingExportSummary).toBeUndefined();
}));

it('should trigger export and poll export status', fakeAsync(() => {
dashboardService.triggerAccountingExport.and.returnValue(of({}));
dashboardService.getAllTasks.and.returnValue(of(mockQBOCompletedTaskResponse));

component.getExportErrors$ = of([]);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

component.exportableAccountingExportIds = [1];
component.export();
tick(3000);

expect(component.isExportInProgress).toBeFalse();
expect(component.exportProgressPercentage).toBe(0);
expect(component.processedCount).toBe(0);
expect(dashboardService.triggerAccountingExport).toHaveBeenCalledTimes(1);
expect(dashboardService.getAllTasks).toHaveBeenCalledTimes(1);
}));

it('should handle export with failed tasks', fakeAsync(() => {
dashboardService.triggerAccountingExport.and.returnValue(of({}));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));

component.getExportErrors$ = of([]);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

component.exportableAccountingExportIds = [16078, 16081];
component.export();
tick(3000);

expect(component.failedExpenseGroupCount).toBe(12);
expect(component.exportableAccountingExportIds).toEqual(mockQBOTaskResponse.results.filter(task => task.status === TaskLogState.FAILED || task.status === TaskLogState.FATAL).map(task => task.expense_group));
expect(component.isExportInProgress).toBeFalse();
expect(component.exportProgressPercentage).toBe(0);
expect(component.processedCount).toBe(0);
}));

it('should setup page with error handling', fakeAsync(() => {
dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
accountingExportService.getAccountingExportSummary.and.returnValue(throwError(() => new Error('API error')));
dashboardService.getAllTasks.and.returnValue(of(mockQBOTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));

// Modify the mock settings to have empty strings for reimbursable and corporate credit card expenses objects
const modifiedSettings = { ...mockExportSettingsForDashboard };
modifiedSettings.workspace_general_settings.reimbursable_expenses_object = '';
modifiedSettings.workspace_general_settings.corporate_credit_card_expenses_object = '';
qboExportSettingsService.getExportSettings.and.returnValue(of(modifiedSettings as QBOExportSettingGet));

importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));

component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = throwError(() => new Error('API error'));

component.ngOnInit();
tick();
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);
expect(component.failedExpenseGroupCount).toBe(12);
expect(component.reimbursableImportState).toBeNull();
expect(component.cccImportState).toBeNull();
expect(component.accountingExportSummary).toBeUndefined();
expect(component.isLoading).toBeFalse();
expect(component.isImportInProgress).toBeFalse();
expect(component.isExportInProgress).toBeFalse();
}));

it('should handle queued tasks and start polling export status', fakeAsync(() => {
dashboardService.getExportErrors.and.returnValue(of(mockExportErrors));
accountingExportService.getAccountingExportSummary.and.returnValue(of(mockAccountingExportSummary));
dashboardService.getAllTasks.and.returnValue(of(mockQBOEnqueuedTaskResponse));
workspaceService.getWorkspaceGeneralSettings.and.returnValue(of(mockWorkspaceGeneralSettingsForDashboard));
dashboardService.getExportableAccountingExportIds.and.returnValue(of(mockExportableExpenseGroup));
qboExportSettingsService.getExportSettings.and.returnValue(of(mockExportSettingsForDashboard as QBOExportSettingGet));
importSettingService.getImportSettings.and.returnValue(of(mockImportSettingsForDashboard as QBOImportSettingGet));
accountingExportService.importExpensesFromFyle.and.returnValue(of({}));

component.getExportErrors$ = of(mockExportErrors);
component.getAccountingExportSummary$ = of(mockAccountingExportSummary);

spyOn<any>(component, 'pollExportStatus').and.callThrough();

component.ngOnInit();
tick();

expect(component.isExportInProgress).toBeTrue();
expect(component['pollExportStatus']).toHaveBeenCalledWith(mockExportableExpenseGroup.exportable_expense_group_ids);

// Simulate completion of tasks
dashboardService.getAllTasks.and.returnValue(of(mockQBOCompletedTaskResponse));

tick(6000);
discardPeriodicTasks();

expect(component.isExportInProgress).toBeFalse();
}));
});
Loading

0 comments on commit 1493a07

Please sign in to comment.