Use new tab for oauth (#612)

* Use new tab for oauth * Use new tab for oauth
fylein · Mar 1, 2024 · 30d54c6 · 30d54c6
1 parent 42ad634
commit 30d54c6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/app/core/services/common/helper.service.ts b/src/app/core/services/common/helper.service.ts
@@ -207,7 +207,7 @@ export class HelperService {
   }
 
   oauthHandler(url: string): void {
-    const popup = window.open(url, 'popup', 'popup=true, width=500, height=800, left=500');
+    const popup = window.open(url);
 
     const activePopup = setInterval(() => {
       if (popup?.location?.href?.includes('code')) {

diff --git a/src/app/integrations/qbd/onboarding/onboarding-landing/landing.component.html b/src/app/integrations/qbd/onboarding/onboarding-landing/landing.component.html
@@ -3,6 +3,6 @@
         <app-landing-page-header [iconPath]="'assets/logos/quickbooks-desktop.svg'" [appName]="'QuickBooks Desktop'" [appDescription]="'Generate IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop'" [isLoading]="isLoading" [isIntegrationSetupInProgress]="isQBDSetupInProgress" [isIntegrationConnected]="isQBDConnected" [postConnectionRoute]="'qbd/onboarding/export_settings'" [buttonText]="'Start'"></app-landing-page-header>
     </div>
     <div>
-        <app-landing-page-body [headerText]="'Configure the integration to generate custom IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop.'" [svgPath]="'assets/flow-charts/qbd-flow-chart.svg'" [redirectLink]="brandingKbArticles.topLevelArticles.QBO" [appName]="appName"></app-landing-page-body>
+        <app-landing-page-body [headerText]="'Configure the integration to generate custom IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop.'" [svgPath]="'assets/flow-charts/qbd-flow-chart.svg'" [redirectLink]="brandingKbArticles.topLevelArticles.QBD" [appName]="appName"></app-landing-page-body>
     </div>
 </div>
diff --git a/...ntegrations/qbo/qbo-onboarding/qbo-onboarding-landing/qbo-onboarding-landing.component.ts b/...ntegrations/qbo/qbo-onboarding/qbo-onboarding-landing/qbo-onboarding-landing.component.ts
@@ -23,7 +23,7 @@ export class QboOnboardingLandingComponent implements OnInit, OnDestroy {
 
   brandingConfig = brandingConfig;
 
-  redirectLink = brandingKbArticles.onboardingArticles.QBO.CONNECTOR;
+  redirectLink = brandingKbArticles.topLevelArticles.QBO;
 
   embedVideoLink = brandingDemoVideoLinks.onboarding.QBO;
 

diff --git a/src/app/integrations/travelperk/travelperk.component.ts b/src/app/integrations/travelperk/travelperk.component.ts
@@ -77,7 +77,7 @@ export class TravelperkComponent implements OnInit {
     this.isConnectionInProgress = true;
     const url = `${environment.travelperk_base_url}/oauth2/authorize?client_id=${environment.travelperk_client_id}&redirect_uri=${environment.travelperk_redirect_uri}&scope=expenses:read&response_type=code&state=${environment.production ? this.org.id : `${this.org.id}_travelperk_local_redirect`}`;
 
-    const popup = window.open(url, 'popup', 'popup=true, width=500, height=800, left=500');
+    const popup = window.open(url);
 
     const activePopup = setInterval(() => {
       try {