Few more sentence case fixes (#589)

fylein · Feb 21, 2024 · 3b468a7 · 3b468a7
1 parent 26531d6
commit 3b468a7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/app/branding/branding-config.ts b/src/app/branding/branding-config.ts
@@ -214,11 +214,14 @@ const content: ContentConfiguration = {
                 headerText: 'Export Corporate Card Expenses',
                 contentText: 'Enable this to export the Non-Reimbursable expenses from ' + brandingConfig.brandName + '. If not enabled, any <b>out-of-pocket</b> expenses will not be exported to QuickBooks Online',
                 corporateCard: {
+                    expenseState: 'Select CCC expense state',
                     sectionLabel: '',
                     subLabel: '',
                     exportSubLabel: '',
                     defaultCCCAccountLabel: 'Set Default Credit Card Account as',
+                    defaultCCCAccountPlaceholder: 'Select Default Credit Card Account',
                     defaultDebitCardAccountLabel: 'Set Default Debit Card Account as',
+                    defaultDebitCardAccountPlaceholder: 'Select Default Debit Card Account',
                     defaultCCCVendorLabel: 'Set default corporate Card Vendor as',
                     accountsPayableLabel: 'To which Accounts Payable account should the ',
                     accountsPayableSubLabel: ' to the selected Accounts Payable Account.',
@@ -317,11 +320,14 @@ const content: ContentConfiguration = {
                 headerText: 'Export corporate card expenses',
                 contentText: 'Enable this to export the non-reimbursable expenses from ' + brandingConfig.brandName + ' if not enabled, any <b>out-of-pocket</b> expenses will not be exported to QuickBooks Online',
                 corporateCard: {
+                    expenseState: 'Select ccc expense state',
                     sectionLabel: '',
                     subLabel: '',
                     exportSubLabel: '',
                     defaultCCCAccountLabel: 'Set default credit card account as',
+                    defaultCCCAccountPlaceholder: 'Select default credit card account',
                     defaultDebitCardAccountLabel: 'Set default debit card account as',
+                    defaultDebitCardAccountPlaceholder: 'Select default debit card account',
                     defaultCCCVendorLabel: 'Set default corporate card vendor as',
                     accountsPayableLabel: 'To which accounts payable account should the ',
                     accountsPayableSubLabel: ' to the selected accounts payable Account.',

diff --git a/src/app/core/models/branding/content-configuration.model.ts b/src/app/core/models/branding/content-configuration.model.ts
@@ -12,11 +12,14 @@ export type ContentConfiguration = {
                 headerText: string;
                 contentText: string;
                 corporateCard: {
+                    expenseState: string;
                     sectionLabel: string;
                     subLabel: string;
                     exportSubLabel: string;
                     defaultCCCAccountLabel: string;
+                    defaultCCCAccountPlaceholder: string;
                     defaultDebitCardAccountLabel: string;
+                    defaultDebitCardAccountPlaceholder: string;
                     defaultCCCVendorLabel: string;
                     accountsPayableLabel: string;
                     accountsPayableSubLabel: string;

diff --git a/src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html b/src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html
@@ -184,7 +184,7 @@
                               [mandatoryErrorListName]="'credit card account'"
                               [label]="brandingContent.corporateCard.defaultCCCAccountLabel"
                               [subLabel]="'Post all your company corporate card transactions to a default credit card account.'"
-                              [placeholder]="'Select Default Credit Card Account'"
+                              [placeholder]="brandingContent.corporateCard.defaultCCCAccountPlaceholder"
                               [formControllerName]="'defaultCCCAccount'">
                             </app-configuration-select-field>
                         </div>
@@ -199,7 +199,7 @@
                               [mandatoryErrorListName]="'debit card account'"
                               [label]="brandingContent.corporateCard.defaultDebitCardAccountLabel"
                               [subLabel]="'Post all your company debit card transactions to a default debit card account.'"
-                              [placeholder]="'Select Default Debit Card Account'"
+                              [placeholder]="brandingContent.corporateCard.defaultDebitCardAccountPlaceholder"
                               [formControllerName]="'defaultDebitCardAccount'">
                             </app-configuration-select-field>
                         </div>
@@ -244,7 +244,7 @@
                             [subLabel]="brandingContent.corporateCard.creditCardExpenseSubLabel"
                             [options]="cccExpenseStateOptions"
                             [iconPath]="'list'"
-                            [placeholder]="'Select CCC expense state'"
+                            [placeholder]="brandingContent.corporateCard.expenseState"
                             [formControllerName]="'cccExpenseState'">
                         </app-configuration-select-field>
                     </div>
@@ -272,7 +272,7 @@
                             [subLabel]="'The selected date will reflect in the corporate card expenses exported to QuickBooks Online.'"
                             [options]="cccExpenseGroupingDateOptions"
                             [iconPath]="'calendar'"
-                            [placeholder]="'Select the date of the ' + (exportSettingForm.value.creditCardExportType | snakeCaseToSpaceCase | titlecase)"
+                            [placeholder]="'Select the date of the ' + (brandingConfig.brandId === 'fyle' ? (exportSettingForm.value.creditCardExportType | snakeCaseToSpaceCase | titlecase) : (exportSettingForm.value.creditCardExportType | snakeCaseToSpaceCase | lowercase))"
                             [formControllerName]="'creditCardExportDate'">
                         </app-configuration-select-field>
                     </div>