Skip to content

Commit

Permalink
fix: Add an "Export Date" option to QBO CCP date options (#1148)
Browse files Browse the repository at this point in the history
(cherry picked from commit c80e1ba)
  • Loading branch information
JustARatherRidiculouslyLongUsername committed Jan 13, 2025
1 parent a78f9b5 commit 7476ce4
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ExpenseField, ImportCodeFieldConfigType, ImportSettingsModel } from 'sr
import { SelectFormOption } from 'src/app/core/models/common/select-form-option.model';
import { DefaultDestinationAttribute, DestinationAttribute } from 'src/app/core/models/db/destination-attribute.model';
import { FyleField, IntegrationField } from 'src/app/core/models/db/mapping.model';
import { AppName, AutoMapEmployeeOptions, ConfigurationCta, ConfigurationWarningEvent, DefaultImportFields, EmployeeFieldMapping, ExpenseGroupingFieldOption, InputType, NameInJournalEntry, QBOCorporateCreditCardExpensesObject, QBOField, QBOReimbursableExpensesObject, ToastSeverity } from 'src/app/core/models/enum/enum.model';
import { AppName, AutoMapEmployeeOptions, ConfigurationCta, ConfigurationWarningEvent, DefaultImportFields, EmployeeFieldMapping, ExpenseGroupingFieldOption, ExportDateType, InputType, NameInJournalEntry, QBOCorporateCreditCardExpensesObject, QBOField, QBOReimbursableExpensesObject, ToastSeverity } from 'src/app/core/models/enum/enum.model';
import { ConfigurationWarningOut } from 'src/app/core/models/misc/configuration-warning.model';
import { OnboardingStepper } from 'src/app/core/models/misc/onboarding-stepper.model';
import { Org } from 'src/app/core/models/org/org.model';
Expand Down Expand Up @@ -324,13 +324,23 @@ export class QboCloneSettingsComponent implements OnInit {
private updateCCCExpenseGroupingDateOptions(selectedValue: QBOCorporateCreditCardExpensesObject): void {
if ([QBOCorporateCreditCardExpensesObject.CREDIT_CARD_PURCHASE, QBOCorporateCreditCardExpensesObject.DEBIT_CARD_EXPENSE].includes(selectedValue)) {
this.cccExpenseGroupingDateOptions = QBOExportSettingModel.getAdditionalCreditCardExpenseGroupingDateOptions();
if (selectedValue === QBOCorporateCreditCardExpensesObject.CREDIT_CARD_PURCHASE) {
this.cccExpenseGroupingDateOptions.push({
label: brandingContent.common.currentDate,
value: ExportDateType.CURRENT_DATE
});
}
this.exportSettingForm.controls.creditCardExportGroup.setValue(ExpenseGroupingFieldOption.EXPENSE_ID);
this.exportSettingForm.controls.creditCardExportGroup.disable();
} else {
this.cccExpenseGroupingDateOptions = this.reimbursableExpenseGroupingDateOptions.concat();
this.helperService.clearValidatorAndResetValue(this.exportSettingForm, 'creditCardExportGroup');
this.helperService.enableFormField(this.exportSettingForm, 'creditCardExportGroup');
}
const allowedValues = this.cccExpenseGroupingDateOptions.map(option => option.value);
if (!allowedValues.includes(this.exportSettingForm.get('creditCardExportDate')?.value)) {
this.exportSettingForm.get('creditCardExportDate')?.setValue(null);
}
}

private initializeCustomFieldForm(shouldShowDialog: boolean) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { brandingConfig, brandingContent, brandingFeatureConfig, brandingKbArtic
import { ExportSettingModel, ExportSettingOptionSearch } from 'src/app/core/models/common/export-settings.model';
import { SelectFormOption } from 'src/app/core/models/common/select-form-option.model';
import { DefaultDestinationAttribute, DestinationAttribute, PaginatedDestinationAttribute } from 'src/app/core/models/db/destination-attribute.model';
import { AppName, ConfigurationCta, ConfigurationWarningEvent, EmployeeFieldMapping, ExpenseGroupingFieldOption, FyleField, QBOCorporateCreditCardExpensesObject, QBOOnboardingState, QBOReimbursableExpensesObject, QboExportSettingDestinationOptionKey, ToastSeverity } from 'src/app/core/models/enum/enum.model';
import { AppName, ConfigurationCta, ConfigurationWarningEvent, EmployeeFieldMapping, ExpenseGroupingFieldOption, ExportDateType, FyleField, QBOCorporateCreditCardExpensesObject, QBOOnboardingState, QBOReimbursableExpensesObject, QboExportSettingDestinationOptionKey, ToastSeverity } from 'src/app/core/models/enum/enum.model';
import { ConfigurationWarningOut } from 'src/app/core/models/misc/configuration-warning.model';
import { QBOExportSettingGet, QBOExportSettingModel } from 'src/app/core/models/qbo/qbo-configuration/qbo-export-setting.model';
import { HelperService } from 'src/app/core/services/common/helper.service';
Expand Down Expand Up @@ -315,12 +315,22 @@ export class QboExportSettingsComponent implements OnInit {
private updateCCCExpenseGroupingDateOptions(selectedValue: QBOCorporateCreditCardExpensesObject): void {
if ([QBOCorporateCreditCardExpensesObject.CREDIT_CARD_PURCHASE, QBOCorporateCreditCardExpensesObject.DEBIT_CARD_EXPENSE].includes(selectedValue)) {
this.cccExpenseGroupingDateOptions = QBOExportSettingModel.getAdditionalCreditCardExpenseGroupingDateOptions();
if (selectedValue === QBOCorporateCreditCardExpensesObject.CREDIT_CARD_PURCHASE) {
this.cccExpenseGroupingDateOptions.push({
label: brandingContent.common.currentDate,
value: ExportDateType.CURRENT_DATE
});
}
this.exportSettingForm.controls.creditCardExportGroup.setValue(ExpenseGroupingFieldOption.EXPENSE_ID);
this.exportSettingForm.controls.creditCardExportGroup.disable();
} else {
this.cccExpenseGroupingDateOptions = this.reimbursableExpenseGroupingDateOptions.concat();
this.helperService.enableFormField(this.exportSettingForm, 'creditCardExportGroup');
}
const allowedValues = this.cccExpenseGroupingDateOptions.map(option => option.value);
if (!allowedValues.includes(this.exportSettingForm.get('creditCardExportDate')?.value)) {
this.exportSettingForm.get('creditCardExportDate')?.setValue(null);
}
}

private setupCustomWatchers(): void {
Expand Down

0 comments on commit 7476ce4

Please sign in to comment.