-
Notifications
You must be signed in to change notification settings - Fork 0
test: intacct import settings watchers #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fdda416
2497372
7f330b7
b712977
e9542a9
d002950
45bfa0f
202ec33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,6 +202,7 @@ describe('IntacctImportSettingsComponent', () => { | |
| }); | ||
| }); | ||
|
|
||
|
|
||
| describe('Save', () => { | ||
| it('should successfully save import settings during onboarding', fakeAsync(() => { | ||
| siWorkspaceService.getIntacctOnboardingState.and.returnValue(IntacctOnboardingState.IMPORT_SETTINGS); | ||
|
|
@@ -287,4 +288,104 @@ describe('IntacctImportSettingsComponent', () => { | |
| ); | ||
| })); | ||
| }); | ||
|
|
||
| describe('Watchers', () => { | ||
| describe('Import Settings Watcher', () => { | ||
| beforeEach(() => { | ||
| component.ngOnInit(); | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should trigger custom field dialog when a source field is set to custom_field', () => { | ||
| const expenseFieldArray = component.importSettingsForm.get('expenseFields') as FormArray; | ||
| spyOn(component as any, 'addCustomField').and.callThrough(); | ||
|
|
||
| const firstControl = expenseFieldArray.at(0); | ||
| firstControl.patchValue({ | ||
| source_field: 'custom_field', | ||
| destination_field: 'TEST_FIELD', | ||
| import_to_fyle: true | ||
| }); | ||
|
|
||
| expect(component['addCustomField']).toHaveBeenCalled(); | ||
| expect(component.showDialog).toBeTrue(); | ||
| expect(component.customFieldControl).toEqual(firstControl); | ||
| }); | ||
|
|
||
| it('should update validators when importTaxCodes value changes', () => { | ||
| const taxCodesControl = component.importSettingsForm.get('sageIntacctTaxCodes'); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| importTaxCodes: true | ||
| }); | ||
| expect(taxCodesControl?.hasValidator(Validators.required)).toBeTrue(); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| importTaxCodes: false | ||
| }); | ||
| expect(taxCodesControl?.hasValidator(Validators.required)).toBeFalse(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Cost Codes and Cost Types Watcher', () => { | ||
| beforeEach(() => { | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should handle isDependentImportEnabled changes', () => { | ||
| const costCodesControl = component.importSettingsForm.get('costCodes'); | ||
| const costTypesControl = component.importSettingsForm.get('costTypes'); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| isDependentImportEnabled: true | ||
| }); | ||
|
|
||
| expect(costCodesControl?.enabled).toBeTrue(); | ||
| expect(costTypesControl?.enabled).toBeTrue(); | ||
| expect(costCodesControl?.hasValidator(Validators.required)).toBeTrue(); | ||
| expect(costTypesControl?.hasValidator(Validators.required)).toBeTrue(); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| isDependentImportEnabled: false | ||
| }); | ||
|
|
||
| expect(costCodesControl?.enabled).toBeFalse(); | ||
| expect(costTypesControl?.enabled).toBeFalse(); | ||
| expect(costCodesControl?.hasValidator(Validators.required)).toBeFalse(); | ||
| expect(costTypesControl?.hasValidator(Validators.required)).toBeFalse(); | ||
| }); | ||
|
|
||
| it('should handle custom field selection for cost codes', () => { | ||
| spyOn(component as any, 'addCustomField').and.callThrough(); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| costCodes: { | ||
| attribute_type: 'custom_field', | ||
| source_field: 'custom_field' | ||
| } | ||
| }); | ||
|
|
||
| expect(component['addCustomField']).toHaveBeenCalled(); | ||
| expect(component.customFieldForDependentField).toBeTrue(); | ||
|
Comment on lines
+359
to
+369
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Avoid spying on private methods in tests Similar to the previous comment, you are spying on the private method |
||
| expect(component.customFieldControl).toBe(component.importSettingsForm.get('costCodes')!); | ||
| expect(component.importSettingsForm.get('costCodes')?.value.source_field).toBeNull(); | ||
| }); | ||
|
|
||
| it('should handle custom field selection for cost types', () => { | ||
| spyOn(component as any, 'addCustomField').and.callThrough(); | ||
|
|
||
| component.importSettingsForm.patchValue({ | ||
| costTypes: { | ||
| attribute_type: 'custom_field', | ||
| source_field: 'custom_field' | ||
| } | ||
| }); | ||
|
|
||
| expect(component['addCustomField']).toHaveBeenCalled(); | ||
| expect(component.customFieldForDependentField).toBeTrue(); | ||
| expect(component.customFieldControl).toBe(component.importSettingsForm.get('costTypes')!); | ||
| expect(component.importSettingsForm.get('costTypes')?.value.source_field).toBeNull(); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
Uh oh!
There was an error while loading. Please reload this page.