test: fix flaky test

[anishfyle]

Description

• removed flaky test

Clickup

https://app.clickup.com/t/86cwabccw

Summary by CodeRabbit

• Bug Fixes
  • Simplified the test cases for the visibility of the auto-create vendors field in the QboAdvancedSettingsComponent, ensuring accurate behavior verification under specified conditions.

[coderabbitai]

Walkthrough

The changes involve modifications to the test suite for the QboAdvancedSettingsComponent, specifically in the file qbo-advanced-settings.component.spec.ts. A test case has been removed from the isAutoCreateVendorsFieldVisible describe block, which previously checked if the method returned true under certain conditions. The remaining tests continue to validate the method's behavior under various scenarios, maintaining the overall structure of the test suite without adding or altering other tests.

Changes

File	Change Summary
src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.spec.ts	Removed a test case from the isAutoCreateVendorsFieldVisible describe block; other tests remain unchanged.

Possibly related PRs

• test: Export Settings QBO #931: The changes in the test suite for QboExportSettingsComponent may relate to the overall testing framework and structure used in the QboAdvancedSettingsComponent, although they focus on different components.
• test: fix failing tests due to outdated router spies #1004: Modifications to the QboComponent test suite involve similar testing strategies and structures that could be relevant to the testing practices applied in the QboAdvancedSettingsComponent.
• test: intacct import settings watchers #1010: Enhancements in the IntacctImportSettingsComponent test suite may share testing methodologies that could be applicable to the QboAdvancedSettingsComponent, particularly in terms of structure and organization of tests.

Suggested reviewers

• DhaaraniCIT
• ashwin1111

🐇 In the meadow where bunnies play,
A test was removed, oh what a day!
Simplified checks, clear as can be,
For the vendors' field, so easy to see.
Hops of joy in the code we write,
Testing is fun, everything feels right! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7d9fcd9 and e2b53b6.

📒 Files selected for processing (1)

• src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.spec.ts (0 hunks)

💤 Files with no reviewable changes (1)

• src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

PR description must contain a link to a ClickUp (case-insensitive)

[github-actions]

PR description must contain a link to a ClickUp (case-insensitive)