Skip to content

fix: remove AppCues #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: remove AppCues #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions src/app/core/services/integration/appcues.service.spec.ts
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions src/app/core/services/integration/appcues.service.ts
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/app/integrations/intacct/intacct.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { IntacctComponent } from './intacct.component';
import { HelperService } from 'src/app/core/services/common/helper.service';
import { StorageService } from 'src/app/core/services/common/storage.service';
import { WindowService } from 'src/app/core/services/common/window.service';
import { AppcuesService } from 'src/app/core/services/integration/appcues.service';
import { UserService } from 'src/app/core/services/misc/user.service';
import { SiWorkspaceService } from 'src/app/core/services/si/si-core/si-workspace.service';
import { AppUrl, IntacctOnboardingState } from 'src/app/core/models/enum/enum.model';
Expand All @@ -22,15 +21,13 @@ describe('IntacctComponent', () => {
let helperServiceSpy: jasmine.SpyObj<HelperService>;
let storageServiceSpy: jasmine.SpyObj<StorageService>;
let windowServiceMock: Partial<WindowService>;
let appcuesServiceSpy: jasmine.SpyObj<AppcuesService>;
let router: Router;

beforeEach(async () => {
const userSpy = jasmine.createSpyObj('UserService', ['getUserProfile']);
const workspaceSpy = jasmine.createSpyObj('SiWorkspaceService', ['getWorkspace', 'postWorkspace', 'syncFyleDimensions', 'syncIntacctDimensions']);
const helperSpy = jasmine.createSpyObj('HelperService', ['setBaseApiURL']);
const storageSpy = jasmine.createSpyObj('StorageService', ['set']);
const appcuesSpy = jasmine.createSpyObj('AppcuesService', ['initialiseAppcues']);

windowServiceMock = {
get nativeWindow() {
Expand All @@ -47,7 +44,6 @@ describe('IntacctComponent', () => {
imports: [SharedModule, HttpClientTestingModule],
providers: [
{ provide: HelperService, useValue: helperSpy },
{ provide: AppcuesService, useValue: appcuesSpy },
{ provide: StorageService, useValue: storageSpy },
{ provide: UserService, useValue: userSpy },
{ provide: SiWorkspaceService, useValue: workspaceSpy },
Expand All @@ -61,7 +57,6 @@ describe('IntacctComponent', () => {
helperServiceSpy = TestBed.inject(HelperService) as jasmine.SpyObj<HelperService>;
storageServiceSpy = TestBed.inject(StorageService) as jasmine.SpyObj<StorageService>;
router = TestBed.inject(Router);
appcuesServiceSpy = TestBed.inject(AppcuesService) as jasmine.SpyObj<AppcuesService>;

spyOn(router, 'navigateByUrl');
spyOnProperty(router, 'events').and.returnValue(of(new NavigationEnd(0, '', '')));
Expand Down Expand Up @@ -122,15 +117,4 @@ describe('IntacctComponent', () => {

expect(router.navigateByUrl).not.toHaveBeenCalled();
});

it('should initialise Appcues', () => {
(window as any).Appcues = {
page: jasmine.createSpy('Appcues.page')
};

fixture.detectChanges();

expect(appcuesServiceSpy.initialiseAppcues).toHaveBeenCalled();
expect((window as any).Appcues.page).toHaveBeenCalled();
});
});
8 changes: 0 additions & 8 deletions src/app/integrations/intacct/intacct.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { IntacctWorkspace } from 'src/app/core/models/intacct/db/workspaces.mode
import { HelperService } from 'src/app/core/services/common/helper.service';
import { StorageService } from 'src/app/core/services/common/storage.service';
import { WindowService } from 'src/app/core/services/common/window.service';
import { AppcuesService } from 'src/app/core/services/integration/appcues.service';
import { UserService } from 'src/app/core/services/misc/user.service';
import { SiWorkspaceService } from 'src/app/core/services/si/si-core/si-workspace.service';
import { SiAuthService } from 'src/app/core/services/si/si-core/si-auth.service';
Expand All @@ -27,7 +26,6 @@ export class IntacctComponent implements OnInit {
windowReference: Window;

constructor(
private appcuesService: AppcuesService,
private helperService: HelperService,
private router: Router,
private route: ActivatedRoute,
Expand Down Expand Up @@ -59,7 +57,6 @@ export class IntacctComponent implements OnInit {
this.workspace = workspace;
this.storageService.set('workspaceId', this.workspace.id);
this.storageService.set('onboarding-state', this.workspace.onboarding_state);
this.appcuesService.initialiseAppcues(AppName.INTACCT, this.workspace.created_at);
this.workspaceService.syncFyleDimensions().subscribe();
this.workspaceService.syncIntacctDimensions().subscribe();
this.isLoading = false;
Expand Down Expand Up @@ -94,11 +91,6 @@ export class IntacctComponent implements OnInit {
}

ngOnInit(): void {
this.router.events.subscribe((event) => {
if (event instanceof NavigationEnd) {
(window as any).Appcues && (window as any).Appcues.page();
}
});
this.handleAuthParameters();
}

Expand Down
8 changes: 0 additions & 8 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@
}
</script>

<!-- appcues -->
<script type="text/javascript">
window.AppcuesSettings = {
enableURLDetection: true
};
</script>
<script src="https://fast.appcues.com/71692.js"></script>

<!-- refiner.io -->
<script type="text/javascript">
if (window.location.hostname !== "localhost") {
Expand Down
Loading