fix: business central beta

[JustARatherRidiculouslyLongUsername]

Clickup

https://app.clickup.com/t/86cx5ryr4

Summary by CodeRabbit

• New Features

  • Updated the export log table to conditionally display the "Link to {{appName}}" column based on the application name, excluding AppName.BUSINESS_CENTRAL.
  • Enhanced clarity in the business central export settings with updated labels and descriptions for employee and vendor mapping.
  • Improved descriptions for imported accounts and vendors in import settings to clarify their dropdown functionality.
  • Added a "Beta" badge for the Dynamics 365 Business Central integration, enhancing visual representation.

• Bug Fixes

  • Ensured proper rendering of table columns when certain application names are selected, enhancing the clarity of the export log.

[coderabbitai]

Walkthrough

The changes in the export-log-table.component.html file involve updating the conditional rendering logic for the "Link to {{appName}}" column in a table. The condition now excludes the application name AppName.BUSINESS_CENTRAL, in addition to the existing exclusions for AppName.SAGE300 and AppName.QBD_DIRECT. This affects both the header and body sections of the table, ensuring that the column is not displayed under the specified conditions. Additional modifications include updates to labels and sub-labels in various components related to Business Central.

Changes

File Path	Change Summary
src/app/shared/components/export-log/export-log-table/export-log-table.component.html	Updated conditional rendering for "Link to {{appName}}" column to exclude AppName.BUSINESS_CENTRAL.
src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html	Updated labels and sub-labels for employee mapping and export states for clarity.
src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html	Revised sub-labels for toggle fields to enhance clarity regarding imported accounts and vendors.
src/app/integrations/landing/landing.component.html	Added a "Beta" badge conditionally based on organization ID and enhanced styling for the name span.
src/app/integrations/landing/landing.component.ts	Introduced a new readonly property orgsToHideBusinessCentralBetaBadge for organization ID configuration.
src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html	Modified conditional rendering to include an additional check for cccExportGroup in the display logic.

Possibly related PRs

• intacct code prepend #936: Modifications to the import-settings.model.ts file, potentially related to handling application names.
• fix: page size change not updating localstorage #990: Changes to pagination logic in the IntacctCompletedExportLogComponent, which may relate to export log functionality.
• test: intacct export settings edge cases and utility functions #1003: Test suite enhancements for the IntacctExportSettingsComponent, connected to export settings configurations.
• refactor: remove duplicate tests #1028: Refactoring of tests related to the IntacctExportSettingsComponent, also dealing with export settings.
• fix: qbd direct export settings onboarding changes and content changes #1082: Onboarding changes for QBD direct export settings, related to conditional rendering of export log components.
• fix: qbd direct import settings onboarding changes and content changes #1083: Onboarding changes for QBD direct import settings, potentially connecting to overall onboarding and export settings.
• fix: text changes in business central configuration #1089: Text changes in Business Central configuration, related to conditional rendering changes.
• fix: show a 'Beta' badge for business central in landing #1090: Addition of a "Beta" badge for Business Central, connecting to display logic based on appName.

Suggested reviewers

• DhaaraniCIT
• ashwin1111

Poem

🐇 In the log table, bright and clear,
A change was made, so let’s all cheer!
Excluded names, just a little tweak,
For a cleaner view, so to speak!
With each condition, we hop along,
Making our table sing a new song! 🎶

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8b1b781 and 5d9c51b.

📒 Files selected for processing (5)

• src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html (3 hunks)
• src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html (2 hunks)
• src/app/integrations/landing/landing.component.html (1 hunks)
• src/app/integrations/landing/landing.component.ts (1 hunks)
• src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html (1 hunks)

🧰 Additional context used

📓 Learnings (1)

src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html (1)

Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-11-12T04:53:12.395Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.

🔇 Additional comments (5)

src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html (1)

19-19: LGTM! Improved clarity in import settings descriptions.

The updated descriptions provide clearer guidance on how imported accounts and vendors will be utilized in the UI, making it easier for users to understand the impact of these settings.

Also applies to: 29-29

src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html (1)

102-104: LGTM! Improved conditional rendering of spent date warning.

The warning about spent date leading to multiple single line entries is now correctly shown only when the export group is set to 'REPORT', making the UI more contextually relevant.

src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html (3)

76-77: LGTM! Improved clarity in employee mapping description.

The label now correctly indicates that employees are mapped to vendors in Business Central, which better reflects the actual mapping relationship.

---

125-125: LGTM! Enhanced export state description for reimbursable expenses.

The description now uses clearer terminology, replacing "Paid" with "Closed" for the final state, which better reflects the status in Business Central.

---

255-255: LGTM! Improved export state description for corporate card expenses.

The description now uses more accurate terminology:

• "Payment processing" → "Approved" for the initial state
• "Paid" → "Closed" for the final state

This better aligns with the actual states in Business Central.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Unit Test Coverage	%	values
Statements	34.79%	( 4244 / 12196 )
Branches	28.69%	( 1228 / 4279 )
Functions	27.44%	( 938 / 3418 )
Lines	34.94%	( 4174 / 11946 )