feat: white lableing - converting all fyle reference to generic form #1154
Conversation
WalkthroughThis pull request introduces a comprehensive update to the branding configuration across multiple components and files. The primary focus is on enhancing the dynamic branding capabilities by replacing hardcoded brand references with a centralized Changes
Suggested Labels
Suggested Reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (3)
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.ts (1)
Line range hint
94-97: Move hardcoded Fyle URL to branding configuration.To complete the white labeling effort, the hardcoded Fyle URL should be moved to the branding configuration:
openExpenseinFyle(expense_id: string) { - const url = `${environment.fyle_app_url}/app/admin/#/view_expense/${expense_id}`; + const url = `${brandingContent.expenseUrlTemplate}${expense_id}`; window.open(url, '_blank'); }src/app/integrations/xero/xero-main/xero-export-log/xero-skipped-export-log/xero-skipped-export-log.component.ts (1)
Hardcoded text found in child components needs white labeling
The following instances of hardcoded text should be replaced with brandingContent references:
In export-log-filter.component.html:
- "Date of export" label
- "Start date" and "End date" placeholder text
In skipped-export-log-table.component.html:
- "Employee" column header
- "Reference ID" column header
🔗 Analysis chain
Line range hint
1-156: Verify template changes for complete white labeling.Please ensure that all hardcoded text in the corresponding template file (
xero-skipped-export-log.component.html) has been replaced with references tobrandingContent.exportLog.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining hardcoded text in the template file that might need white labeling # Look for the template file template_file=$(fd -t f "xero-skipped-export-log.component.html" --full-path) if [ ! -z "$template_file" ]; then echo "Checking template file for potential hardcoded text..." # Look for common hardcoded text patterns that might need white labeling rg -i "fyle|expense|report|export|skip" "$template_file" # Look for text content within HTML tags that might need white labeling rg -i '<[^>]*>[^<>]+</[^>]*>' "$template_file" fiLength of output: 1642
Script:
#!/bin/bash # Check child components for hardcoded text # Find and check export-log-filter component echo "Checking export-log-filter component..." fd -t f "export-log-filter.component.html" --full-path | xargs rg -i '<[^>]*>[^<>]+</[^>]*>' echo -e "\nChecking skipped-export-log-table component..." fd -t f "skipped-export-log-table.component.html" --full-path | xargs rg -i '<[^>]*>[^<>]+</[^>]*>'Length of output: 1616
src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.html (1)
Line range hint
5-5: Remaining hardcoded brand reference needs to be updatedWhile the text content has been updated to use dynamic branding, there's still a hardcoded reference to 'fyle' in the ngClass condition. This should be updated to use dynamic branding configuration for consistency with the white labeling initiative.
-<div class="tw-rounded-8-px tw-bg-white tw-border-1-px tw-border-separator" [ngClass]="{'tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}"> +<div class="tw-rounded-8-px tw-bg-white tw-border-1-px tw-border-separator" [ngClass]="brandingContent.shadowClass">
🧹 Nitpick comments (14)
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.ts (1)
69-70: Consider adding JSDoc documentation.Add JSDoc documentation to describe the purpose and usage of the
brandingContentproperty.+ /** Branding content specific to export log functionality */ readonly brandingContent = brandingContent.exportLog;src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-complete-export-log/qbd-direct-complete-export-log.component.ts (1)
5-6: Consider consolidating branding configurations.The component now has two separate branding-related imports and properties:
brandingConfigfrom 'c1-contents-config'brandingContentfrom 'branding-config'Consider consolidating these configurations into a single source of truth to improve maintainability.
Also applies to: 61-61
src/app/integrations/qbd-direct/qbd-direct-onboarding/qbd-direct-onboarding-pre-requisite/qbd-direct-onboarding-pre-requisite.component.ts (1)
56-56: Consider using template literals for better readability.The string concatenation can be improved using template literals.
- caption: 'Make sure the QuickBooks Company you want to connect to ' + brandingConfig.brandName + ' is open during the integration setup.', + caption: `Make sure the QuickBooks Company you want to connect to ${brandingConfig.brandName} is open during the integration setup.`,src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts (1)
7-7: Consider using template literals for better readability.While the white labeling implementation is correct, the string concatenation could be improved using template literals:
- label: 'Employee name on ' + brandingConfig.brandName + ' to contact name on Xero', + label: `Employee name on ${brandingConfig.brandName} to contact name on Xero`, - label: 'Employee email on ' + brandingConfig.brandName + ' to contact email on Xero', + label: `Employee email on ${brandingConfig.brandName} to contact email on Xero`,Also applies to: 97-97, 101-101
src/app/core/models/branding/content-configuration.model.ts (1)
432-433: LGTM! Consider grouping related zero state properties.The new properties are well-structured and properly typed. However, consider grouping related zero state properties into nested objects for better organization and maintainability.
Example refactor:
- dashboardExportZeroStateHeaderText: string; - dashboardExportZeroStateSubHeaderText: string; + dashboardExportZeroState: { + headerText: string; + subHeaderText: string; + }; - completeExportLogZeroStateHeaderText: string; - completeExportLogZeroStateSubHeaderText: string; - completeExportLogCountZeroStateHeaderText: string; - completeExportLogCountZeroStateSubHeaderText: string; - skipExportLogZeroStateHeaderText: string; - skipExportLogZeroStateSubHeaderText: string; - skipExportLogCountZeroStateHeaderText: string; - skipExportLogCountZeroStateSubHeaderText: string; + exportLogZeroState: { + complete: { + headerText: string; + subHeaderText: string; + countHeaderText: string; + countSubHeaderText: string; + }; + skip: { + headerText: string; + subHeaderText: string; + countHeaderText: string; + countSubHeaderText: string; + }; + }; - mappingSerchZeroStateHeaderText: string; - mappingSerchZeroStateSubHeaderText: string; - mappedHeader: string; - unMappedHeader: string; + mapping: { + searchZeroState: { + headerText: string; + subHeaderText: string; + }; + headers: { + mapped: string; + unmapped: string; + }; + };Also applies to: 446-453, 460-463
src/app/branding/c1-contents-config.ts (1)
437-439: Improve text consistency in dashboard messages.The text content could be more consistent and professional:
Apply this diff to improve the text:
- exportLogSubHeader: 'These expenses have failed to export due to some errors. Resolve the errors on your dashboard to and try to re-export them again', + exportLogSubHeader: 'These expenses have failed to export due to errors. Resolve the errors on your dashboard and try to export them again.', - dashboardExportZeroStateHeaderText: 'Looks like you have', - dashboardExportZeroStateSubHeaderText: '0 expenses to export right now' + dashboardExportZeroStateHeaderText: 'No expenses to export', + dashboardExportZeroStateSubHeaderText: 'You have no expenses ready for export at this time.'src/app/branding/fyle-contents-config.ts (1)
437-439: Improve text consistency in messages.The text content has inconsistent casing and punctuation:
Apply this diff to improve the text:
- exportLogSubHeader: 'These expenses have failed to export due to some errors. Resolve the errors on your dashboard to and try to re-export them again', + exportLogSubHeader: 'These expenses have failed to export due to errors. Resolve the errors on your dashboard and try to export them again.', - dashboardExportZeroStateHeaderText: 'Looks like you have', - dashboardExportZeroStateSubHeaderText: '0 expenses to export right now' + dashboardExportZeroStateHeaderText: 'No expenses to export', + dashboardExportZeroStateSubHeaderText: 'You have no expenses ready for export at this time.', - dateRangeLabel: 'Or, Select Date range', + dateRangeLabel: 'Or, select date range', - completeExportLogZeroStateHeaderText: 'Sorry, no results found!', - completeExportLogZeroStateSubHeaderText: 'We could not find what you were looking for. Kindly check the keywords again.', + completeExportLogZeroStateHeaderText: 'No results found', + completeExportLogZeroStateSubHeaderText: 'We could not find what you were looking for. Please check your keywords and try again.', - skipExportLogZeroStateHeaderText: 'Sorry, no results found!', - skipExportLogZeroStateSubHeaderText: 'We could not find what you were looking for. Kindly check the keywords again.', + skipExportLogZeroStateHeaderText: 'No results found', + skipExportLogZeroStateSubHeaderText: 'We could not find what you were looking for. Please check your keywords and try again.',Also applies to: 451-459
src/app/integrations/qbd-direct/qbd-direct-onboarding/qbd-direct-onboarding-landing/qbd-direct-onboarding-landing.component.html (1)
6-6: Improve integration name formatting.The hyphenated integration name could be more readable:
Apply this diff to improve the text:
- [headerText]="'A quick guide to help you set up your ' + brandingConfig.brandName + '-QuickBooks Desktop integration.'" + [headerText]="'A quick guide to help you set up your ' + brandingConfig.brandName + ' and QuickBooks Desktop integration.'"src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.html (1)
Line range hint
4-4: Consider refactoring remaining brand-specific conditional.The
ngClassdirective still contains brand-specific conditionals. Consider moving this styling logic tobrandingContentas well for consistency.-<div class="tw-rounded-8-px tw-bg-white tw-border-1-px tw-border-border-tertiary" [ngClass]="{'tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}"> +<div class="tw-rounded-8-px tw-bg-white tw-border-1-px tw-border-border-tertiary" [ngClass]="brandingContent.cardShadowClass">src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html (1)
23-24: Optimize text concatenation logic.The conditional text concatenation can be simplified as both conditions use the same base text from
brandingContent.mappingSerchZeroStateHeaderText. Consider moving this logic to the component:-[mainText]="brandingConfig.brandId === 'fyle' ? brandingContent.mappingSerchZeroStateHeaderText : brandingContent.mappingSerchZeroStateHeaderText + (this.sourceField | snakeCaseToSpaceCase | titlecase) + ' mappings.'" +[mainText]="getMappingZeroStateText()"Add this method to your component:
getMappingZeroStateText(): string { const baseText = this.brandingContent.mappingSerchZeroStateHeaderText; if (this.brandingConfig.brandId === 'fyle') { return baseText; } return `${baseText} ${this.sourceField | snakeCaseToSpaceCase | titlecase} mappings.`; }src/app/integrations/sage300/sage300-shared/sage300-advanced-settings/sage300-advanced-settings.component.html (1)
28-28: Consider moving long text strings to brandingContent.While the white labeling implementation is correct, consider moving these long text strings to the brandingContent configuration for better maintainability and consistency:
// In your branding content configuration export const brandingContent = { scheduleExportSubLabel: (brandName: string) => `Set up a schedule to frequently automate the export of expenses from ${brandName} to Sage 300 CRE.`, exportFrequencySubLabel: (brandName: string) => `Set a frequency based on how often you want your expenses in ${brandName} to be exported to Sage 300 CRE`, // ... other text configurations };Then in the template:
-[subLabel]="'Set up a schedule to frequently automate the export of expenses from ' + brandingConfig.brandName + ' to Sage 300 CRE.'" +[subLabel]="brandingContent.scheduleExportSubLabel(brandingConfig.brandName)"Also applies to: 39-39, 50-50, 75-75, 76-76
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-import-settings/qbd-direct-import-settings.component.html (1)
68-68: Move vendor import text to brandingContent.Consider moving this text string to the brandingContent configuration:
// In your branding content configuration export const brandingContent = { vendorImportSubLabel: (brandName: string) => `Vendors in QuickBooks will be imported as Merchants in ${brandName}, available in a dropdown for employees to select when coding expenses.` };Then in the template:
-[subLabel]="'Vendors in QuickBooks will be imported as Merchants in ' + brandingConfig.brandName + ', available in a dropdown for employees to select when coding expenses.'" +[subLabel]="brandingContent.vendorImportSubLabel(brandingConfig.brandName)"src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-setup-connection/qbd-direct-setup-connection.component.html (1)
63-63: Move connection setup text to brandingContent.Consider moving this text to the brandingContent configuration for consistency:
// In your branding content configuration export const brandingContent = { connectionSetupText: (brandName: string) => `Click the 'Update Selected' option to initiate a connection between ${brandName} and QuickBooks Desktop` };Then in the template:
-<p class="tw-text-12-px tw-text-text-muted tw-font-400">Click the 'Update Selected' option to initiate a connection between {{brandingConfig.brandName}} and QuickBooks Desktop</p> +<p class="tw-text-12-px tw-text-text-muted tw-font-400">{{brandingContent.connectionSetupText(brandingConfig.brandName)}}</p>src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (1)
Line range hint
72-73: Consider extracting repeated string concatenations into component properties.Multiple instances of string concatenation with
brandingConfig.brandNamecould be moved to component properties for better maintainability and reuse.Example refactor in the component class:
get importToMessage(): string { return `This is a one-time setup and cannot be modified once the values are imported to ${this.brandingConfig.brandName}.`; }Then in the template:
-[infoText]="'This is a one-time setup and cannot be modified once the values are imported to ' + brandingConfig.brandName + '.'" +[infoText]="importToMessage"Also applies to: 187-188
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (47)
src/app/branding/c1-contents-config.ts(17 hunks)src/app/branding/fyle-contents-config.ts(9 hunks)src/app/core/models/branding/content-configuration.model.ts(2 hunks)src/app/core/models/xero/xero-configuration/xero-advanced-settings.model.ts(2 hunks)src/app/core/models/xero/xero-configuration/xero-export-settings.model.ts(2 hunks)src/app/integrations/intacct/intacct-main/intacct-dashboard/intacct-dashboard.component.html(1 hunks)src/app/integrations/intacct/intacct-main/intacct-dashboard/intacct-dashboard.component.ts(2 hunks)src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.html(1 hunks)src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.ts(2 hunks)src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.html(1 hunks)src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.ts(2 hunks)src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html(1 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-dashboard/netsuite-dashboard.component.html(1 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-dashboard/netsuite-dashboard.component.ts(2 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-complete-export-logs/netsuite-complete-export-logs.component.html(1 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-complete-export-logs/netsuite-complete-export-logs.component.ts(2 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html(1 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.ts(2 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.ts(2 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-complete-export-log/qbd-direct-complete-export-log.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-complete-export-log/qbd-direct-complete-export-log.component.ts(2 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-skipped-export-log/qbd-direct-skipped-export-log.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-skipped-export-log/qbd-direct-skipped-export-log.component.ts(2 hunks)src/app/integrations/qbd-direct/qbd-direct-onboarding/qbd-direct-onboarding-landing/qbd-direct-onboarding-landing.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-onboarding/qbd-direct-onboarding-pre-requisite/qbd-direct-onboarding-pre-requisite.component.ts(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.ts(2 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-import-settings/qbd-direct-import-settings.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-setup-connection/qbd-direct-setup-connection.component.html(1 hunks)src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.html(1 hunks)src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.ts(2 hunks)src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-complete-export-log/qbo-complete-export-log.component.html(1 hunks)src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-complete-export-log/qbo-complete-export-log.component.ts(2 hunks)src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.html(1 hunks)src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.ts(2 hunks)src/app/integrations/sage300/sage300-shared/sage300-advanced-settings/sage300-advanced-settings.component.html(4 hunks)src/app/integrations/xero/xero-main/xero-dashboard/xero-dashboard.component.html(1 hunks)src/app/integrations/xero/xero-main/xero-dashboard/xero-dashboard.component.ts(2 hunks)src/app/integrations/xero/xero-main/xero-export-log/xero-complete-export-log/xero-complete-export-log.component.html(1 hunks)src/app/integrations/xero/xero-main/xero-export-log/xero-complete-export-log/xero-complete-export-log.component.ts(2 hunks)src/app/integrations/xero/xero-main/xero-export-log/xero-skipped-export-log/xero-skipped-export-log.component.html(1 hunks)src/app/integrations/xero/xero-main/xero-export-log/xero-skipped-export-log/xero-skipped-export-log.component.ts(2 hunks)src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html(1 hunks)src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html(1 hunks)src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.ts(2 hunks)src/app/shared/components/helper/mapping/mapping-filter/mapping-filter.component.ts(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html
- src/app/core/models/xero/xero-configuration/xero-advanced-settings.model.ts
🔇 Additional comments (38)
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.ts (1)
10-10: LGTM! The white labeling implementation looks good.The changes properly implement white labeling by:
- Adding the necessary branding content import
- Introducing a readonly property to access export log specific branding content
Also applies to: 69-69
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.ts (1)
12-12: LGTM! Clean implementation of branding configuration.The changes properly implement white labeling by introducing branding configuration and content. The readonly property ensures immutability and follows Angular best practices.
Also applies to: 71-71
src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-complete-export-log/qbd-direct-complete-export-log.component.ts (2)
5-5: LGTM!The import statement follows Angular's best practices.
61-61: Verify the usage of brandingContent in the template.The readonly property is correctly defined. However, let's verify that all text content in the corresponding template file has been updated to use this branding content.
✅ Verification successful
Template correctly implements branding content
The template file properly uses brandingContent for all text content, and the only 'fyle' reference found is correctly used in brand-specific styling logic.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the template file uses the brandingContent property # and ensure no hardcoded "Fyle" references remain # First, locate and check the template file template_file=$(fd -e html qbd-direct-complete-export-log.component.html) if [ -n "$template_file" ]; then echo "Checking template file for brandingContent usage:" rg "brandingContent\." "$template_file" echo -e "\nChecking for any remaining hardcoded 'Fyle' references:" rg -i "fyle" "$template_file" fiLength of output: 1490
src/app/integrations/xero/xero-main/xero-export-log/xero-skipped-export-log/xero-skipped-export-log.component.ts (2)
4-4: LGTM! Import statement aligns with white labeling objectives.The addition of branding-related imports is correct and follows Angular conventions.
47-47: LGTM! Property declaration follows best practices.The readonly property is correctly implemented to access export-log-specific branding content.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.ts (1)
3-3: Verify the usage of brandingConfig in the template.The
brandingConfigimport and property are added but their usage is not visible in the current file. Ensure that this property is being utilized in the component's template for white labeling purposes.Also applies to: 33-33
✅ Verification successful
brandingConfig import is correctly used in the template
The
brandingConfigis properly utilized in the component's template to display the brand name within an informational message about QuickBooks Desktop synchronization.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for brandingConfig usage in the component's template rg "brandingConfig\." "src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html"Length of output: 494
src/app/shared/components/helper/mapping/mapping-filter/mapping-filter.component.ts (1)
30-30: LGTM! Well-implemented white labeling changes.The changes effectively replace hardcoded labels with dynamic content from brandingContent, following best practices:
- Using readonly modifier for immutable content
- Centralizing branding content
- Consistent implementation across mapped/unmapped states
Also applies to: 33-37
src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.ts (1)
4-4: Verify the usage of brandingContent in the template.The
brandingContentproperty is added but its usage is not visible in the current file. Ensure that this property is being utilized in the component's template for white labeling purposes.Also applies to: 51-51
✅ Verification successful
brandingContent usage verified in template
The
brandingContentproperty is correctly utilized in the template for customizing zero state messages, including header and subheader text for different states.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for brandingContent usage in the component's template rg "brandingContent\." "src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html"Length of output: 463
src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.ts (1)
12-12: LGTM! Changes align with white labeling requirements.The addition of
brandingContentimport and property enables dynamic branding text in the component.Also applies to: 49-49
src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.ts (1)
4-4: LGTM! Changes align with white labeling requirements.The addition of
brandingContentimport and property enables dynamic branding text in the mapping component.Also applies to: 81-81
src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-complete-export-log/qbo-complete-export-log.component.ts (2)
13-13: LGTM! Changes align with white labeling requirements.The addition of
brandingContentimport and property enables dynamic branding text in the component.Also applies to: 57-57
Line range hint
84-86: Review method names for white labeling compliance.The method name
openExpenseinFyleand the usage ofgetFyleExpenseUrlmight need to be updated to align with white labeling requirements.Run this script to check for similar instances:
src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-complete-export-logs/netsuite-complete-export-logs.component.ts (1)
4-4: LGTM! Changes align with white labeling requirements.The addition of
brandingContentimport and the readonly property follows Angular best practices and supports the white labeling objective.Also applies to: 59-59
src/app/integrations/xero/xero-main/xero-export-log/xero-complete-export-log/xero-complete-export-log.component.ts (1)
4-4: LGTM! Consistent implementation across components.The changes maintain consistency with other export log components, following the same pattern for white labeling implementation.
Also applies to: 59-59
src/app/integrations/netsuite/netsuite-main/netsuite-dashboard/netsuite-dashboard.component.ts (1)
4-4: LGTM! Consistent dashboard branding implementation.The changes follow the established pattern for white labeling, appropriately using the dashboard-specific branding content.
Also applies to: 69-69
src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.ts (1)
3-3: LGTM! Consistent with other dashboard implementations.The changes maintain consistency with other dashboard components in the white labeling implementation.
Also applies to: 71-71
src/app/integrations/xero/xero-main/xero-dashboard/xero-dashboard.component.ts (1)
3-3: LGTM! White labeling changes look good.The changes correctly implement white labeling by:
- Importing the brandingContent from the central configuration
- Adding a readonly property to access dashboard-specific branding content
Also applies to: 84-85
src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.ts (1)
5-5: LGTM! White labeling changes are consistent.The changes follow the same pattern as other components:
- Importing brandingContent
- Adding a readonly property for dashboard-specific branding content
Also applies to: 78-79
src/app/integrations/intacct/intacct-main/intacct-dashboard/intacct-dashboard.component.ts (1)
3-3: LGTM! White labeling changes are properly implemented.The changes follow the established pattern across dashboard components:
- Importing brandingContent
- Adding a readonly property for dashboard-specific branding content
Also applies to: 112-113
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.html (2)
33-34: LGTM! Good refactoring to use centralized branding content.The changes effectively replace hardcoded/conditional text with dynamic content from
brandingContent, improving maintainability and supporting white labeling requirements.Also applies to: 39-40
33-34: Verify brandingContent property initialization.Please ensure that all required
brandingContentproperties are properly initialized to avoid potential runtime errors.Also applies to: 39-40
✅ Verification successful
The brandingContent property is properly initialized and type-safe.
The property is correctly imported from the branding configuration, initialized as a readonly property, and the required text properties are defined in the type system with default values provided.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for brandingContent property initialization ast-grep --pattern 'brandingContent = { $$$ completeExportLogZeroStateHeaderText: $_, completeExportLogZeroStateSubHeaderText: $_, completeExportLogCountZeroStateHeaderText: $_, completeExportLogCountZeroStateSubHeaderText: $_, $$$ }'Length of output: 248
Script:
#!/bin/bash # Find the component class file fd intacct-completed-export-log.component.ts # Search for any branding content interface or type rg -l "interface.*BrandingContent|type.*BrandingContent" # Look for service files that might initialize branding content fd -e ts -e js | rg -l "brandingContent.*Service|BrandingContent.*Service" # Search for any usage of these specific properties rg "completeExportLogZeroStateHeaderText|completeExportLogZeroStateSubHeaderText"Length of output: 3250
Script:
#!/bin/bash # Check the component implementation cat src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-completed-export-log/intacct-completed-export-log.component.ts # Look for any base components it might extend rg -l "export abstract class.*Export" src/app/core/Length of output: 6655
src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-complete-export-log/qbd-direct-complete-export-log.component.html (1)
33-34: Changes mirror those in Intacct component.The modifications are identical to those in the Intacct component, following the same pattern of replacing hardcoded text with dynamic branding content.
Also applies to: 39-40
src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-complete-export-logs/netsuite-complete-export-logs.component.html (1)
33-34: Changes mirror those in Intacct component.The modifications are identical to those in the Intacct component, following the same pattern of replacing hardcoded text with dynamic branding content.
Also applies to: 39-40
src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-complete-export-log/qbo-complete-export-log.component.html (1)
33-34: Changes mirror those in Intacct component.The modifications are identical to those in the Intacct component, following the same pattern of replacing hardcoded text with dynamic branding content.
Also applies to: 39-40
src/app/integrations/xero/xero-main/xero-export-log/xero-complete-export-log/xero-complete-export-log.component.html (1)
33-34: Changes mirror those in Intacct component.The modifications are identical to those in the Intacct component, following the same pattern of replacing hardcoded text with dynamic branding content.
Also applies to: 39-40
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html (1)
29-29: LGTM! Proper implementation of white labeling.The dynamic brand name integration is correctly implemented using
brandingConfig.brandName.src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (1)
Line range hint
1-270: Well-implemented white labeling changes!The implementation consistently uses dynamic branding throughout the template, properly handles different branding cases, and maintains good separation of concerns with feature flags.
src/app/integrations/qbo/qbo-main/qbo-export-log/qbo-skipped-export-log/qbo-skipped-export-log.component.html (1)
28-29: LGTM! Consistent white labeling implementationThe changes appropriately replace static text with dynamic branding content, aligning with the white labeling initiative.
Let's verify that these branding content properties exist:
Also applies to: 35-36
✅ Verification successful
Branding content properties verified successfully
The properties
skipExportLogZeroStateHeaderTextandskipExportLogZeroStateSubHeaderTextare properly defined in the content model and implemented in both Fyle and C1 configurations.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the branding content properties are defined rg -l "skipExportLogZeroStateHeaderText|skipExportLogZeroStateSubHeaderText|skipExportLogCountZeroStateHeaderText|skipExportLogCountZeroStateSubHeaderText" --type tsLength of output: 307
Script:
#!/bin/bash # Check model definition and implementations echo "=== Content Configuration Model ===" rg "skipExportLogZeroStateHeaderText|skipExportLogZeroStateSubHeaderText" src/app/core/models/branding/content-configuration.model.ts -A 1 echo -e "\n=== Fyle Implementation ===" rg "skipExportLogZeroStateHeaderText|skipExportLogZeroStateSubHeaderText" src/app/branding/fyle-contents-config.ts -A 1 echo -e "\n=== C1 Implementation ===" rg "skipExportLogZeroStateHeaderText|skipExportLogZeroStateSubHeaderText" src/app/branding/c1-contents-config.ts -A 1Length of output: 1309
src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-skipped-export-log/qbd-direct-skipped-export-log.component.html (1)
Line range hint
5-5: Duplicate feedback from QBO componentThe same feedback applies to this file:
- Update hardcoded brand reference in ngClass
- Text property changes look good
Also applies to: 28-29, 35-36
src/app/integrations/xero/xero-main/xero-export-log/xero-skipped-export-log/xero-skipped-export-log.component.html (1)
Line range hint
5-5: Duplicate feedback from QBO componentThe same feedback applies to this file:
- Update hardcoded brand reference in ngClass
- Text property changes look good
Also applies to: 28-29, 35-36
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.html (1)
Line range hint
5-5: Duplicate feedback from QBO componentThe same feedback applies to this file:
- Update hardcoded brand reference in ngClass
- Text property changes look good
Also applies to: 28-29, 35-36
src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html (1)
Line range hint
5-5: Duplicate feedback from QBO componentThe same feedback applies to this file:
- Update hardcoded brand reference in ngClass
- Text property changes look good
Also applies to: 28-29, 35-36
src/app/integrations/netsuite/netsuite-main/netsuite-dashboard/netsuite-dashboard.component.html (1)
25-26: Verify initialization of brandingContent properties.The changes look good and align with the white labeling objectives. However, we should verify the initialization of these properties to prevent potential runtime errors.
✅ Verification successful
Properties are properly initialized and safe to use
The brandingContent properties are properly initialized through the dashboard namespace, following a consistent pattern used throughout the codebase. The readonly initialization ensures immutability and prevents runtime assignment errors.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for brandingContent initialization in component files echo "Searching for brandingContent initialization in dashboard components..." rg -A 5 "brandingContent.*=.*" "src/app/integrations/**/dashboard/*.component.ts" # Search for type definition echo "Searching for type definition..." ast-grep --pattern 'interface ContentConfiguration { $$$ dashboardExportZeroStateHeaderText: $_ dashboardExportZeroStateSubHeaderText: $_ $$$ }'Length of output: 555
Script:
#!/bin/bash # Search for component initialization and property usage echo "Searching for brandingContent initialization and property usage..." rg -A 5 "brandingContent\s*[:=]" # Search for these specific properties in any interface or type echo "Searching for property definitions..." rg "dashboardExportZeroStateHeaderText|dashboardExportZeroStateSubHeaderText" # Search for any ContentConfiguration interface echo "Searching for ContentConfiguration interface..." ast-grep --pattern 'interface ContentConfiguration { $$$ }'Length of output: 68024
src/app/integrations/xero/xero-main/xero-dashboard/xero-dashboard.component.html (1)
25-26: Changes follow the established pattern.The implementation matches the white labeling pattern used across other integration dashboards.
src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.html (1)
25-26: Changes follow the established pattern.The implementation matches the white labeling pattern used across other integration dashboards.
src/app/integrations/intacct/intacct-main/intacct-dashboard/intacct-dashboard.component.html (1)
25-26: Changes follow the established pattern.The implementation matches the white labeling pattern used across other integration dashboards.
src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-dashboard/qbd-direct-dashboard.component.html (1)
25-26: Changes follow the established pattern.The implementation matches the white labeling pattern used across other integration dashboards.
| import { brandingContent } from 'src/app/branding/branding-config'; | ||
| import { brandingConfig } from 'src/app/branding/c1-contents-config'; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Maintain consistency in branding config imports.
The brandingConfig is imported from 'c1-contents-config' while other components import it from 'branding-config'. This inconsistency could lead to maintenance issues.
Apply this diff to maintain consistency:
-import { brandingContent } from 'src/app/branding/branding-config';
-import { brandingConfig } from 'src/app/branding/c1-contents-config';
+import { brandingConfig, brandingContent } from 'src/app/branding/branding-config';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { brandingContent } from 'src/app/branding/branding-config'; | |
| import { brandingConfig } from 'src/app/branding/c1-contents-config'; | |
| import { brandingConfig, brandingContent } from 'src/app/branding/branding-config'; |
| frequencySubLabel: 'Set how often your expenses will be exported to QuickBooks Online.', | ||
| otherPreferencesLabel: 'Other preferences', | ||
| otherPreferencesSubLabel: 'Create new records in QuickBooks Online if no vendor record is found or the accounting period is closed.', | ||
| accountingPeriodLabel: 'Post entries in the current open accounting period.', | ||
| accountingPeriodSubLabel: 'If the accounting period is closed, the expenses will be exported with a date stamp for the first day of the current open accounting period', | ||
| autoCreateMerchantsAsVendorsSubLabel: 'Automatically create a new vendor in QuickBooks Online if an added merchant doesn\'t have a corresponding match.', | ||
| customizeSectionSubLAbel: 'Customize the data that you\'d like to export from Expense Management to QuickBooks Online by choosing which data points need to be exported.', | ||
| customizeSectionSubLAbel: 'Customize the data that you\'d like to export from ' + brandingConfig.brandName + ' to QuickBooks Online by choosing which data points need to be exported.', |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix typos in property names and text content.
There are a few typos and inconsistencies in the property names and text content:
Apply this diff to fix the issues:
- customizeSectionSubLAbel
+ customizeSectionSubLabel
- mappingSerchZeroStateHeaderText
- mappingSerchZeroStateSubHeaderText
+ mappingSearchZeroStateHeaderText
+ mappingSearchZeroStateSubHeaderText
- mappingToastText: 'Mapping saved successfully',
+ mappingToastText: 'Mapping saved successfully.',
- mappedHeader: 'MAPPED',
- unMappedHeader: 'UNMAPPED'
+ mappedHeader: 'Mapped',
+ unMappedHeader: 'Unmapped'Also applies to: 460-461, 466-470
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/core/models/branding/content-configuration.model.ts (1)
446-453: Consider simplifying property names for better maintainability.While the export log zero-state properties are comprehensive, the naming could be more concise by removing redundant "Text" suffixes.
Consider this naming pattern:
- completeExportLogZeroStateHeaderText: string; - completeExportLogZeroStateSubHeaderText: string; - completeExportLogCountZeroStateHeaderText: string; - completeExportLogCountZeroStateSubHeaderText: string; - skipExportLogZeroStateHeaderText: string; - skipExportLogZeroStateSubHeaderText: string; - skipExportLogCountZeroStateHeaderText: string; - skipExportLogCountZeroStateSubHeaderText: string; + completeExportLogZeroStateHeader: string; + completeExportLogZeroStateSubHeader: string; + completeExportLogCountZeroStateHeader: string; + completeExportLogCountZeroStateSubHeader: string; + skipExportLogZeroStateHeader: string; + skipExportLogZeroStateSubHeader: string; + skipExportLogCountZeroStateHeader: string; + skipExportLogCountZeroStateSubHeader: string;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/app/branding/c1-contents-config.ts(17 hunks)src/app/branding/fyle-contents-config.ts(9 hunks)src/app/core/models/branding/content-configuration.model.ts(3 hunks)src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-skipped-export-log/qbd-direct-skipped-export-log.component.ts(2 hunks)src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.html(1 hunks)src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.html
🚧 Files skipped from review as they are similar to previous changes (4)
- src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html
- src/app/integrations/qbd-direct/qbd-direct-main/qbd-direct-export-log/qbd-direct-skipped-export-log/qbd-direct-skipped-export-log.component.ts
- src/app/branding/c1-contents-config.ts
- src/app/branding/fyle-contents-config.ts
🔇 Additional comments (3)
src/app/core/models/branding/content-configuration.model.ts (3)
432-433: LGTM! Dashboard zero-state text properties added.The new dashboard zero-state text properties follow consistent naming patterns and support the white labeling objective.
460-463: LGTM! Mapping text properties added.The new mapping properties are well-named and provide necessary text customization for search zero-states and mapping headers.
Line range hint
432-463: Verify usage of new branding properties across components.Let's ensure all new branding properties are properly utilized in their respective components.
✅ Verification successful
All branding properties are properly utilized across components ✅
The verification confirms that:
- Dashboard zero-state texts are implemented across all integration dashboards
- Export log properties are used in both complete and skipped export log components
- Mapping-related properties are correctly utilized in shared mapping components
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new branding properties in components # Search for usage of new dashboard properties echo "Checking dashboard zero-state property usage:" rg -l "dashboardExportZeroStateHeaderText|dashboardExportZeroStateSubHeaderText" # Search for usage of new export log properties echo -e "\nChecking export log zero-state property usage:" rg -l "completeExportLogZeroStateHeaderText|skipExportLogZeroStateHeaderText" # Search for usage of new mapping properties echo -e "\nChecking mapping property usage:" rg -l "mappingSearchZeroStateHeaderText|mappedHeader|unMappedHeader"Length of output: 2853
* package-lock.json commit * @angular-eslint/schematics update commit * angular version update * feat: white lableing - converting all fyle reference to generic form (#1154) * white lableing - converting all fyle reference to generic form * content fix * intacct css fix
Description
feat: white lableing - converting all fyle reference to generic form
Clickup
https://app.clickup.com/
Summary by CodeRabbit
Release Notes
Branding Enhancements
Configuration Updates
ContentConfigurationmodel with new zero-state and header text properties.User Experience Improvements
Technical Refinements