feat: fixes for support of skip expense post import

[anishfyle]

Description

• add fixes for skip expenses post import

Clickup

• app.clickup.com/t/skip-expense-post-import

Summary by CodeRabbit

• New Features

  • Enhanced dashboard error section with more precise visibility conditions
  • Added new input properties for handling exportable expense groups and accounting export summary
  • Improved error section display logic for QuickBooks Online (QBO) integration

• Bug Fixes

  • Refined error section visibility to prevent unnecessary error displays

[coderabbitai]

Walkthrough

The pull request modifies the dashboard error section component across multiple files to introduce a new visibility condition. The changes involve adding two new input properties (exportableExpenseGroupIds and accountingExportSummary) to the DashboardErrorSectionComponent and implementing a new getter method shouldShowErrorSection. This method determines the error section's visibility based on specific conditions related to the QuickBooks Online (QBO) application.

Changes

File	Change Summary
src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts	- Added input property exportableExpenseGroupIds: number[] - Added input property accountingExportSummary: any - Implemented shouldShowErrorSection getter method
src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html	- Updated visibility condition to include shouldShowErrorSection
src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.html	- Added exportableExpenseGroupIds input - Updated accountingExportSummary input

Sequence Diagram

sequenceDiagram
    participant QBODashboard as QBO Dashboard
    participant ErrorSection as Dashboard Error Section
    
    QBODashboard->>ErrorSection: Pass exportableExpenseGroupIds
    QBODashboard->>ErrorSection: Pass accountingExportSummary
    ErrorSection->>ErrorSection: Evaluate shouldShowErrorSection
    alt Conditions Met
        ErrorSection-->>QBODashboard: Display Error Section
    else Conditions Not Met
        ErrorSection-->>QBODashboard: Hide Error Section
    end

Loading

Possibly related PRs

• fix: Add an "Export Date" option to QBO CCP date options #1148: Directly related to adding input properties for the dashboard error section
• feat: hide qbd iif from landing, disable export cta #1153: Involves conditional rendering of integration options

Suggested labels

qa_deploy

Suggested reviewers

• ashwin1111
• Hrishabh17
• DhaaraniCIT

Poem

🐰 A rabbit's tale of errors bright,
Conditions checked with all my might,
QBO's secrets now unfurled,
With inputs dancing, logic swirled!
Error section, hide or show?
The rabbit knows, and now you know! 🔍

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eba1200 and 5cae704.

📒 Files selected for processing (1)

• src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts (1)

Line range hint 27-59: Consider breaking down this component for better maintainability.

The component has grown to handle multiple types of errors and contains numerous input properties. Consider splitting it into smaller, more focused components:

• MappingErrorSection
• AccountingErrorSection
• ErrorDialogComponent

This would:

• Improve code organization and maintainability
• Make testing easier
• Follow the Single Responsibility Principle

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d05001 and a90e848.

📒 Files selected for processing (2)

• src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (1 hunks)
• src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts (2 hunks)

🔇 Additional comments (2)

src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts (1)

120-122: LGTM! Clean implementation of the visibility control.

The getter effectively uses optional chaining and nullish coalescing operators to safely check conditions.

src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (1)

2-2: LGTM! Proper integration of the new visibility condition.

The error section visibility is now correctly controlled by both the presence of errors and the new shouldShowErrorSection condition, aligning with the skip expense support feature.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.html (1)

46-48: Use shouldShowErrorSection for component visibility.

The current visibility condition checks for errors in various mappings, but the component now has a shouldShowErrorSection getter that encapsulates the visibility logic. Consider using it as the single source of truth:

-<app-dashboard-error-section *ngIf="errors.EMPLOYEE_MAPPING.length || errors.CATEGORY_MAPPING.length || errors.ACCOUNTING_ERROR.length"
+<app-dashboard-error-section *ngIf="errors && shouldShowErrorSection"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a90e848 and de1e54a.

📒 Files selected for processing (3)

• src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.html (1 hunks)
• src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.ts (1 hunks)
• src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.ts (2 hunks)

🔇 Additional comments (1)

src/app/integrations/qbo/qbo-main/qbo-dashboard/qbo-dashboard.component.ts (1)

75-75: Define a proper type for lastExportDetails.

Using any type bypasses TypeScript's type checking. Since this property is assigned accountingExportSummary, it should be typed as AccountingExportSummary.

-  lastExportDetails: any;
+  lastExportDetails: AccountingExportSummary;

[github-actions]

Unit Test Coverage	%	values
Statements	33.02%	( 4133 / 12515 )
Branches	26.35%	( 1173 / 4451 )
Functions	25.61%	( 894 / 3490 )
Lines	33.21%	( 4067 / 12246 )