fix: /landing_v2 - P2 changes

[JustARatherRidiculouslyLongUsername]

• fix: reorder tiles to alphabetical order

• fix: logo size + font size fixes (fix: logo size + font size fixes #1171)

• fix: logo size + font size fixes

• fix: beta badge positioning (fix: beta badge positioning #1172)

Description

Covers P2 items #1 and #2:
https://www.notion.so/Engineering-Internal-Item-Problem-Definition-Solution-Outline-15e2ed8bfcb381469a2cd2ee1321ca6e?pvs=4#1852ed8bfcb3801582f6efffb8994816

Clickup

https://app.clickup.com/t/86cxtgha2

Summary by CodeRabbit

• New Features
  • Added a new integration for Dynamics 365 Business Central with an intuitive integration button.
  • Updated integrations for QuickBooks and Sage products:
    • QuickBooks now features distinct options for Online and Desktop (IIF) versions.
    • Sage 300 is displayed as Sage 300 CRE and Sage Intacct now shows the correct name.
  • Replaced legacy options for Intacct, Xero, and QBO with improved connection logic.

[coderabbitai]

Walkthrough

This update enhances the application's integration options. A new section for "Dynamics 365 Business Central" has been added with a conditional UI and integration button. The integration for "QuickBooks" now distinguishes between "Online" and "Desktop (IIF)" versions, updating the connection logic accordingly. Additionally, the display and connection checks for "Sage 300" (shown as "Sage 300 CRE") and "Sage Intacct" have been modified, while older integrations like Intacct, Xero, and QBO have been removed or replaced.

Changes

File(s)

Change Summary

src/app/integrations/landing-v2/landing-v2.component.html

- Added a new section for Dynamics 365 Business Central with a conditional display and integration button. - Updated QuickBooks integration: renamed to "QuickBooks Online" and rebranded "QuickBooks Desktop (Web Connector)" as "QuickBooks Desktop (IIF)". - Modified connection checks for Sage 300 (as "Sage 300 CRE") and Sage Intacct. - Removed or replaced outdated integrations for Intacct, Xero, and QBO.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant L as Landing Component
    participant S as Integration Service

    U->>L: Clicks integration button (e.g., Business Central)
    L->>S: Calls openInAppIntegration(BUSINESS_CENTRAL) or other integration methods
    S-->>L: Returns connection status
    L-->>U: Displays integration connection result

Loading

Possibly related PRs

• fix: reorder tiles to alphabetical order #1170: Involves similar modifications with the addition of Dynamics 365 Business Central integration and updates to the integration display logic.

Suggested labels

size/M

Suggested reviewers

• ashwin1111

Poem

I'm a little rabbit, hopping all around,
Coding new integrations that make a joyful sound.
Business Central now joins our vibrant crew,
With QuickBooks and Sage update shining through!
Carrots and code—our leaps of tech abound!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35a3acd and 0622956.

📒 Files selected for processing (1)

• src/app/integrations/landing-v2/landing-v2.component.html (2 hunks)

🔇 Additional comments (7)

src/app/integrations/landing-v2/landing-v2.component.html (7)

41-59: New Dynamics 365 Business Central Integration Block
The newly added block for Business Central correctly uses conditional rendering via *ngIf="isAppShown('BUSINESS_CENTRAL')", and it defines the click handler with openInAppIntegration(InAppIntegration.BUSINESS_CENTRAL). The block also displays the beta badge based on the organization’s ID.
Please verify that the custom inline conditional syntax (@if (isAppConnected(...)) { ... } @else { ... }) is supported in your Angular template context or if a standard Angular mechanism (such as using <ng-container *ngIf="...">) is preferred by the team.

---

81-90: QuickBooks Desktop (IIF) Integration Update
This integration card for QuickBooks Desktop (IIF) properly sets the conditional display using *ngIf="isAppShown('QBD')" with the updated click handler openInAppIntegration(InAppIntegration.QBD). The connectivity status is checked via isAppConnected('QBD'), and the label "QuickBooks Desktop (IIF)" is clearly rendered.
Ensure that the visual consistency (logo size and text style) aligns with the latest design requirements.

---

100-117: QuickBooks Desktop (Web Connector) Integration Block
This block introduces the integration for QuickBooks Desktop (Web Connector) with a separate click handler (openInAppIntegration(InAppIntegration.QBD_DIRECT)) and updated text. The UI structure and styling (using classes like tw-gap-4 and tw-items-start) are consistent with other integration cards.
Confirm that the displayed label “QuickBooks Desktop (Web Connector)” and its associated visuals meet the design expectations.

---

118-136: QuickBooks Online Integration Block
The integration for QuickBooks Online now uses the handler openAccountingIntegrationApp(AccountingIntegrationApp.QBO) and correctly updates the display text to "QuickBooks Online". The wrapping structure and conditional connectivity check with isAppConnected('QBO') maintain consistency with other entries.
Double-check that the logo and text sizing (e.g., the class !tw-h-[30.7px] on the image) adhere to the updated style guidelines.

---

137-155: Sage 300 CRE Integration Update
The Sage 300 integration card is now relabeled as “Sage 300 CRE” and includes an updated beta badge that is conditionally hidden via !orgsToHideSage300BetaBadge.includes(org.fyle_org_id). The click action and connectivity logic remain consistent with other accounting integrations.
Please verify that the renaming meets the business requirements and that the beta badge condition correctly reflects the organizations meant to see it.

---

156-174: Sage Intacct Integration Update
The Sage Intacct integration now invokes openAccountingIntegrationApp(AccountingIntegrationApp.SAGE_INTACCT) and displays the appropriate logo and labels. The conditional check using isAppConnected('INTACCT') is properly applied.
Ensure that the asset path (assets/logos/intacct-logo-new.png) and styling are up to date with the revised branding requirements.

---

175-193: Xero Integration Block
The integration card for Xero is updated with its own click handler (openAccountingIntegrationApp(AccountingIntegrationApp.XERO)) and conditional connection status via isAppConnected('XERO'). The logo and text appear to follow the established pattern for integration cards.
Confirm that the Xero logo and its styling, along with the connectivity check, meet the intended design and functionality updates.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Unit Test Coverage	%	values
Statements	33.02%	( 4132 / 12512 )
Branches	26.46%	( 1177 / 4448 )
Functions	25.59%	( 893 / 3489 )
Lines	33.21%	( 4066 / 12243 )