-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: branding based content changes fix #1178
base: master
Are you sure you want to change the base?
Conversation
WalkthroughMultiple cosmetic updates have been applied across various integration and shared component HTML templates. The changes standardize displayed text by replacing dynamic, condition-based case transformations with static ones. In several files, instances of the Changes
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html (1)
23-24
: Standardized Zero State Text Formatting
Theapp-zero-state-with-illustration
component now appends formatted text usingsnakeCaseToSpaceCase
followed bylowercase
for thesourceField
. This ensures that the displayed text for the zero state aligns with the uniform branding style. Consider verifying that the concatenated string provides the desired spacing and punctuation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
src/app/integrations/intacct/intacct-shared/intacct-c1-import-settings/intacct-c1-import-settings.component.html
(1 hunks)src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html
(1 hunks)src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html
(2 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html
(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html
(3 hunks)src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html
(6 hunks)src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html
(6 hunks)src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html
(3 hunks)src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html
(2 hunks)src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html
(5 hunks)src/app/shared/components/configuration/configuration-mapping-fields/configuration-mapping-fields.component.html
(1 hunks)src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html
(3 hunks)src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.html
(4 hunks)src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html
(2 hunks)src/app/shared/components/export-log/export-log-table/export-log-table.component.html
(1 hunks)src/app/shared/components/helper/mapping/generic-mapping-table/generic-mapping-table.component.html
(1 hunks)src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html
(1 hunks)src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.html
(1 hunks)src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html
(2 hunks)src/app/shared/components/si/helper/dashboard-mapping-resolve/dashboard-mapping-resolve.component.html
(1 hunks)src/app/shared/components/si/helper/skip-export/skip-export.component.html
(2 hunks)
✅ Files skipped from review due to trivial changes (4)
- src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html
- src/app/shared/components/si/helper/skip-export/skip-export.component.html
- src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html
- src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.html
🔇 Additional comments (26)
src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.html (1)
5-5
: Standardized Header Text Transformation
The pipe for formatting the header has been updated fromtitlecase
tosentenceCase
(via a precedingsnakeCaseToSpaceCase
conversion). This change aligns with the branding guidelines for a more uniform appearance.src/app/shared/components/si/helper/dashboard-mapping-resolve/dashboard-mapping-resolve.component.html (1)
7-7
: Updated Category Destination Formatting
The transformation of the output fromgetCategoryDestinationType()
now uses thesentenceCase
pipe rather thantitlecase
. This standardizes the header text per the new branding requirements. Note that the employee header still usestitlecase
—ensure this difference is intentional.src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html (1)
17-17
: Consistent Attribute Type Display
The change convertsfield.attribute_type
usingsnakeCaseToSpaceCase
followed bysentenceCase
rather thantitlecase
. This update maintains consistency in how the attribute types are presented in the UI.src/app/integrations/intacct/intacct-shared/intacct-c1-import-settings/intacct-c1-import-settings.component.html (1)
7-7
: Simplified Header Content
The dynamic, brand-dependent logic for settingcontentText
has been removed in favor of a static string:
'Choose the required import fields from Sage Intacct to Expense Management.'
This simplification helps in standardizing the header content across brands. Please confirm that this universal text meets all design and branding requirements.src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html (2)
17-17
: Enforce Consistent Branding Formatting
The display ofbrandingConfig.brandName
now directly uses thesentenceCase
pipe. This change removes any conditional formatting and enforces a uniform presentation in line with the updated branding guidelines.
31-31
: Standardize App Name Display
TheappName
is now rendered without any transformation. This simplifies the logic and aligns with the decision to remove brand-specific case adjustments. Please verify that this meets the intended user experience across all brands.src/app/shared/components/export-log/export-log-table/export-log-table.component.html (1)
40-40
: Simplify Exported Field Label Transformation
TheexportedAs
field now uses a combination ofsnakeCaseToSpaceCase
andsentenceCase
filters to consistently format the label. This change removes the previous conditional logic and standardizes the look across the application.src/app/shared/components/helper/mapping/generic-mapping-table/generic-mapping-table.component.html (1)
4-5
: Streamline Header Text Formatting
Headers for the mapping table now directly applysnakeCaseToSpaceCase
followed bysentenceCase
on bothsourceField
anddestinationField
. This simplifies the transformation steps by removing the extra conversion function and ensures consistency with other components.src/app/shared/components/configuration/configuration-mapping-fields/configuration-mapping-fields.component.html (1)
15-15
: Update Dropdown Selected Item Formatting
The selected item display in the dropdown now uses thesentenceCase
pipe instead oftitlecase
. This update supports a consistent text formatting standard across the application.src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (2)
78-78
: Standardize Error Title Formatting
The error title (error.error_title
) is now transformed usingsnakeCaseToSpaceCase
followed bysentenceCase
, which improves overall readability and consistency of error messages. Please confirm that this transformation aligns with how error titles should be displayed in the product.
135-135
: Conditional Transformation for Error Types
The dialog header now conditionally transformserrorType
—applyingsentenceCase
whenbrandingConfig.brandId
is'co'
andlowercase
otherwise. This nuanced logic should be verified to ensure it meets the specific branding requirements and delivers the expected visual identity to users.src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html (2)
92-99
: Consistent Date Label for Reimbursable Export
The label for the reimbursable export date field has been updated to transform the export type value using thesnakeCaseToSpaceCase | lowercase
pipes. This change aligns the text formatting with the branding guidelines by standardizing the appearance.
187-190
: Uniform Placeholder for Credit Card Export Date
The placeholder for the credit card export date field now applies thesnakeCaseToSpaceCase | lowercase
pipes. This ensures that both the label and placeholder are consistent in style with the new branding requirements.src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html (2)
111-116
: Standardized Selected Item Display
The selected item template now applies thesnakeCaseToSpaceCase | sentenceCase
transformation, ensuring that displayed values are consistently formatted. This small but effective change improves readability and maintains branding consistency across dropdowns.
141-143
: Uniform Formatting for Option Items
Updating the memo options within the dropdown to usesnakeCaseToSpaceCase | sentenceCase
makes the presentation uniform and aligns with the new styling guidelines.src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html (2)
68-70
: Consistent Label & SubLabel for Accounts Payable (Reimbursable)
The default reimbursable accounts payable label and sub-label now append the export type value usingsnakeCaseToSpaceCase | lowercase
. This update removes brand-specific conditional logic in favor of a straightforward, uniform presentation.
208-210
: Uniform Labeling for Default CCC Accounts Payable
Similarly, the credit card (CCC) accounts payable label and sub-label have been updated to consistently use the lowercase transformation. This change promotes a cohesive look across financial configuration fields.src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (2)
16-17
: Consistent Import Field Display (Destination Field)
The input field displaying the destination field now uses thesnakeCaseToSpaceCase | sentenceCase
pipes for its value. This provides a cleaner, uniform text presentation that matches the overall branding style.
22-23
: Uniform Display for Source Field in Import Section
Similarly, the source field input has been updated to include the same text transformation, ensuring that both destination and source fields adhere to the new formatting standards.src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html (2)
135-145
: Standardized Reimbursable Export Date Label and Placeholder
The label for setting the reimbursable expense date now applies thesnakeCaseToSpaceCase | lowercase
transformation. Likewise, the placeholder has been updated accordingly. This change ensures that textual elements for export dates are consistently styled without unintended case variations.
307-315
: Uniform Formatting for Credit Card Export Date Field
The credit card export date field has been similarly updated, with both its label and placeholder now using thesnakeCaseToSpaceCase | lowercase
pipes. This contributes to a standardized look across all integration export settings.src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html (4)
49-49
: Consistent Label Formatting for Bank Account Export Option
The dynamic content for the bank account field is now transformed usingsnakeCaseToSpaceCase | lowercase
, ensuring that the label consistently adheres to the branding’s lowercase style.
69-69
: Uniform Label Update for Expense Account Export Option
The expense account label now employs the lowercase transformation on the dynamic value, which aligns with the new branding guidelines.
95-96
: Standardized Accounts Payable Field Labels
Both the label and sub-label for the accounts payable export option have been updated with thesnakeCaseToSpaceCase | lowercase
transformation. This change ensures that the text presentation is consistent with the branding updates across the form.
168-171
: Uniform Date Field Label and Placeholder Update
The export date field’s label and placeholder now use the lowercase transformation for the dynamic portion (viasnakeCaseToSpaceCase | lowercase
), which provides a consistent look and feel with the rest of the configuration.src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html (1)
37-37
: Updated Text Transformation to SentenceCase for Intacct Category
The value forintacctCategoryDestination
now uses a combination ofsnakeCaseToSpaceCase | sentenceCase
instead of the previous transformation. This not only aligns with the branding update to use sentence-style casing but also explicitly corrects the formatting for instances like replacing "Gl " with "GL ".
Description
feat: branding based content changes fix
Clickup
https://app.clickup.com/t/
Summary by CodeRabbit