Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: branding based content changes fix #1178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DhaaraniCIT
Copy link
Contributor

@DhaaraniCIT DhaaraniCIT commented Feb 6, 2025

Description

feat: branding based content changes fix

Clickup

https://app.clickup.com/t/

Summary by CodeRabbit

  • Style
    • Improved text formatting across various user-facing interfaces. Labels, dropdowns, error messages, and configuration fields now use consistent sentence and lowercase styling to enhance readability and provide a uniform display.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Walkthrough

Multiple cosmetic updates have been applied across various integration and shared component HTML templates. The changes standardize displayed text by replacing dynamic, condition-based case transformations with static ones. In several files, instances of the titlecase pipe were replaced by either sentenceCase or lowercase to ensure a uniform appearance of labels, placeholders, and error messages. No functional logic was altered.

Changes

File(s) Change Summary
src/app/integrations/intacct/.../intacct-c1-import-settings.component.html,
src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html
Removed conditional logic for header text formatting; now use static strings (eliminating brand-specific conditions).
src/app/integrations/intacct/.../intacct-import-settings.component.html,
src/app/integrations/qbd-direct/.../qbd-direct-data-sync.component.html,
src/app/shared/components/configuration/(configuration-import-field, configuration-mapping-fields, configuration-select-field, configuration-skip-export).component.html,
src/app/shared/components/export-log/export-log-table.component.html,
src/app/shared/components/helper/mapping/generic-mapping-table.component.html,
src/app/shared/components/qbd/mapping/qbd-mapping-table.component.html,
src/app/shared/components/si/(dashboard-mapping-resolve, skip-export).component.html,
src/app/shared/components/dashboard/dashboard-error-section.component.html
Replaced titlecase with sentenceCase in labels, dropdowns, and table headers to standardize display formatting.
src/app/integrations/(netsuite, qbd-direct, qbo, xero)/...-(export-settings or clone-settings).component.html,
src/app/shared/components/configuration/configuration-mapping-v2/generic-mapping-v2.component.html
Changed text filters from titlecase to lowercase for various labels and placeholders, ensuring a uniform and simplified visual presentation.

Suggested labels

size/M

Suggested reviewers

  • ashwin1111

Poem

Oh, how my whiskers twitch with glee,
As code hops to a new consistency spree.
Gone are the twists from conditional arrays,
Now static and simple, in so many ways!
I nuzzle through changes with a joyful beat—
A rabbit’s smile in every line so neat!
🐇✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/M Medium PR label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Unit Test Coverage % values
Statements 33% ( 4130 / 12515 )
Branches 26.43% ( 1176 / 4449 )
Functions 25.56% ( 892 / 3489 )
Lines 33.18% ( 4064 / 12246 )

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html (1)

23-24: Standardized Zero State Text Formatting
The app-zero-state-with-illustration component now appends formatted text using snakeCaseToSpaceCase followed by lowercase for the sourceField. This ensures that the displayed text for the zero state aligns with the uniform branding style. Consider verifying that the concatenated string provides the desired spacing and punctuation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f47a2dc and 57bdb39.

📒 Files selected for processing (21)
  • src/app/integrations/intacct/intacct-shared/intacct-c1-import-settings/intacct-c1-import-settings.component.html (1 hunks)
  • src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html (1 hunks)
  • src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html (2 hunks)
  • src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html (1 hunks)
  • src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html (3 hunks)
  • src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html (6 hunks)
  • src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html (6 hunks)
  • src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html (3 hunks)
  • src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html (2 hunks)
  • src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (5 hunks)
  • src/app/shared/components/configuration/configuration-mapping-fields/configuration-mapping-fields.component.html (1 hunks)
  • src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html (3 hunks)
  • src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.html (4 hunks)
  • src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (2 hunks)
  • src/app/shared/components/export-log/export-log-table/export-log-table.component.html (1 hunks)
  • src/app/shared/components/helper/mapping/generic-mapping-table/generic-mapping-table.component.html (1 hunks)
  • src/app/shared/components/helper/mapping/generic-mapping-v2/generic-mapping-v2.component.html (1 hunks)
  • src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.html (1 hunks)
  • src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html (2 hunks)
  • src/app/shared/components/si/helper/dashboard-mapping-resolve/dashboard-mapping-resolve.component.html (1 hunks)
  • src/app/shared/components/si/helper/skip-export/skip-export.component.html (2 hunks)
✅ Files skipped from review due to trivial changes (4)
  • src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html
  • src/app/shared/components/si/helper/skip-export/skip-export.component.html
  • src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html
  • src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.html
🔇 Additional comments (26)
src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.html (1)

5-5: Standardized Header Text Transformation
The pipe for formatting the header has been updated from titlecase to sentenceCase (via a preceding snakeCaseToSpaceCase conversion). This change aligns with the branding guidelines for a more uniform appearance.

src/app/shared/components/si/helper/dashboard-mapping-resolve/dashboard-mapping-resolve.component.html (1)

7-7: Updated Category Destination Formatting
The transformation of the output from getCategoryDestinationType() now uses the sentenceCase pipe rather than titlecase. This standardizes the header text per the new branding requirements. Note that the employee header still uses titlecase—ensure this difference is intentional.

src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-data-sync/qbd-direct-data-sync.component.html (1)

17-17: Consistent Attribute Type Display
The change converts field.attribute_type using snakeCaseToSpaceCase followed by sentenceCase rather than titlecase. This update maintains consistency in how the attribute types are presented in the UI.

src/app/integrations/intacct/intacct-shared/intacct-c1-import-settings/intacct-c1-import-settings.component.html (1)

7-7: Simplified Header Content
The dynamic, brand-dependent logic for setting contentText has been removed in favor of a static string:
'Choose the required import fields from Sage Intacct to Expense Management.'
This simplification helps in standardizing the header content across brands. Please confirm that this universal text meets all design and branding requirements.

src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html (2)

17-17: Enforce Consistent Branding Formatting
The display of brandingConfig.brandName now directly uses the sentenceCase pipe. This change removes any conditional formatting and enforces a uniform presentation in line with the updated branding guidelines.


31-31: Standardize App Name Display
The appName is now rendered without any transformation. This simplifies the logic and aligns with the decision to remove brand-specific case adjustments. Please verify that this meets the intended user experience across all brands.

src/app/shared/components/export-log/export-log-table/export-log-table.component.html (1)

40-40: Simplify Exported Field Label Transformation
The exportedAs field now uses a combination of snakeCaseToSpaceCase and sentenceCase filters to consistently format the label. This change removes the previous conditional logic and standardizes the look across the application.

src/app/shared/components/helper/mapping/generic-mapping-table/generic-mapping-table.component.html (1)

4-5: Streamline Header Text Formatting
Headers for the mapping table now directly apply snakeCaseToSpaceCase followed by sentenceCase on both sourceField and destinationField. This simplifies the transformation steps by removing the extra conversion function and ensures consistency with other components.

src/app/shared/components/configuration/configuration-mapping-fields/configuration-mapping-fields.component.html (1)

15-15: Update Dropdown Selected Item Formatting
The selected item display in the dropdown now uses the sentenceCase pipe instead of titlecase. This update supports a consistent text formatting standard across the application.

src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (2)

78-78: Standardize Error Title Formatting
The error title (error.error_title) is now transformed using snakeCaseToSpaceCase followed by sentenceCase, which improves overall readability and consistency of error messages. Please confirm that this transformation aligns with how error titles should be displayed in the product.


135-135: Conditional Transformation for Error Types
The dialog header now conditionally transforms errorType—applying sentenceCase when brandingConfig.brandId is 'co' and lowercase otherwise. This nuanced logic should be verified to ensure it meets the specific branding requirements and delivers the expected visual identity to users.

src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html (2)

92-99: Consistent Date Label for Reimbursable Export
The label for the reimbursable export date field has been updated to transform the export type value using the snakeCaseToSpaceCase | lowercase pipes. This change aligns the text formatting with the branding guidelines by standardizing the appearance.


187-190: Uniform Placeholder for Credit Card Export Date
The placeholder for the credit card export date field now applies the snakeCaseToSpaceCase | lowercase pipes. This ensures that both the label and placeholder are consistent in style with the new branding requirements.

src/app/shared/components/configuration/configuration-select-field/configuration-select-field.component.html (2)

111-116: Standardized Selected Item Display
The selected item template now applies the snakeCaseToSpaceCase | sentenceCase transformation, ensuring that displayed values are consistently formatted. This small but effective change improves readability and maintains branding consistency across dropdowns.


141-143: Uniform Formatting for Option Items
Updating the memo options within the dropdown to use snakeCaseToSpaceCase | sentenceCase makes the presentation uniform and aligns with the new styling guidelines.

src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html (2)

68-70: Consistent Label & SubLabel for Accounts Payable (Reimbursable)
The default reimbursable accounts payable label and sub-label now append the export type value using snakeCaseToSpaceCase | lowercase. This update removes brand-specific conditional logic in favor of a straightforward, uniform presentation.


208-210: Uniform Labeling for Default CCC Accounts Payable
Similarly, the credit card (CCC) accounts payable label and sub-label have been updated to consistently use the lowercase transformation. This change promotes a cohesive look across financial configuration fields.

src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (2)

16-17: Consistent Import Field Display (Destination Field)
The input field displaying the destination field now uses the snakeCaseToSpaceCase | sentenceCase pipes for its value. This provides a cleaner, uniform text presentation that matches the overall branding style.


22-23: Uniform Display for Source Field in Import Section
Similarly, the source field input has been updated to include the same text transformation, ensuring that both destination and source fields adhere to the new formatting standards.

src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html (2)

135-145: Standardized Reimbursable Export Date Label and Placeholder
The label for setting the reimbursable expense date now applies the snakeCaseToSpaceCase | lowercase transformation. Likewise, the placeholder has been updated accordingly. This change ensures that textual elements for export dates are consistently styled without unintended case variations.


307-315: Uniform Formatting for Credit Card Export Date Field
The credit card export date field has been similarly updated, with both its label and placeholder now using the snakeCaseToSpaceCase | lowercase pipes. This contributes to a standardized look across all integration export settings.

src/app/integrations/qbo/qbo-shared/qbo-export-settings/qbo-export-settings.component.html (4)

49-49: Consistent Label Formatting for Bank Account Export Option
The dynamic content for the bank account field is now transformed using snakeCaseToSpaceCase | lowercase, ensuring that the label consistently adheres to the branding’s lowercase style.


69-69: Uniform Label Update for Expense Account Export Option
The expense account label now employs the lowercase transformation on the dynamic value, which aligns with the new branding guidelines.


95-96: Standardized Accounts Payable Field Labels
Both the label and sub-label for the accounts payable export option have been updated with the snakeCaseToSpaceCase | lowercase transformation. This change ensures that the text presentation is consistent with the branding updates across the form.


168-171: Uniform Date Field Label and Placeholder Update
The export date field’s label and placeholder now use the lowercase transformation for the dynamic portion (via snakeCaseToSpaceCase | lowercase), which provides a consistent look and feel with the rest of the configuration.

src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html (1)

37-37: Updated Text Transformation to SentenceCase for Intacct Category
The value for intacctCategoryDestination now uses a combination of snakeCaseToSpaceCase | sentenceCase instead of the previous transformation. This not only aligns with the branding update to use sentence-style casing but also explicitly corrects the formatting for instances like replacing "Gl " with "GL ".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants