fix:Intacct date grouping fix by DhaaraniCIT · Pull Request #1192 · fylein/fyle-integrations-app

DhaaraniCIT · 2025-02-27T11:16:46Z

Description

fix:Intacct date grouping fix

Clickup

https://app.clickup.com

Screen.Recording.2025-02-27.at.4.41.56.PM.mov

Screen.Recording.2025-02-27.at.4.42.54.PM.mov

Summary by CodeRabbit

Refactor
- Streamlined the configuration for expense date choices in corporate charge card transactions.
- Simplified the logic to consistently use the spent date option, reducing dynamic variations in date settings.
- Adjusted date option labels for improved clarity in the user interface.
Bug Fixes
- Removed outdated test cases related to credit card expense grouping date options.
Chores
- Removed environment declaration for the staging deployment in GitHub Actions workflows.

coderabbitai · 2025-02-27T11:16:54Z

Walkthrough

This pull request refactors the expense date options handling within the IntacctExportSettingsComponent. The dynamic logic for corporate credit card transactions is simplified by removing assignments and watchers for grouping date options. The method now directly patches the export date to a fixed value, and the construction of reimbursable expense grouping options now leverages a static factory method.

Changes

File Path	Change Summary
`src/app/integrations/.../intacct-export-settings.component.ts`	Refactored expense date options logic by removing the assignment of `cccExpenseGroupingDateOptions` in `setCCExpenseDateOptions` and commenting out its invocation in `cccExportTypeWatcher`; removed methods `updateCCCGroupingDateOptions` and `setupCCCGroupingWatcher`; updated `setupCustomWatchers` to use `ExportSettingModel.constructExportDateOptions` for generating grouping options.
`src/app/integrations/.../intacct-export-settings.component.spec.ts`	Removed test case for updating credit card expense grouping date options; modified expected values in `cccExpenseGroupingDateOptions` array, changing labels and values for certain options.
`.github/workflows/.../c1-staging-deployment.yml`	Removed environment declaration `environment: QA` in job `staging_deploy`.
`.github/workflows/.../qa-deployment.yml`	Removed environment declaration `environment: QA` in job `staging_deploy`.

Suggested reviewers

ruuushhh

Poem

Hop along, dear coder friend,
I'm a bunny with a joyful blend,
Skipping over watchers gone astray,
Code paths clear for a brighter day,
With carrots and fixes on display! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a412137 and f2dc1b5.

📒 Files selected for processing (2)

.github/workflows/c1-staging-deployment.yml (0 hunks)
.github/workflows/qa-deployment.yml (0 hunks)

💤 Files with no reviewable changes (2)

.github/workflows/c1-staging-deployment.yml
.github/workflows/qa-deployment.yml

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: staging_deploy

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.ts (1)

280-280: Consider removing commented-out code or clarifying its purpose.
Retaining commented-out code can cause confusion and lead to maintenance overhead. If you no longer need this line, removing it fully is recommended. Otherwise, add a comment explaining the need to keep it.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f408a04 and 1373667.

📒 Files selected for processing (1)

src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.ts (2 hunks)

🔇 Additional comments (2)

src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.ts (2)

464-464: Looks good; verify correctness of constructed date options.
This updated approach to build reimbursableExpenseGroupingDateOptions via constructExportDateOptions() seems consistent with the refactor. As a sanity check, confirm the returned options meet all use cases for reimbursable expenses.

468-471: Straightforward logic for cccExpenseGroupingDateOptions.
Passing true for CHARGE_CARD_TRANSACTION and false otherwise aligns with the new simplified approach. This indicates a clear separation of credit card date-grouping behavior versus reimbursable behavior.

ashwin1111 · 2025-02-27T17:21:06Z

...grations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.ts

    private cccExportTypeWatcher(): void {
      this.exportSettingsForm.controls.cccExportType.valueChanges.subscribe((isCCCExportTypeSelected) => {
-        this.setCCExpenseDateOptions(isCCCExportTypeSelected);
+        // This.setCCExpenseDateOptions(isCCCExportTypeSelected);


cann we remove this instead of commenting

github-actions · 2025-02-28T06:44:36Z

Unit Test Coverage	%	values
Statements	32.92%	( 4146 / 12594 )
Branches	26.35%	( 1174 / 4454 )
Functions	25.48%	( 889 / 3488 )
Lines	33.1%	( 4081 / 12326 )

fix:Intacct date grouping fix

1373667

DhaaraniCIT requested a review from ashwin1111 February 27, 2025 11:16

github-actions bot added the size/M Medium PR label Feb 27, 2025

coderabbitai bot reviewed Feb 27, 2025

View reviewed changes

ashwin1111 approved these changes Feb 27, 2025

View reviewed changes

fix:Intacct date grouping fix

1dc0a55

DhaaraniCIT added staging_deploy Triggers deployment of active branch to Staging c1_qa_deploy Deploys to QA env labels Feb 28, 2025

DhaaraniCIT had a problem deploying to QA February 28, 2025 05:46 — with GitHub Actions Failure

DhaaraniCIT temporarily deployed to Staging February 28, 2025 05:46 — with GitHub Actions Inactive

DhaaraniCIT added 2 commits February 28, 2025 11:28

unit test fix

a412137

c1 deployment fix

f2dc1b5

DhaaraniCIT added c1_qa_deploy Deploys to QA env and removed c1_qa_deploy Deploys to QA env labels Feb 28, 2025

Hrishabh17 closed this Jun 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix:Intacct date grouping fix#1192

fix:Intacct date grouping fix#1192
DhaaraniCIT wants to merge 4 commits intopoc-date-groupingfrom
intacct-date-grouping

DhaaraniCIT commented Feb 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

ashwin1111 Feb 27, 2025

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

DhaaraniCIT commented Feb 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Clickup

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ashwin1111 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

DhaaraniCIT commented Feb 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)