Skip to content

fix: netsuite date grouping fixes#1194

Closed
DhaaraniCIT wants to merge 1 commit intopoc-date-groupingfrom
netsuite-date-grouping
Closed

fix: netsuite date grouping fixes#1194
DhaaraniCIT wants to merge 1 commit intopoc-date-groupingfrom
netsuite-date-grouping

Conversation

@DhaaraniCIT
Copy link
Contributor

@DhaaraniCIT DhaaraniCIT commented Feb 28, 2025 •
edited by coderabbitai bot
Loading

Description

fix: netsuite date grouping fixes

Clickup

https://app.clickup.com/

Summary by CodeRabbit

  • Refactor
    • Streamlined the export settings to deliver more consistent and reliable date options.
    • Ensured that selecting different export types now leads to clearer and more predictable configuration behavior.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2025 •
edited
Loading

Walkthrough

This change refactors the Netsuite export settings component by consolidating the logic for updating date options. Both the updateCCCExpenseGroupingDateOptions and setupCustomDateOptionWatchers methods now utilize a single method call to ExportSettingModel.constructExportDateOptions() with appropriate parameters. The previous conditional checks, including those for brandingConfig.brandId, have been removed, resulting in streamlined and clearer update logic for the export date options.

Changes

File Path Change Summary
src/app/integrations/netsuite/.../netsuite-export-settings.component.ts Refactored updateCCCExpenseGroupingDateOptions to use ExportSettingModel.constructExportDateOptions() instead of separate calls based on condition. Simplified setupCustomDateOptionWatchers by removing checks for brandingConfig.brandId and directly updating export date options.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant User as User Interaction
    participant Component as NetsuiteExportSettingsComponent
    participant Model as ExportSettingModel

    User->>+Component: Change export type or group values
    Component->>Component: Trigger updateCCCExpenseGroupingDateOptions / setupCustomDateOptionWatchers
    Component->>+Model: constructExportDateOptions(isCreditCardCharge, creditCardExportGroup, creditCardExportDate)
    Model-->>-Component: Return updated date options
    Component-->>-Component: Update cccExpenseGroupingDateOptions
Loading

Suggested labels

size/M

Suggested reviewers

  • ruuushhh

Poem

Hop along, dear coder, in the codewood so bright,
I refined the paths where dates take flight.
No more tangled checks, just a single call,
With clear export options that now enthrall.
CodeRabbit hops with delight—cheers to refactoring right!
🐇🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f408a04 and 5f8d60e.

📒 Files selected for processing (1)
  • src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.ts (2 hunks)
🔇 Additional comments (5)
src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.ts (5)

287-289: Improved date options handling

The code now consistently uses ExportSettingModel.constructExportDateOptions() for both credit card charge and non-credit card charge scenarios, making the implementation more uniform and maintainable.

305-306: Simplified conditional logic

The code has been improved by removing the branding-specific check and directly using ExportSettingModel.constructExportDateOptions() to generate date options. This refactoring makes the code more consistent and easier to maintain.

310-310: Standardized date options generation

Using ExportSettingModel.constructExportDateOptions() instead of the custom method improves consistency across the codebase.

314-314: Streamlined code with method delegation

The code has been simplified by delegating the logic to the updateCCCExpenseGroupingDateOptions method, which reduces code duplication.

318-322: Consolidated date option generation logic

The implementation now uses the same ExportSettingModel.constructExportDateOptions() method for both conditions, removing brand-specific logic and creating a more maintainable solution.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/S Small PR label Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

Unit Test Coverage % values
Statements 33.08% ( 4171 / 12607 )
Branches 26.51% ( 1182 / 4458 )
Functions 25.63% ( 895 / 3491 )
Lines 33.26% ( 4105 / 12339 )

@DhaaraniCIT DhaaraniCIT requested a review from ashwin1111 March 5, 2025 06:50
ashwin1111
ashwin1111 reviewed Mar 5, 2025
View reviewed changes
...ions/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.ts
this.cccExpenseGroupingDateOptions = this.reimbursableExpenseGroupingDate(this.exportSettingForm.controls.creditCardExportGroup?.value, NetSuiteExportSettingModel.getReimbursableExpenseGroupingDateOptions());
}
if (this.exportSettingForm.get('creditCardExportType')?.value && this.exportSettingForm.get('creditCardExportType')?.value !== NetSuiteCorporateCreditCardExpensesObject.CREDIT_CARD_CHARGE) {
this.cccExpenseGroupingDateOptions = ExportSettingModel.constructExportDateOptions(true, this.exportSettingForm.controls.creditCardExportGroup.value, this.exportSettingForm.controls.creditCardExportDate.value);
Copy link
Contributor

@ashwin1111 ashwin1111 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st one should be false no? since the condition is !== NetSuiteCorporateCreditCardExpensesObject.CREDIT_CARD_CHARGE

@Hrishabh17 Hrishabh17 closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashwin1111 ashwin1111 ashwin1111 left review comments

Assignees

No one assigned

Labels

size/S Small PR

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DhaaraniCIT @ashwin1111 @Hrishabh17