feat: track new landing_v2 features #1212

JustARatherRidiculouslyLongUsername · 2025-03-13T12:38:20Z

Description

Tracks:

Landing v2 being opened
Dropdown open
Dropdown option being clicked

Clickup

https://app.clickup.com/t/86cy8ykmx

Summary by CodeRabbit

New Features
- Enhanced analytics tracking to improve monitoring of user interactions, including dropdown open events and landing page openings.
- Updated analytics integration configuration to operate consistently across all environments.
- Added interactivity to dropdown components with click event tracking.
Bug Fixes
- Improved type safety for app name input in the main menu component.

coderabbitai · 2025-03-13T12:38:31Z

Walkthrough

The pull request enhances the tracking functionality in the application by modifying the TrackingService to include additional event tracking methods. It updates the Mixpanel integration in index.html to allow tracking on localhost, replacing a placeholder project token with a hardcoded value and introducing a custom library URL. Furthermore, the LandingV2Component and MainMenuComponent are updated to utilize the TrackingService for tracking user interactions.

Changes

File(s)	Change Summary
`src/app/core/services/integration/tracking.service.ts`	Added new methods: `onLandingV2Open()`, `onDropDownOpen(trackingApp)`, and `onDropDownItemClick(trackingApp, options)` in `TrackingService`.
`src/index.html`	Modified Mixpanel script to execute on all hostnames (removed hostname check), replaced placeholder token with a hardcoded token, and added a custom library URL.
`src/app/integrations/landing-v2/landing-v2.component.ts`	Integrated `TrackingService` into `LandingV2Component`, calling `onLandingV2Open()` in `ngOnInit()`.
`src/app/shared/components/menu/main-menu/main-menu.component.html`	Added event binding `(onClick)="handleDropdownClick()"` to `<p-dropdown>` for enhanced interactivity.
`src/app/shared/components/menu/main-menu/main-menu.component.ts`	Updated `appName` property to use `AppName` enum for type safety; integrated `TrackingService` for tracking dropdown interactions; added `handleDropdownClick()` method.

Possibly related PRs

feat: add a dropdown menu to the main menu for navigation and disconnection #1183: Related to modifications in the MainMenuComponent where the TrackingService is integrated to track dropdown interactions.
feat: navigate between previously connected integrations #1184: Related to the TrackingService class, utilized in the LandingV2Component and MainMenuComponent.
fix: login before navigating to an app from the dropdown (wip) #1193: Related to the additions of tracking methods in the TrackingService, which are used in the LandingV2Component and MainMenuComponent.

Suggested labels

size/L

Suggested reviewers

ashwin1111

Poem

I'm a little rabbit with a hop so light,
Logging events by day and night.
Dropdowns open with a skip and jump,
Mixpanel tracks each data bump.
In every line of code I delight,
Hopping on changes, feeling just right!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 33c89ca and a9bb407.

📒 Files selected for processing (1)

src/app/core/services/integration/tracking.service.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/app/core/services/integration/tracking.service.ts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-13T12:38:41Z

PR description must contain a link to a ClickUp (case-insensitive)

coderabbitai

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3fd81d and da7cfcf.

📒 Files selected for processing (2)

src/app/core/services/integration/tracking.service.ts (3 hunks)
src/index.html (1 hunks)

🧰 Additional context used

🪛 ESLint

src/app/core/services/integration/tracking.service.ts

[error] 58-58: Unexpected console statement.

(no-console)

[error] 68-68: Unexpected console statement.

(no-console)

[error] 72-72: Unexpected console statement.

(no-console)

🪛 GitHub Check: lint

src/app/core/services/integration/tracking.service.ts

[failure] 58-58:
Unexpected console statement

[failure] 68-68:
Unexpected console statement

[failure] 72-72:
Unexpected console statement

🪛 GitHub Actions: TypeScript Lint Check

src/app/core/services/integration/tracking.service.ts

[error] 58-58: ESLint: Unexpected console statement (no-console)

🪛 Gitleaks (8.21.2)

src/index.html

13-13: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: staging_deploy
GitHub Check: unit-test

🔇 Additional comments (2)

src/app/core/services/integration/tracking.service.ts (1)

131-133: LGTM - Implementation aligns with PR objective

The new method properly tracks dropdown open events as described in the PR objectives.

src/index.html (1)

14-14: LGTM - Explicit URL declaration

Defining the library URL as a constant is a good practice for ensuring consistent library loading.

src/app/core/services/integration/tracking.service.ts

src/index.html

src/app/core/services/integration/tracking.service.ts

github-actions · 2025-03-19T14:52:48Z

Unit Test Coverage	%	values
Statements	32.81%	( 4205 / 12815 )
Branches	26.29%	( 1187 / 4514 )
Functions	25.53%	( 902 / 3533 )
Lines	33.01%	( 4140 / 12541 )

* feat: track new landing_v2 features (wip) * feat: track landing V2, dropdown events * refactor: remove loggers (cherry picked from commit 573491b)

feat: track new landing_v2 features (wip)

da7cfcf

JustARatherRidiculouslyLongUsername added the deploy Triggers deployment of active branch to Staging label Mar 13, 2025

JustARatherRidiculouslyLongUsername temporarily deployed to Staging March 13, 2025 12:38 — with GitHub Actions Inactive

github-actions bot added the size/XS Extra Small PR label Mar 13, 2025

coderabbitai bot reviewed Mar 13, 2025

View reviewed changes

src/app/core/services/integration/tracking.service.ts Outdated Show resolved Hide resolved

src/app/core/services/integration/tracking.service.ts Outdated Show resolved Hide resolved

src/index.html Outdated Show resolved Hide resolved

src/index.html Outdated Show resolved Hide resolved

JustARatherRidiculouslyLongUsername added deploy Triggers deployment of active branch to Staging and removed deploy Triggers deployment of active branch to Staging labels Mar 13, 2025

JustARatherRidiculouslyLongUsername temporarily deployed to Staging March 13, 2025 13:53 — with GitHub Actions Inactive

ashwin1111 reviewed Mar 13, 2025

View reviewed changes

src/index.html Show resolved Hide resolved

src/app/core/services/integration/tracking.service.ts Show resolved Hide resolved

src/app/core/services/integration/tracking.service.ts Outdated Show resolved Hide resolved

feat: track landing V2, dropdown events

5512a71

github-actions bot added size/S Small PR and removed size/XS Extra Small PR labels Mar 18, 2025

JustARatherRidiculouslyLongUsername added deploy Triggers deployment of active branch to Staging and removed deploy Triggers deployment of active branch to Staging labels Mar 18, 2025

JustARatherRidiculouslyLongUsername had a problem deploying to Staging March 18, 2025 14:12 — with GitHub Actions Error

Merge branch 'master' into track-landing-v2

33c89ca

JustARatherRidiculouslyLongUsername added deploy Triggers deployment of active branch to Staging and removed deploy Triggers deployment of active branch to Staging labels Mar 18, 2025

JustARatherRidiculouslyLongUsername temporarily deployed to Staging March 18, 2025 14:15 — with GitHub Actions Inactive

refactor: remove loggers

a9bb407

JustARatherRidiculouslyLongUsername requested a review from ashwin1111 March 19, 2025 14:52

JustARatherRidiculouslyLongUsername changed the title ~~feat: track new landing_v2 features (wip)~~ feat: track new landing_v2 features Mar 19, 2025

ashwin1111 approved these changes Mar 19, 2025

View reviewed changes

JustARatherRidiculouslyLongUsername merged commit 573491b into master Mar 19, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: track new landing_v2 features #1212

feat: track new landing_v2 features #1212

Uh oh!

JustARatherRidiculouslyLongUsername commented Mar 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

feat: track new landing_v2 features #1212

feat: track new landing_v2 features #1212

Uh oh!

Conversation

JustARatherRidiculouslyLongUsername commented Mar 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Clickup

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 13, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

JustARatherRidiculouslyLongUsername commented Mar 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)