fix: Export settings page bug fixes for intacct & netsuite #1373
Conversation
WalkthroughThe updates modify the form control logic for export settings in the Intacct and NetSuite integration components. They refine how form fields are validated, enabled, disabled, and reset based on user export type selections, and adjust the filtering of export type options. Related test cases are updated for the new control state expectations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ExportSettingsComponent
participant FormControls
User->>ExportSettingsComponent: Selects reimbursable export type
ExportSettingsComponent->>FormControls: Update validators and enabled/disabled states
alt Export type is BILL
ExportSettingsComponent->>FormControls: Set glAccount required, disable employeeFieldMapping, set to VENDOR
ExportSettingsComponent->>FormControls: Filter credit card export types (exclude EXPENSE_REPORT)
ExportSettingsComponent->>FormControls: If cccExportType is EXPENSE_REPORT, reset to null
else Export type is not BILL
ExportSettingsComponent->>FormControls: Reset credit card export types to full set
end
User->>ExportSettingsComponent: Selects credit card export type
ExportSettingsComponent->>FormControls: Update validators and enabled/disabled states
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| [exportTypeIconPathArray]="previewImagePaths"> | ||
| </app-configuration-select-field> | ||
| <div *ngIf="exportSettingsForm.get('reimbursableExportType')?.value===IntacctReimbursableExpensesObject.JOURNAL_ENTRY"> | ||
| <div *ngIf="exportSettingsForm.get('reimbursableExportType')?.value===IntacctReimbursableExpensesObject.JOURNAL_ENTRY || exportSettingsForm.get('reimbursableExportType')?.value===IntacctReimbursableExpensesObject.BILL"> |
There was a problem hiding this comment.
the save button getting disabled is a problem with netsuite, not Intacct. This field has to be shown only for JE
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ithub.com/fylein/fyle-integrations-app into intacct-nestuite-export-setting-bug-fixes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🔁 Code Duplication Report - Angular
📊 No significant change in code duplication. |
There was a problem hiding this comment.
Bug: GL Account Retains Value Across Export Types
The removal of setValue(null) for the glAccount field causes it to retain its value when the reimbursable export type is switched away from JOURNAL_ENTRY. As glAccount is only relevant for JOURNAL_ENTRY exports, this leaves an irrelevant value in the field, creating an inconsistent form state and potentially saving stale data.
src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.ts#L296-L299
Was this report helpful? Give feedback by reacting with 👍 or 👎
2 participants
Description
Export settings page bug fixes for intacct & netsuite
Bug 1
set JE as reimburse, cc as bill, save, now update je to bill, save is disabled - some mandatory field is not showing up
Bug 2
bill in reimburse, ccc when select je, employee field mapping is becoming editable - it should not be
Bug 3
Selected Reimbursable as BILL and able to select CCC export type as EXPENSE REPORT
Clickup
https://app.clickup.com/
Summary by CodeRabbit
Bug Fixes
Tests