-
Notifications
You must be signed in to change notification settings - Fork 0
chore: removed unused variables and update them with brand specific ones #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis change set updates the application's theming and styling system to align with a new design token-based approach, including the removal and replacement of legacy color variables and utility classes. It introduces a detailed migration plan for PrimeNG theming, updates Tailwind and SCSS configurations, modifies numerous component templates and styles to use new color and border classes, and adjusts dependency declarations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AngularComponent
participant ThemeSystem
participant Tailwind/SCSS
User->>AngularComponent: Loads UI/component
AngularComponent->>ThemeSystem: Requests current theme tokens
ThemeSystem-->>AngularComponent: Provides design token variables
AngularComponent->>Tailwind/SCSS: Applies new utility classes (e.g., border/text colors)
Tailwind/SCSS-->>AngularComponent: Renders with updated styles
AngularComponent-->>User: Displays themed UI with new tokens
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🔁 Code Duplication Report - Angular
🎉 This PR reduces duplicated code by 0.02%! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 11
🔭 Outside diff range comments (2)
src/app/integrations/qbd/qbd-main/qbd-mapping/qbd-generic-mapping/qbd-generic-mapping.component.html (1)
16-16: Old token still present – update or remove for consistency
tw-border-t-separatorsurvives on the inner divider while the outer card has moved totw-border-border-tertiary.
Retaining two different separator colours in the same block risks visual inconsistency and defeats the clean-up objective of this PR.-<div class="tw-p-24-px tw-border tw-border-t-separator" *ngIf="totalCount > 0" > +<div class="tw-p-24-px tw-border-t-1-px tw-border-border-tertiary" *ngIf="totalCount > 0" >tailwind.config.js (1)
3-23: Remove all legacy color token referencesSeveral removed tokens (
bg-warning-lighter,icon-warning,line-inactive, etc.) are still being defined or used across SCSS and HTML. Please replace or remove these references in favor of the new theming tokens:• src/assets/themes/fyle/fdl.scss
–--bg-warning-lighter
–--icon-warning• src/assets/themes/co/c1dl.scss
–--bg-warning-lighter
–--icon-warning
–--alerts-warning-bg
–--alerts-warning-icon-color
–--modal-warning-icon-color
–--toast-warning-bg
–--toast-warning-icon-color
–--expense-list-warning-icon-color• src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.scss & .html
–.line-inactive• src/app/shared/components/helper/onboarding-stepper/onboarding-stepper.component.scss & .html
–.line-inactive• src/app/shared/components/configuration/configuration-confirmation-dialog/configuration-confirmation-dialog.component.html
–tw-bg-bg-warning-lighter• src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html
–tw-bg-bg-warning-lighterAfter updating these, rerun a global grep to confirm no remaining references.
🧹 Nitpick comments (15)
src/app/integrations/xero/xero-shared/xero-advanced-settings/xero-advanced-settings.component.html (1)
4-4: Consider centralising the recurring border utility
tw-border-border-tertiaryis now applied on every container that already has the semantic classconfiguration--contents(and other nested panels).
To reduce repetition and future churn, you could push the new border utility into a single SCSS rule for those shared wrapper classes instead of duplicating it in dozens of templates.Example (global SCSS / Tailwind layer):
-.configuration--contents { - @apply tw-border-separator tw-rounded-12-px; -} +.configuration--contents { + @apply tw-border-border-tertiary tw-rounded-12-px; +}That keeps templates cleaner and confines future theme tweaks to one place.
Also applies to: 24-24, 56-56, 109-109
src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.scss (1)
37-39: Duplicate.containerselector can cause unpredictable overrides
.containeris declared twice in the same file (lines 37-39 and 97-103) with different rule sets. Future maintainers must scan the whole file to understand which block wins, harming readability and maintainability.- .container { - @apply tw-flex tw-justify-center tw-text-checkbox-label-text; - } +/* Suggestion: give the second block a more specific name to reflect its purpose */ +.checkbox-container { + @apply tw-relative tw-cursor-pointer tw-select-none tw-block #{!important}; +} + +/* If both blocks truly style the same element, merge them instead: */ +.container { + @apply tw-flex tw-justify-center tw-text-checkbox-label-text + tw-relative tw-cursor-pointer tw-select-none tw-block #{!important}; +}Also applies to: 97-103
src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (1)
180-182: Inline info box adopts new background + border tokensGood consistency. While you’re here, consider extracting the repeated “info box” markup into a dedicated component to avoid duplicating padding / colour classes across multiple templates.
src/app/shared/components/menu/main-menu/main-menu.component.html (1)
57-59: Add a semantic separator role for better accessibilityThe horizontal rule is purely decorative, but assistive technologies will not recognise its purpose without an explicit role. Adding
role="separator"(and optionallyaria-hidden="true") makes intent clear without altering layout.- <div class="tw-border-t tw-border-border-tertiary tw-w-full"></div> + <div class="tw-border-t tw-border-border-tertiary tw-w-full" role="separator" aria-hidden="true"></div>src/app/shared/components/dashboard/dashboard-export-section/dashboard-export-section.component.scss (1)
1-9: Re-evaluate use of::ng-deepfor theme overrides.
::ng-deepis deprecated and may break with future Angular versions. Consider:-:host ::ng-deep .p-progressbar { @apply tw-h-1.5 tw-bg-bg-tertiary !important; } +:host-context(.p-component) .p-progressbar { @apply tw-h-1.5 tw-bg-bg-tertiary; }and move brand-specific overrides into a global stylesheet or CSS-variables-driven theme file to avoid view-encapsulation leakage.
src/app/shared/components/configuration/email-multi-select-field/email-multi-select-field.component.html (1)
59-65: Minor accessibility nit – consider underline for the linkThe “add new email address” text now inherits
tw-text-text-secondary, but there’s no underline style. For better a11y, keeptw-underlineso keyboard users recognise it as interactive.src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html (1)
4-4: DRY up repeated border utility
tw-border-border-tertiaryis now duplicated in dozens of wrappers throughout the template.
Consider extracting a small wrapper component or a custom utility class (e.g..bc-section) so future token changes require a single edit instead of a mass find/replace.src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.html (1)
323-324: Left-over legacy text class
tw-text-sub-text-colordirectly below the changed line still references the old color token family.
If this class is deprecated liketw-text-slightly-normal-text-color, migrate it to the new equivalent (tw-text-text-muted/tw-text-text-secondary) for consistency.src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html (1)
382-382: Keep token usage consistentNice catch updating the primary text to
tw-text-text-secondary; consider doing the same audit for the surrounding muted text (tw-text-faded-text-color,tw-text-text-muted) to ensure the whole disabled block follows the new palette.src/app/integrations/sage300/sage300-shared/sage300-export-settings/sage300-export-settings.component.html (1)
38-44: Remove duplicated[appName]bindingTwo identical
[appName]="appName"attributes are declared back-to-back.
The second one is redundant and bloats the template.- [exportConfigurationIconPath]="'assets/illustrations/sage300/preview.png'" - [exportTypeIconPathArray]="previewImagePaths" - [appName]="appName" - [showExportPreview]="true" + [exportConfigurationIconPath]="'assets/illustrations/sage300/preview.png'" + [exportTypeIconPathArray]="previewImagePaths" + [showExportPreview]="true"src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html (1)
297-312: DuplicateisFieldMandatoryattributeLines 301 & 303 both set
[isFieldMandatory]="true". One of them is redundant and can be removed to avoid confusion.src/app/integrations/bamboo-hr/configuration/configuration.component.html (2)
2-2: Typo in form group variable
cofigurationFormis misspelled (missing “n”) throughout the template.
While not introduced in this diff, renaming now will avoid future confusion and reduce search friction.-<div [formGroup]="cofigurationForm" +<div [formGroup]="configurationForm"Refactor the backing component class accordingly.
Also applies to: 9-9
27-27: Two[disabled]bindings on the same buttonThe button currently has:
[disabled]="!cofigurationForm.valid" ... [disabled]="isConfigurationSaveInProgress"Angular will evaluate both but the latter overrides the former, which may lead to unintended states. Combine the conditions into a single expression.
-[disabled]="!configurationForm.valid" ... -[disabled]="isConfigurationSaveInProgress" +[disabled]="isConfigurationSaveInProgress || !configurationForm.valid"src/assets/themes/fyle/fdl.scss (1)
56-56:--border-neutralduplicates--border-primaryBoth tokens resolve to
$grey-700. Unless design explicitly needs two aliases, consider referencing--border-primaryto prevent future divergence.- --border-neutral: #{$grey-700}; + // Re-use primary to avoid duplication + --border-neutral: var(--border-primary);PRIMENG_THEMING_MIGRATION_PLAN.md (1)
330-330: Fix markdown formatting: use heading instead of emphasis.The static analysis correctly identified that emphasis formatting is being used where a heading would be more appropriate.
-**Total Estimated Duration: 9 weeks** +## Total Estimated Duration: 9 weeks
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (82)
PRIMENG_THEMING_MIGRATION_PLAN.md(1 hunks)package.json(1 hunks)src/app/core/guard/qbo-token.guard.ts(1 hunks)src/app/integrations/bamboo-hr/bamboo-hr.component.html(4 hunks)src/app/integrations/bamboo-hr/configuration/configuration.component.html(2 hunks)src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-complete-export-log/business-central-complete-export-log.component.html(1 hunks)src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-skipped-export-log/business-central-skipped-export-log.component.html(1 hunks)src/app/integrations/business-central/business-central-onboarding/business-central-onboarding-connector/business-central-onboarding-connector.component.html(1 hunks)src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.html(4 hunks)src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html(17 hunks)src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html(4 hunks)src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.html(1 hunks)src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.html(6 hunks)src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.html(13 hunks)src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.scss(0 hunks)src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html(6 hunks)src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.scss(1 hunks)src/app/integrations/landing-v2/landing-v2.component.html(2 hunks)src/app/integrations/landing-v2/landing-v2.component.scss(3 hunks)src/app/integrations/landing/landing.component.html(1 hunks)src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html(1 hunks)src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html(2 hunks)src/app/integrations/netsuite/netsuite-shared/netsuite-import-settings/netsuite-custom-segment-dialog/netsuite-custom-segment-dialog.component.scss(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html(4 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-assisted-setup/qbd-direct-assisted-setup.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-download-file/qbd-direct-download-file.component.html(2 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-import-settings/qbd-direct-import-settings.component.html(1 hunks)src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-setup-connection/qbd-direct-setup-connection.component.html(2 hunks)src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.html(2 hunks)src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.scss(2 hunks)src/app/integrations/qbd/qbd-main/qbd-mapping/qbd-generic-mapping/qbd-generic-mapping.component.html(1 hunks)src/app/integrations/qbd/qbd-shared/qbd-advanced-setting/qbd-advanced-setting.component.html(6 hunks)src/app/integrations/qbd/qbd-shared/qbd-export-setting/qbd-export-setting.component.html(13 hunks)src/app/integrations/qbd/qbd-shared/qbd-field-mapping/qbd-field-mapping.component.html(4 hunks)src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html(2 hunks)src/app/integrations/qbo/qbo-shared/qbo-import-settings/qbo-import-settings.component.html(1 hunks)src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-complete-export-log/sage300-complete-export-log.component.html(1 hunks)src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-skipped-export-log/sage300-skipped-export-log.component.html(1 hunks)src/app/integrations/sage300/sage300-onboarding/sage300-onboarding-connector/sage300-onboarding-connector.component.html(1 hunks)src/app/integrations/sage300/sage300-shared/sage300-advanced-settings/sage300-advanced-settings.component.html(4 hunks)src/app/integrations/sage300/sage300-shared/sage300-export-settings/sage300-export-settings.component.html(14 hunks)src/app/integrations/sage300/sage300-shared/sage300-import-settings/sage300-import-settings.component.html(2 hunks)src/app/integrations/travelperk/travelperk-shared/travelperk-advanced-settings/travelperk-advanced-settings.component.html(4 hunks)src/app/integrations/travelperk/travelperk-shared/travelperk-payment-profile-settings/travelperk-payment-profile-settings.component.html(1 hunks)src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html(1 hunks)src/app/integrations/xero/xero-shared/xero-advanced-settings/xero-advanced-settings.component.html(1 hunks)src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html(1 hunks)src/app/shared/components/configuration/configuration-confirmation-dialog/configuration-confirmation-dialog.component.html(1 hunks)src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html(1 hunks)src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.scss(1 hunks)src/app/shared/components/configuration/configuration-multi-select/configuration-multi-select.component.scss(0 hunks)src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.scss(3 hunks)src/app/shared/components/configuration/configuration-step-footer/configuration-step-footer.component.scss(1 hunks)src/app/shared/components/configuration/configuration-step-sub-header/configuration-step-sub-header.component.html(1 hunks)src/app/shared/components/configuration/configuration-text-field/configuration-text-field.component.scss(1 hunks)src/app/shared/components/configuration/email-multi-select-field/email-multi-select-field.component.html(3 hunks)src/app/shared/components/configuration/email-multi-select-field/email-multi-select-field.component.scss(2 hunks)src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html(2 hunks)src/app/shared/components/dashboard/dashboard-export-section/dashboard-export-section.component.scss(1 hunks)src/app/shared/components/dashboard/dashboard-token-expired/dashboard-token-expired.component.html(1 hunks)src/app/shared/components/helper/app-landing-page-header/app-landing-page-header.component.html(2 hunks)src/app/shared/components/helper/onboarding-done/onboarding-done.component.html(1 hunks)src/app/shared/components/helper/onboarding-stepper/onboarding-stepper.component.scss(1 hunks)src/app/shared/components/menu/main-menu/main-menu.component.html(1 hunks)src/app/shared/components/menu/main-menu/main-menu.component.scss(1 hunks)src/app/shared/components/netsuite/core/netsuite-connector/netsuite-connector.component.html(1 hunks)src/app/shared/components/netsuite/core/netsuite-connector/netsuite-connector.component.scss(0 hunks)src/app/shared/components/netsuite/core/netsuite-subsidiary-mapping/netsuite-subsidiary-mapping.component.html(1 hunks)src/app/shared/components/onboarding/clone-setting/clone-setting-field/clone-setting-field.component.scss(1 hunks)src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.html(2 hunks)src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.scss(1 hunks)src/app/shared/components/qbd/mapping/qbd-mapping-header-section/qbd-mapping-header-section.component.html(1 hunks)src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.scss(1 hunks)src/app/shared/components/si/core/intacct-connector/intacct-connector.component.html(1 hunks)src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html(1 hunks)src/app/shared/components/si/helper/skip-export/skip-export.component.scss(1 hunks)src/app/shared/pages/export-log/skipped-export-log/skipped-export-log.component.html(1 hunks)src/assets/themes/fyle/fdl.scss(2 hunks)src/assets/themes/theme.scss(0 hunks)src/styles.scss(6 hunks)tailwind.config.js(1 hunks)
💤 Files with no reviewable changes (4)
- src/app/shared/components/configuration/configuration-multi-select/configuration-multi-select.component.scss
- src/app/shared/components/netsuite/core/netsuite-connector/netsuite-connector.component.scss
- src/assets/themes/theme.scss
- src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.scss
🧰 Additional context used
🧠 Learnings (44)
📓 Common learnings
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable `targetSystemName` in the subLabel string within the `business-central-export-settings.component.html` file.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable `targetSystemName` in the subLabel string within the `business-central-export-settings.component.html` file.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (`*ngIf="false"`), which was making an `h5` element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (`*ngIf="false"`), which was making an `h5` element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable `targetSystemName` for dynamic system naming in the `business-central-export-settings.component.html` file.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable `targetSystemName` for dynamic system naming in the `business-central-export-settings.component.html` file.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#353
File: src/app/core/services/business-central/business-central-configuration/business-central-advanced-settings.service.ts:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the correction of a typo in the method name from `getExpenseFilelds` to `getExpenseFields` in the `BusinessCentralAdvancedSettingsService` class.
Learnt from: ashwin1111
PR: fylein/fyle-integrations-app#353
File: src/app/core/services/business-central/business-central-configuration/business-central-advanced-settings.service.ts:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the correction of a typo in the method name from `getExpenseFilelds` to `getExpenseFields` in the `BusinessCentralAdvancedSettingsService` class.
src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-complete-export-log/business-central-complete-export-log.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.html (6)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/business-central/business-central-onboarding/business-central-onboarding-connector/business-central-onboarding-connector.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (2)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-skipped-export-log/sage300-skipped-export-log.component.html (6)
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/shared/components/si/core/intacct-connector/intacct-connector.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/shared/components/netsuite/core/netsuite-connector/netsuite-connector.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/qbo/qbo-shared/qbo-import-settings/qbo-import-settings.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/sage300/sage300-onboarding/sage300-onboarding-connector/sage300-onboarding-connector.component.html (6)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/shared/components/configuration/configuration-confirmation-dialog/configuration-confirmation-dialog.component.html (2)
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-setup-connection/qbd-direct-setup-connection.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/travelperk/travelperk-shared/travelperk-advanced-settings/travelperk-advanced-settings.component.html (1)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-import-settings/qbd-direct-import-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/xero/xero-shared/xero-advanced-settings/xero-advanced-settings.component.html (2)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/shared/components/netsuite/core/netsuite-subsidiary-mapping/netsuite-subsidiary-mapping.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html (2)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/shared/components/helper/app-landing-page-header/app-landing-page-header.component.html (4)
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/integrations/netsuite/netsuite-shared/netsuite-export-settings/netsuite-export-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/qbd/qbd-shared/qbd-advanced-setting/qbd-advanced-setting.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-skipped-export-log/business-central-skipped-export-log.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.scss (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/qbd/qbd-shared/qbd-export-setting/qbd-export-setting.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/bamboo-hr/bamboo-hr.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/shared/components/helper/onboarding-done/onboarding-done.component.html (2)
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-download-file/qbd-direct-download-file.component.html (2)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/integrations/sage300/sage300-shared/sage300-advanced-settings/sage300-advanced-settings.component.html (6)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/integrations/sage300/sage300-shared/sage300-export-settings/sage300-export-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/intacct/intacct-shared/intacct-export-settings/intacct-export-settings.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/sage300/sage300-shared/sage300-import-settings/sage300-import-settings.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (1)
Learnt from: ashwin1111
PR: #326
File: src/app/shared/components/configuration/configuration-connector/configuration-connector.component.html:46-46
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user confirmed the correction of a typo from switchLinkTex to switchLinkText.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html (6)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
Learnt from: ashwin1111
PR: #298
File: src/app/shared/components/export-log/skipped-export-log-table/skipped-export-log-table.component.html:21-22
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has requested the removal of a condition that was always evaluating to false (*ngIf="false"), which was making an h5 element never visible. This indicates a preference for removing redundant or placeholder code that is not currently in use.
src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-complete-export-log/sage300-complete-export-log.component.html (6)
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html (7)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html (5)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html (4)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html (9)
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the replacement of the 'intacct' keyword with the variable targetSystemName for dynamic system naming in the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 has confirmed the suggestion to replace the hardcoded reference to 'Sage Intacct' with a dynamic reference to the target system using the variable targetSystemName in the subLabel string within the business-central-export-settings.component.html file.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: anishfyle
PR: #367
File: src/app/core/models/sage300/db/sage300-accounting-export.model.ts:10-14
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user agreed with the suggestion to remove an unused import statement for BusinessCentralAccountingExport after the type was no longer used in the Sage300AccountingExportResponse interface.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-06-10T19:13:15.470Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
Learnt from: ashwin1111
PR: #343
File: src/app/integrations/business-central/business-central-shared/business-central-export-settings/business-central-export-settings.component.html:0-0
Timestamp: 2024-10-08T15:51:28.972Z
Learning: The user ashwin1111 requested the removal of the "CRE" acronym from the subLabel string in the business-central-export-settings.component.html file, indicating a preference for not including this acronym in the user interface text.
🪛 markdownlint-cli2 (0.17.2)
PRIMENG_THEMING_MIGRATION_PLAN.md
330-330: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: unit-test
🔇 Additional comments (73)
package.json (1)
41-41: Approve new @primeuix/themes@^1.2.1 dependency.
- npm registry confirms version 1.2.1 exists.
- No peerDependencies declared, so it’s compatible with PrimeNG ^17.17.0.
src/app/shared/components/qbd/mapping/qbd-mapping-table/qbd-mapping-table.component.scss (1)
14-14: LGTM! Text color standardization aligns with theming migration.The change from
tw-text-slightly-normal-text-colortotw-text-text-secondaryis consistent with the broader theming migration effort to standardize color utilities.src/app/integrations/netsuite/netsuite-main/netsuite-export-log/netsuite-skipped-export-log/netsuite-skipped-export-log.component.html (1)
5-5: LGTM! Border color standardization aligns with theming migration.The change from
tw-border-separatortotw-border-border-tertiaryis consistent with the systematic theming migration to standardize border color utilities across components.src/app/shared/components/onboarding/clone-setting/clone-setting-field/clone-setting-field.component.scss (1)
11-11: LGTM! Consistent text color standardization.The change from
tw-text-slightly-normal-text-colortotw-text-text-secondarymaintains consistency with the theming migration pattern observed across other components.src/app/shared/components/configuration/configuration-text-field/configuration-text-field.component.scss (1)
14-14: Confirmtw-text-text-secondaryexists in the Tailwind design-token mapThe old token
tw-text-slightly-normal-text-colorhas been replaced.
Please make suretw-text-text-secondaryis defined intailwind.config.js(or the injected design-token layer) so that the text colour isn’t lost at runtime.src/app/shared/pages/export-log/skipped-export-log/skipped-export-log.component.html (1)
5-5: Border class update looks good
tw-border-separator→tw-border-border-tertiaryaligns with the new design-token naming. No issues spotted.src/app/shared/components/helper/onboarding-stepper/onboarding-stepper.component.scss (1)
9-11: Verify the colour token used for borders
tw-border-slightly-normal-text-coloris a text-colour token being reused as a border colour.
Double-check the token palette: if a dedicated border token (e.g.,tw-border-border-tertiary) exists for this shade, prefer that to maintain semantic consistency.src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-skipped-export-log/sage300-skipped-export-log.component.html (1)
5-5: Consistent theming appliedBorder class updated to
tw-border-border-tertiary; change is straightforward and matches the global migration pattern.src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.scss (1)
9-11: Token replacement looks correct
tw-text-slightly-normal-text-color→tw-text-text-secondaryfollows the new token scheme; no functional concerns found.src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-skipped-export-log/business-central-skipped-export-log.component.html (1)
5-5: Border colour token updated – confirm Tailwind mapping
tw-border-border-tertiaryis a valid replacement for the deprecatedtw-border-separator, but please double-check that the new token is present intailwind.config.js(or the imported design-token layer) to avoid a runtime “class not found” styling regression.src/app/integrations/qbd/qbd-main/qbd-mapping/qbd-generic-mapping/qbd-generic-mapping.component.html (1)
9-9: 👍 Consistent use of new border tokenOuter card now uses
tw-border-border-tertiary, matching the new design-token palette.src/app/integrations/intacct/intacct-main/intacct-export-log/intacct-skip-export-log/intacct-skip-export-log.component.html (1)
5-5: Token switched – verify availability in all branded themesSame note as other components: ensure every active brand/theme ships a
border-tertiarycolour; otherwise the border may fall back to default, altering contrast.src/app/shared/components/helper/onboarding-done/onboarding-done.component.html (1)
6-6: Success icon background token renamed – looks goodThe rename to
tw-bg-bg-successaligns with the new token set; no semantic issues spotted.src/app/integrations/business-central/business-central-main/business-central-export-log/business-central-complete-export-log/business-central-complete-export-log.component.html (1)
5-5: Border token updated – mirror change across sibling componentsChange is correct; just ensure all sibling export-log templates received the same update to avoid subtle mismatches between complete vs skipped views.
src/app/integrations/travelperk/travelperk-shared/travelperk-payment-profile-settings/travelperk-payment-profile-settings.component.html (1)
4-4: Border token update looks goodSwitching from
tw-border-separatorto the new design-token classtw-border-border-tertiaryaligns with the theming migration and has no functional impact.src/app/integrations/sage300/sage300-onboarding/sage300-onboarding-connector/sage300-onboarding-connector.component.html (1)
9-9: Token replacement validatedThe container now uses the new design-token class as expected; no functional impact observed.
src/app/shared/components/configuration/configuration-step-footer/configuration-step-footer.component.scss (1)
6-6: Text-colour utility migrated correctly
tw-text-text-secondaryis the correct replacement for the deprecatedtw-text-slightly-normal-text-color. Looks good.src/app/shared/components/si/core/intacct-location-entity/intacct-location-entity.component.html (1)
5-5: Consistent border token appliedThe wrapper now references
tw-border-border-tertiary, matching the new theme palette.src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.scss (1)
9-11: Token swap looks correct
tw-text-slightly-normal-text-color→tw-text-text-secondaryaligns with the new design-token palette; no other side-effects spotted.src/app/shared/components/dashboard/dashboard-token-expired/dashboard-token-expired.component.html (1)
58-60: Progress message token updated correctlyThe loading text now uses
tw-text-text-secondary; matches global token changes.src/app/shared/components/si/helper/skip-export/skip-export.component.scss (1)
58-66: Chip label/icon colour token updatedThe swap to
tw-text-text-secondaryis consistent with the new palette.src/app/integrations/sage300/sage300-main/sage300-export-log/sage300-complete-export-log/sage300-complete-export-log.component.html (1)
5-5: Border token update retains widthColour token replaced while keeping
tw-border-1-px; visual integrity preserved.src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-import-settings/qbd-direct-import-settings.component.html (1)
27-31: Confirm new utility class is available at runtime
tw-text-text-secondaryreplaces a bespoke class. Make sure this utility is generated in the Tailwind build (checktailwind.config.js→safelist/ theme tokens) so the heading doesn’t silently fall back to default text colour in prod.src/app/integrations/landing/landing.component.html (1)
1-1: LGTM – aligns landing page with token-based paletteClass swap is consistent with the global theming migration; no functional impact observed.
src/app/shared/components/netsuite/core/netsuite-connector/netsuite-connector.component.html (1)
6-6: Border colour token updated – double-check visual contrast
tw-border-border-tertiaryis less prominent thantw-border-separator. Verify the container still meets accessibility contrast guidelines, especially againsttw-bg-bg-tertiary-lighterbackgrounds used elsewhere in the wizard.src/app/shared/components/configuration/configuration-step-sub-header/configuration-step-sub-header.component.html (1)
1-1: Sub-header adopts new border token – looks goodChange is purely cosmetic and follows the global rename; no further action required.
src/app/shared/components/configuration/configuration-import-field/configuration-import-field.component.html (1)
31-32: ngClass string now containstw-border-border-tertiaryWhen the surrounding
ngClasstoggles off, Angular leaves this literal class on the element. Confirm that dropping the oldtw-border-separatoreverywhere didn’t break older saved templates rendered from server-side docs or e-mails (if any consume the same markup).src/app/integrations/business-central/business-central-onboarding/business-central-onboarding-connector/business-central-onboarding-connector.component.html (1)
9-10: Confirm border width styling –tw-bordermay have been dropped inadvertentlyThe updated class list keeps the colour (
tw-border-border-tertiary) but the generic width/style utility (tw-border) that existed earlier appears to be removed. Ifconfiguration--contentsdoes not already apply a border-width, the border will disappear.-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" +<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"Please verify that a 1-px border is still rendered across all themes.
src/app/shared/components/netsuite/core/netsuite-subsidiary-mapping/netsuite-subsidiary-mapping.component.html (1)
6-7: Border width consistency checkSimilar to the Business Central template, the colour class was changed but the width utility seems missing. Ensure
configuration--contentsor another wrapper still definesborderso the visual divider remains.-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" +<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"src/app/integrations/netsuite/netsuite-shared/netsuite-import-settings/netsuite-custom-segment-dialog/netsuite-custom-segment-dialog.component.scss (1)
13-15: Text colour token update looks goodThe switch to
tw-text-text-secondaryaligns with the new design-token palette and does not change specificity. No other issues spotted.src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-export-settings/qbd-direct-export-settings.component.html (1)
40-44: LGTM – border class updated correctly
tw-border-border-tertiaryis applied alongsidetw-border tw-border-solid; border width and style are intact.
No further action needed.src/app/integrations/landing-v2/landing-v2.component.html (1)
1-1: Updated tokens look correct – no further action needed.The switch to
tw-text-text-secondaryandtw-border-border-tertiaryis consistent with the new design-token naming. No functional impact detected.Also applies to: 11-11
src/app/shared/components/dashboard/dashboard-error-section/dashboard-error-section.component.html (1)
32-33: Token replacement is fine – verify thattw-text-text-successexists in the theme bundle.Nothing else changed in the SVG-icon usage. If the new token has already been added to
tailwind.config.js, there is nothing to fix.Also applies to: 56-57
src/app/integrations/qbo/qbo-shared/qbo-import-settings/qbo-import-settings.component.html (1)
27-32: New text-color token applied correctly.Implementation aligns with the global theming refactor; no logical side-effects observed.
src/app/integrations/xero/xero-shared/xero-export-settings/xero-export-settings.component.html (1)
104-113: Border token change looks good.The wrapper still keeps the correct rounded/border classes; behaviour unchanged.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-assisted-setup/qbd-direct-assisted-setup.component.html (1)
68-71: Confirm Tailwind tokentw-border-slightly-normal-text-colorexistsThe textarea’s border and focus states now rely on
tw-border-slightly-normal-text-color. If this token is missing from the updated Tailwind theme the input will have no visible border.Suggest running the verification script from the previous comment (add the token to the array) or manually checking the config.
src/app/shared/components/menu/main-menu/main-menu.component.scss (1)
15-17: Secondary-text token update looks goodUsing
tw-text-text-secondaryis consistent with the new design-token naming. No issues spotted.src/app/shared/components/qbd/mapping/qbd-mapping-header-section/qbd-mapping-header-section.component.html (1)
3-4: BG & text tokens switched to design-tokens – all consistentBoth statistic cards now use
tw-bg-bg-brand-mutedfor the bar andtw-text-text-secondaryfor the counts. The change is consistent with the global migration; no functional concerns.Also applies to: 8-9, 14-15, 19-20
src/app/shared/components/helper/app-landing-page-header/app-landing-page-header.component.html (1)
4-4: Header adoptstw-text-text-secondary– looks correctSwapping the legacy text-color class for the new secondary token aligns this component with the updated palette. No further action needed.
Also applies to: 28-29
src/app/shared/components/configuration/configuration-skip-export/configuration-skip-export.component.scss (3)
21-23: Border color token removed – verify default styling
tw-border-line-inactivecarried the color token as well as the width.
After its removal the rule now applies onlytw-border, letting the framework’s default border colour take over.
If the intent was to keep a specific design-token colour, add it explicitly:-@apply tw-border tw-rounded-4-px ... +@apply tw-border tw-border-border-tertiary tw-rounded-4-px ...
37-39: Chip token border now inherits default colourSame concern as above for
.p-chips-token.
Confirm that the neutral border (previouslytw-border-line-inactive) is still visible against the white chip background, or explicitly apply the required colour token.
72-74: Text colour swap looks goodSwitching to
tw-text-text-secondaryaligns with the new design-token palette.
No functional or contrast concerns identified.src/app/integrations/qbo/qbo-onboarding/qbo-clone-settings/qbo-clone-settings.component.html (2)
414-418: Consistent secondary text colourThe paragraph now uses
tw-text-text-secondary, matching the global token update. Looks fine.
508-512: Description-field label updated correctlySame token replacement here; no issues spotted.
src/app/integrations/landing-v2/landing-v2.component.scss (1)
17-18: Divider lost its visual cue – verify if background colour is still requiredRemoving
tw-bg-separatorleaves the divider with only height & width.
Unless another rule supplies a background/border, the line will be invisible.If a thin line is still desired, consider:
-@apply tw-h-1-px tw-w-[100%]; +@apply tw-h-1-px tw-w-[100%] tw-bg-border-tertiary;Confirm in UI and adjust.
src/app/integrations/business-central/business-central-shared/business-central-import-settings/business-central-import-settings.component.html (1)
4-4: Missingtw-bordermay drop the outer borderOther panels in this template apply both
tw-borderandtw-border-border-tertiary.
The outerconfiguration--contentsdiv now sets only the colour token; if the base class doesn’t already define a border width, the frame disappears. Addtw-borderfor consistency.-class="configuration--contents tw-border-border-tertiary tw-mt-6" +class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"src/app/integrations/sage300/sage300-shared/sage300-advanced-settings/sage300-advanced-settings.component.html (1)
4-4: Outer container border width omittedAs with the Business Central template, only the colour token remains:
class="configuration--contents tw-border-border-tertiary tw-mt-6"Add
tw-borderto retain the 1 px frame unless another style already applies it.src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-download-file/qbd-direct-download-file.component.html (2)
13-14: Visual-only change LGTMBackground class switched to the new design-token (
tw-bg-bg-success). No logic impacted. ✅
60-61: Consistent token usage confirmed
tw-text-text-successmatches the background token above. Good consistency across success states.src/app/shared/components/configuration/email-multi-select-field/email-multi-select-field.component.html (2)
16-21: Token replacement looks correctRe-tinting selected-chip text & icon to
tw-text-text-secondaryaligns with the global palette. No behavioural impact. ✅
75-76: Dialog title colour matches body – goodNew token keeps visual hierarchy intact. No further action needed.
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-setup-connection/qbd-direct-setup-connection.component.html (2)
13-14: Success badge token update verified
tw-bg-bg-successis consistent with the rest of the migration. Looks good.
88-89: Icon colour token matches badge update
tw-text-text-successcorrectly complements the success badge. No issues spotted.src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.scss (2)
18-19: Disabled button colour token switched – LGTM
tw-bg-bg-brand-disableis semantically clearer. Implementation is fine.
6-7:bg-tertiarytoken present in Tailwind config
Verified intailwind.config.jsthatbg-tertiaryis defined, sotw-bg-bg-tertiarywill be generated correctly. No further changes needed.src/app/shared/components/configuration/configuration-confirmation-dialog/configuration-confirmation-dialog.component.html (1)
6-11: ConfirmedisTextColorAllowedInput in SvgIconComponentThe
SvgIconComponentalready declares:
@Input() isTextColorAllowed: boolean = false;
insrc/app/shared/components/core/svg-icon/svg-icon.component.tsNo further changes are needed—Angular will bind
[isTextColorAllowed]without errors.src/app/integrations/sage300/sage300-shared/sage300-import-settings/sage300-import-settings.component.html (1)
15-15: Consistent utility migration looks goodBorder class updated to the new design-token
tw-border-border-tertiary. No functional impact spotted. 👍src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.html (1)
9-15: Looks good — token swap keeps border width & updates text colour consistently
No functional impact detected.src/app/integrations/qbd/qbd-shared/qbd-field-mapping/qbd-field-mapping.component.html (1)
4-4: New border utility requires Tailwind safelisting / theme mappingThe class
tw-border-border-tertiaryis not one of Tailwind’s stock colour utilities.
Please double-check that:
- The token is mapped in
tailwind.config.js(theme.colors[ 'border-tertiary' ]) and- It is either generated at build time or explicitly safelisted; otherwise PurgeCSS may strip it out and you’ll end up with no border in production.
Nothing blocking – just verify before merge.
Also applies to: 15-15, 25-25, 35-35
src/app/shared/components/configuration/email-multi-select-field/email-multi-select-field.component.scss (2)
2-2: Token migration looks good
tw-text-text-secondarymatches the new design-token palette and keeps specificity low.
No concerns with this change.
28-30: Confirm availability oftw-border-border-neutralA new border colour token is introduced here. Ensure:
--border-neutralis defined in the active theme (added infdl.scss, looks good)- Tailwind config exposes the class →
tw-border-border-neutralIf Tailwind isn’t yet generating this class, add it to the config or the safelist.
src/app/integrations/xero/xero-onboarding/xero-clone-settings/xero-clone-settings.component.html (2)
310-312: Visual token update LGTMThe switch from
tw-text-slightly-normal-text-colortotw-text-text-secondaryon the read-only input aligns with the new palette. Behaviour unchanged.
314-316: Consistent secondary text colourSame token replacement for the paragraph – change is straightforward and safe.
src/app/integrations/bamboo-hr/configuration/configuration.component.html (1)
2-2: Style-token updates approvedBorder and disabled-state class replacements (
tw-border-border-tertiary,tw-bg-bg-brand-disable) are consistent with the new design tokens. No functional impact.Also applies to: 9-9, 27-27
src/assets/themes/fyle/fdl.scss (1)
107-108: New radio hover colour token addedAddition is non-breaking and aligns with palette; ensure components reference the variable via Tailwind or SCSS so it doesn’t become dead code.
src/app/integrations/travelperk/travelperk-shared/travelperk-advanced-settings/travelperk-advanced-settings.component.html (1)
49-75: Styling-only update looks correctAll occurrences of
tw-border-separatorhave been replaced withtw-border-border-tertiary. No functional bindings are touched, and the new design-token class is used consistently across the containers.
Just confirm thattw-border-border-tertiaryis present in the updated Tailwind config/theme so the build doesn’t purge it unexpectedly.
Otherwise, no concerns.Also applies to: 83-98
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html (1)
4-46: Consistent border-token migrationThe template correctly adopts
tw-border-border-tertiaryand related success-token classes. Behavioural directives and form bindings remain untouched.
Please sanity-check that the new class names exist in every env (storybook / prod) to avoid runtime style gaps.Also applies to: 55-73, 80-118
src/app/integrations/bamboo-hr/bamboo-hr.component.html (1)
3-13: Visual token swap verified
tw-bg-success-toast→tw-bg-bg-success, text & border tokens updated. No template logic affected.
Looks good; just ensure old toast classes are fully removed elsewhere to avoid dead CSS.Also applies to: 44-63, 79-81
src/app/integrations/intacct/intacct-shared/intacct-import-settings/intacct-import-settings.component.html (1)
4-8: Large-scale token replacement approvedAll updated inputs / warning dialogs now use
tw-text-text-secondaryandtw-border-border-tertiary. No accidental removal of validation or i18n pipes seen.
Given the volume, consider running a quick visual regression test to catch any missed edge cases (e.g., disabled-input colours).Also applies to: 37-58, 65-72, 150-170, 199-202, 313-326
src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.html (1)
4-15: Stepper tokens updated correctlySuccess state now references
tw-border-border-success,tw-bg-bg-success, and icon colourtw-text-text-success. Class list logic remains intact.
No issues detected.src/styles.scss (1)
310-310: Systematic color token migration is well-executed.The consistent update from
tw-text-slightly-normal-text-colortotw-text-text-secondaryaligns perfectly with the design token migration strategy outlined in the migration plan. This follows proper semantic naming conventions.Also applies to: 337-337, 341-341, 478-478
tailwind.config.js (1)
131-131: Good reorganization of color token structure.The relocation of
bg-warning-lighterwithin the colors object improves the organization and consistency of the color token structure.PRIMENG_THEMING_MIGRATION_PLAN.md (1)
1-354: Excellent comprehensive migration plan.This migration plan is exceptionally well-structured and thorough. Key strengths include:
- Phased approach: 7 phases over 9 weeks reduces risk and allows for incremental validation
- Detailed implementation: Concrete code examples and configuration snippets
- Risk management: Comprehensive risk assessment with mitigation strategies
- Clear success criteria: Functional, technical, and business requirements are well-defined
- Rollback planning: Both immediate and gradual rollback strategies covered
The plan aligns perfectly with the actual code changes being implemented in this PR and provides clear guidance for the development team.
| if (!workspaceId) { | ||
| return this.router.navigateByUrl(`workspaces`); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical behavioral change - token health check bypassed.
The early return true completely bypasses the QBO token health validation logic, making lines 35-58 unreachable. This significantly changes the guard's behavior and could have security implications.
If this change is intentional, remove the unreachable code:
- return true;
-
- return this.qboConnectorService.checkQBOTokenHealth().pipe(
- map(() => true),
- catchError(error => {
- if (error.status === 400) {
- globalCacheBusterNotifier.next();
-
- const onboardingState: QBOOnboardingState = this.workspaceService.getOnboardingState();
- if (onboardingState !== QBOOnboardingState.COMPLETE) {
- this.toastService.displayToastMessage(ToastSeverity.ERROR, 'Oops! your QuickBooks Online connection expired, please connect again');
- return this.router.navigateByUrl('integrations/qbo/onboarding/connector');
- }
-
- if (error.error.message === "Quickbooks Online connection expired") {
- return this.router.navigateByUrl('integrations/qbo/token_expired/dashboard');
- }
-
- if (error.error.message === "Quickbooks Online disconnected") {
- return this.router.navigateByUrl('integrations/qbo/disconnect/dashboard');
- }
- }
-
- return throwError(error);
- })
- );
+ return true;Otherwise, remove the early return if token validation is still needed.
🤖 Prompt for AI Agents
In src/app/core/guard/qbo-token.guard.ts at line 33, the early return statement
returning true bypasses the entire QBO token health validation logic, making
subsequent lines unreachable. To fix this, remove the early return if token
validation is required so that the validation logic executes properly. If the
early return is intentional, then remove the unreachable validation code from
lines 35-58 to avoid dead code.
| <app-loader></app-loader> | ||
| </div> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-separator tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Missing tw-border may drop the border entirely
The container now only sets the border color (tw-border-border-tertiary) but no longer applies a border width. Unless configuration--contents (or the dynamic configurationContents) adds tw-border, the visual border will disappear.
-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6"
+<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"🏁 Script executed:
#!/bin/bash
set -e
# Search for where configurationContents is defined or used
grep -R "configurationContents" -n src
# Locate the brandingStyle object in the component to inspect its values
grep -R "brandingStyle" -n src
# Check for any CSS rules targeting .configuration--contents
grep -R ".configuration--contents" -n srcLength of output: 82046
Add tw-border to ensure the border appears
The tw-border-border-tertiary utility sets only the border color, not its width. Without a width class (e.g. tw-border), the border will not render. Update as follows:
• File: src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.html (line 4)
-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6"
+[div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"
[ngClass]="brandingStyle.common.configurationContents">Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
src/app/integrations/business-central/business-central-shared/business-central-advanced-settings/business-central-advanced-settings.component.html
at line 4, the div uses the class tw-border-border-tertiary which only sets the
border color but not the border width, so the border does not appear. Add the
tw-border class alongside tw-border-border-tertiary to ensure the border is
visible by setting its width.
| <app-loader></app-loader> | ||
| </div> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-separator tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-add tw-border to keep the 1 px outline
The root container lost its border width during the token migration.
-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6"
+<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | |
| <div | |
| *ngIf="!isLoading" | |
| class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6" | |
| [ngClass]="brandingStyle.common.configurationContents" | |
| > |
🤖 Prompt for AI Agents
In
src/app/integrations/intacct/intacct-shared/intacct-advanced-settings/intacct-advanced-settings.component.html
at line 4, the root container div lost its 1px border width due to token
migration. Re-add the CSS class `tw-border` to the div's class list to restore
the 1px outline border.
| <app-loader></app-loader> | ||
| </div> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-separator tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Border width utility missing
Add tw-border (or tw-border-1-px tw-border-solid) so the visual frame remains.
-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6"
+<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"🤖 Prompt for AI Agents
In
src/app/integrations/qbd/qbd-shared/qbd-advanced-setting/qbd-advanced-setting.component.html
at line 4, the div element has border color classes but is missing a border
width utility, causing the border not to appear. Add the class `tw-border` or
alternatively `tw-border-1-px tw-border-solid` to ensure the border is visible
and the visual frame remains consistent.
| <app-loader></app-loader> | ||
| </div> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-separator tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | ||
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Border width lost after class replacement
Same issue as in Sage300: colour is set but border width is no longer applied.
-<div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6"
+<div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div *ngIf="!isLoading" class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | |
| <div *ngIf="!isLoading" class="configuration--contents tw-border tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
🤖 Prompt for AI Agents
In
src/app/integrations/qbd/qbd-shared/qbd-export-setting/qbd-export-setting.component.html
at line 4, the border width styling is lost because the class replacement only
sets the border color but not the border width. To fix this, ensure that the
class or style applied includes both the border color and the border width
properties, either by modifying the brandingStyle.common.configurationContents
to include border width or by explicitly adding a class or style that sets the
border width alongside the existing classes.
| .p-inputtext { | ||
| @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-slightly-normal-text-color tw-border tw-border-solid tw-rounded-4-px #{!important} | ||
| @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-text-secondary tw-border tw-border-solid tw-rounded-4-px #{!important} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminate the @apply rule with a semicolon to avoid a build break
Every other @apply statement in this file ends with ;, but the newly-modified one does not.
PostCSS/Tailwind will treat the directive as unterminated, and the stylesheet will fail to compile.
- @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-text-secondary tw-border tw-border-solid tw-rounded-4-px #{!important}
+ @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-text-secondary tw-border tw-border-solid tw-rounded-4-px #{!important};📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .p-inputtext { | |
| @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-slightly-normal-text-color tw-border tw-border-solid tw-rounded-4-px #{!important} | |
| @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-text-secondary tw-border tw-border-solid tw-rounded-4-px #{!important} | |
| } | |
| .p-inputtext { | |
| @apply tw-w-400-px tw-h-40-px tw-py-10-px tw-px-14-px tw-text-text-secondary tw-border tw-border-solid tw-rounded-4-px #{!important}; | |
| } |
🤖 Prompt for AI Agents
In
src/app/shared/components/configuration/configuration-text-field/configuration-text-field.component.scss
at lines 13 to 15, the @apply rule is missing a terminating semicolon, which
causes the stylesheet to fail compilation. Add a semicolon at the end of the
@apply statement to properly terminate the rule and ensure consistent syntax
with other @apply statements in the file.
| .line-active { | ||
| @apply tw-border-t-2-px tw-border-dashed tw-border-line-inactive tw-w-40 tw-h-2-px ; | ||
| @apply tw-border-t-2-px tw-border-dashed tw-border-slightly-normal-text-color tw-w-40 tw-h-2-px ; | ||
| } | ||
|
|
||
| .line-inactive { | ||
| @apply tw-border-t-2-px tw-border-solid tw-border-success-toast tw-w-40 tw-h-2-px ; | ||
| @apply tw-border-t-2-px tw-border-solid tw-border-border-success tw-w-40 tw-h-2-px ; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify the new border-color tokens & active/inactive semantics
-
The updated classes introduce
tw-border-slightly-normal-text-colorfor the active line andtw-border-border-successfor the inactive line.
• If “inactive” is meant to be a neutral/disabled state, a success-green border may be confusing.
• Confirm that both new tokens are declared intailwind.config.js/ theme maps; a missing token will break the build. -
Dash vs solid – the active line is dashed while inactive is solid. Double-check the visual spec to ensure this swap is intentional.
Run the quick check below to verify that all newly-used tokens are present in the Tailwind config:
🏁 Script executed:
#!/bin/bash
# Verify presence of the new design-token classes
tokens=("border-slightly-normal-text-color" "border-border-success")
for t in "${tokens[@]}"; do
rg -q "$t" tailwind.config.js || echo "❌ Token '$t' not found in tailwind.config.js"
doneLength of output: 546
Missing Tailwind tokens in config – please add or correct them
Both of the newly referenced tokens aren’t defined in tailwind.config.js, which will break the build:
border-slightly-normal-text-colorborder-border-success
Action items:
• Add these entries under your theme’s color (or borderColor) map in tailwind.config.js, for example:
// tailwind.config.js
module.exports = {
theme: {
extend: {
colors: {
'slightly-normal-text-color': '…',
'border-success': '…',
},
// or borderColor: { … }
}
}
};• Alternatively, correct the class names to match existing tokens if they were mistyped.
• Double-check with the design spec that “active” should use a dashed border and “inactive” solid – swapping dash vs. solid could be unintentional.
File needing update:
- src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.scss
[line 13–19] adjust classnames or ensure matching tokens are added to your Tailwind config.
🤖 Prompt for AI Agents
In
src/app/shared/components/qbd/helper/qbd-onboarding-stepper/qbd-onboarding-stepper.component.scss
lines 13 to 19, the Tailwind CSS tokens 'border-slightly-normal-text-color' and
'border-border-success' used in the .line-active and .line-inactive classes are
not defined in tailwind.config.js. To fix this, add these color tokens under the
colors or borderColor section in tailwind.config.js with appropriate color
values matching your design spec. Alternatively, if these class names are typos,
correct them to existing valid Tailwind tokens. Also verify that the border
styles (dashed for active and solid for inactive) align with the intended design
and swap if necessary.
| <app-loader></app-loader> | ||
| </div> | ||
| <div class="configuration--contents tw-border-separator tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | ||
| <div class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Border width dropped – UI border will disappear
tw-border-border-tertiary only sets the colour; the actual 1 px border width that existed (tw-border/tw-border-1-px) is now missing. The container will render with no visible border in Tailwind 3.
-<div class="configuration--contents tw-border-border-tertiary tw-mt-6"
+<div class="configuration--contents tw-border-1-px tw-border-border-tertiary tw-mt-6"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div class="configuration--contents tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> | |
| <div class="configuration--contents tw-border-1-px tw-border-border-tertiary tw-mt-6" [ngClass]="brandingStyle.common.configurationContents"> |
🤖 Prompt for AI Agents
In
src/app/shared/components/si/core/intacct-connector/intacct-connector.component.html
at line 4, the class 'tw-border-border-tertiary' sets only the border color but
does not define the border width, causing the border to disappear. To fix this,
add the appropriate Tailwind class for border width such as 'tw-border' or
'tw-border-1-px' alongside the existing color class to ensure the border is
visible with the correct width.
| // .p-button { | ||
| // @apply tw-w-[100%] tw-text-14-px tw-text-btn-primary-text-color tw-shadow-none tw-border-none tw-bg-btn-primary-bg tw-px-16-px tw-py-10-px #{!important}; | ||
| // } | ||
|
|
||
| .p-button.p-button-raised { | ||
| @apply tw-justify-center #{!important}; | ||
| } | ||
| // .p-button.p-button-raised { | ||
| // @apply tw-justify-center #{!important}; | ||
| // } | ||
|
|
||
| .p-button-label { | ||
| @apply tw-flex-none #{!important}; | ||
| } | ||
| // .p-button-label { | ||
| // @apply tw-flex-none #{!important}; | ||
| // } | ||
|
|
||
| .p-button:enabled:hover { | ||
| @apply tw-text-btn-primary-hover-text-color tw-bg-btn-primary-hover-bg tw-shadow-btn-cta-shadow #{!important}; | ||
| } | ||
| // .p-button:enabled:hover { | ||
| // @apply tw-text-btn-primary-hover-text-color tw-bg-btn-primary-hover-bg tw-shadow-btn-cta-shadow #{!important}; | ||
| // } | ||
|
|
||
| .p-button:disabled { | ||
| @apply tw-cursor-no-drop tw-text-btn-primary-disable-text-color tw-bg-bg-brand-disable #{!important}; | ||
| } | ||
| // .p-button:disabled { | ||
| // @apply tw-cursor-no-drop tw-text-btn-primary-disable-text-color tw-bg-bg-brand-disable #{!important}; | ||
| // } | ||
|
|
||
| .p-button.secondary-sm { | ||
| @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-secondary-text-color tw-bg-btn-secondary-bg #{!important}; | ||
| } | ||
| // .p-button.secondary-sm { | ||
| // @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-secondary-text-color tw-bg-btn-secondary-bg #{!important}; | ||
| // } | ||
|
|
||
| .p-button:enabled:hover.secondary-sm { | ||
| @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-secondary-hover-text-color tw-bg-btn-secondary-hover-bg tw-shadow-btn-cta-shadow #{!important}; | ||
| } | ||
| // .p-button:enabled:hover.secondary-sm { | ||
| // @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-secondary-hover-text-color tw-bg-btn-secondary-hover-bg tw-shadow-btn-cta-shadow #{!important}; | ||
| // } | ||
|
|
||
| .p-button.outline-sm { | ||
| @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-outline-secondary-text-color tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color tw-border #{!important}; | ||
| } | ||
| // .p-button.outline-sm { | ||
| // @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-outline-secondary-text-color tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color tw-border #{!important}; | ||
| // } | ||
|
|
||
| .p-button.danger-outline { | ||
| @apply tw-px-16-px tw-py-10-px tw-text-14-px tw-text-text-danger tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color #{!important}; | ||
| } | ||
| // .p-button.danger-outline { | ||
| // @apply tw-px-16-px tw-py-10-px tw-text-14-px tw-text-text-danger tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color #{!important}; | ||
| // } | ||
|
|
||
| .p-button:enabled:hover.danger-outline { | ||
| @apply tw-px-16-px tw-py-10-px tw-text-14-px tw-text-text-danger tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color #{!important}; | ||
| } | ||
| // .p-button:enabled:hover.danger-outline { | ||
| // @apply tw-px-16-px tw-py-10-px tw-text-14-px tw-text-text-danger tw-bg-btn-outline-secondary-bg tw-border-solid tw-border-btn-outline-secondary-border-color #{!important}; | ||
| // } | ||
|
|
||
| .p-button:enabled:hover.outline-sm { | ||
| @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-outline-secondary-hover-text-color tw-bg-btn-outline-secondary-hover-bg tw-border-solid tw-border-btn-outline-secondary-hover-border-color tw-shadow-btn-cta-shadow #{!important}; | ||
| } | ||
| // .p-button:enabled:hover.outline-sm { | ||
| // @apply tw-px-12-px tw-py-8-px tw-text-12-px tw-text-btn-outline-secondary-hover-text-color tw-bg-btn-outline-secondary-hover-bg tw-border-solid tw-border-btn-outline-secondary-hover-border-color tw-shadow-btn-cta-shadow #{!important}; | ||
| // } | ||
|
|
||
| .p-button.primary-outline { | ||
| @apply tw-font-nav-link-font-weight tw-px-16-px tw-py-10-px tw-text-14-px tw-text-btn-outline-primary-text-color tw-bg-btn-outline-primary-bg tw-border tw-border-solid tw-border-btn-outline-primary-border-color #{!important}; | ||
| } | ||
| // .p-button.primary-outline { | ||
| // @apply tw-font-nav-link-font-weight tw-px-16-px tw-py-10-px tw-text-14-px tw-text-btn-outline-primary-text-color tw-bg-btn-outline-primary-bg tw-border tw-border-solid tw-border-btn-outline-primary-border-color #{!important}; | ||
| // } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Systematic button style migration approach looks good.
The approach of commenting out all button-related styles while preserving them for reference during the theming migration is well-executed. This allows for easy rollback if needed.
However, ensure that the new PrimeNG theming system provides equivalent styling before this change reaches production:
🏁 Script executed:
#!/bin/bash
# Verify that button components still render correctly without custom styles
echo "Checking for any remaining button style dependencies..."
# Check if any components explicitly depend on the commented button classes
rg -A 3 -B 3 "p-button\.(secondary-sm|outline-sm|danger-outline|primary-outline)" --type html
# Check for any TypeScript files that might programmatically add these classes
rg -A 3 -B 3 "(secondary-sm|outline-sm|danger-outline|primary-outline)" --type tsLength of output: 2539
Action Required: Update Legacy Button Class References
While the strategy of commenting out custom .p-button styles for migration is sound, grep revealed lingering dependencies on the old class names in your configuration files. You’ll need to address these to prevent broken styles at runtime:
- src/app/branding/fyle/style-config.ts
• PropertydashboardErrorResolveBtnTextstill uses'p-button secondary-sm' - src/app/branding/c1/style-config.ts
• PropertydashboardErrorResolveBtnTextstill uses'p-button primary-outline'
Please update these to the new theme’s class names (or remove them if the theme provides built-in equivalents) and verify in the running app that all button variants render correctly under the new PrimeNG theming system.
🤖 Prompt for AI Agents
In src/styles.scss lines 132 to 178, the legacy .p-button styles are commented
out for migration, but in src/app/branding/fyle/style-config.ts and
src/app/branding/c1/style-config.ts, the properties dashboardErrorResolveBtnText
still reference old class names 'p-button secondary-sm' and 'p-button
primary-outline'. Update these properties to use the new theme's button class
names or remove them if the new theme provides built-in equivalents, then verify
all button variants render correctly in the running app with the new PrimeNG
theming system.
|
|
||
| &--divider { | ||
| @apply tw-h-1-px tw-w-[100%] tw-bg-separator; | ||
| @apply tw-h-1-px tw-w-[100%]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify that the landing divider remains visible after removing background color.
The removal of tw-bg-separator could make the divider invisible. Ensure that the new design token system provides equivalent styling for visual separation.
🏁 Script executed:
#!/bin/bash
# Check if the separator background is defined elsewhere in the new design tokens
echo "Checking for alternative separator styling..."
# Look for separator-related styles in theme files
fd -e scss -x rg -l "separator|divider" {} \;
# Check if the landing divider is used in templates
rg -A 2 -B 2 "landing--divider" --type htmlLength of output: 1348
🏁 Script executed:
#!/bin/bash
# Search for separator-related variables or mixins in the main theme
rg -n "separator" src/assets/themes/theme.scss
# Check for a design token variable named $separator
rg -n "\$separator" src/assets/themes/theme.scss
# Look for landing--divider style definitions in all SCSS files
rg -n "landing--divider" -A3 -B1 -t scssLength of output: 231
Ensure the landing divider has a background
The CSS custom‐property --separator is defined in src/assets/themes/theme.scss but the .landing--divider rule in src/styles.scss no longer applies any background. Without tw-bg-separator (or an equivalent token), a 1px‐high element will be invisible.
Please update the rule around line 752 in src/styles.scss to include the separator background. For example:
.landing--divider {
- @apply tw-h-1-px tw-w-[100%];
+ @apply tw-bg-separator tw-h-1-px tw-w-[100%];
}Or replace tw-bg-separator with the new design‐token mixin/utility (e.g. background-color: var(--separator);) to guarantee visibility.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @apply tw-h-1-px tw-w-[100%]; | |
| .landing--divider { | |
| @apply tw-bg-separator tw-h-1-px tw-w-[100%]; | |
| } |
🤖 Prompt for AI Agents
In src/styles.scss at line 752, the .landing--divider rule applies height and
width but lacks a background color, making the 1px-high element invisible.
Update this rule to include a background color using the CSS custom property
--separator by adding either the utility class tw-bg-separator or directly
setting background-color: var(--separator); to ensure the divider is visible.
Description
Please add PR description here, add screenshots if needed
Clickup
https://app.clickup.com/
Summary by CodeRabbit
New Features
Style
Bug Fixes
Chores
Documentation