ui: QWC regen UI fixes#1773
Merged
JustARatherRidiculouslyLongUsername merged 5 commits intomasterfrom Mar 5, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRemoved conditional button variant in a template, simplified DOM wrapper structure in a landing template, moved navigation-unlock from a child component's ngOnDestroy to the parent component's ngOnDestroy, and added a tooltip text-centering style. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Parent as QbdDirectComponent
participant Child as RegenerateQwcComponent
participant Nav as NavigationLockService
rect rgba(220,240,255,0.5)
Note over Child,Nav: Previous flow (before change)
User->>Child: navigate away / destroy
Child->>Nav: unlockNavigation()
end
rect rgba(220,255,220,0.5)
Note over Parent,Nav: New flow (after change)
User->>Parent: navigate away / destroy
Parent->>Nav: unlockNavigation()
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ashwin1111
approved these changes
Mar 5, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/integrations/qbd-direct/qbd-direct.component.ts`:
- Around line 141-144: Fix the typo in the parent component comment ("qbd dirct"
→ "qbd direct") and address the navigation-lock lifecycle mismatch by ensuring
the child cleans up the lock: in QbdDirectRegenerateQwcFileComponent add an
unlock call to NavigationLockService (unlockNavigation or unlock) inside its
ngOnDestroy so any locks set by its lockNavigation calls are released if the
component is destroyed early; keep or keep reviewing the parent's ngOnDestroy
unlock in QbdDirectComponent, or alternatively convert NavigationLockService to
a reference-counted lock if multiple lock/unlock pairs must be tracked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5c43fee6-51d9-4056-a214-68a90c324357
📒 Files selected for processing (5)
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-download-file/qbd-direct-download-file.component.htmlsrc/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-qwc-file/qbd-direct-qwc-file-landing/qbd-direct-qwc-file-landing.component.htmlsrc/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-qwc-file/qbd-direct-regenerate-qwc-file/qbd-direct-regenerate-qwc-file.component.tssrc/app/integrations/qbd-direct/qbd-direct.component.tssrc/styles.scss
💤 Files with no reviewable changes (2)
- src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-qwc-file/qbd-direct-regenerate-qwc-file/qbd-direct-regenerate-qwc-file.component.ts
- src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-download-file/qbd-direct-download-file.component.html
🔁 Code Duplication Report - Angular
📊 No significant change in code duplication. |
JustARatherRidiculouslyLongUsername
added a commit
that referenced
this pull request
Mar 5, 2026
* ui: replace fyle button with sage button * ui: make card description font size 14px * fix: keep nav locked when going back to qwc landing page * ui: center align text in all tooltips * refactor: typo (cherry picked from commit 3d872fe)
JustARatherRidiculouslyLongUsername
added a commit
that referenced
this pull request
Mar 5, 2026
* ui: replace fyle button with sage button * ui: make card description font size 14px * fix: keep nav locked when going back to qwc landing page * ui: center align text in all tooltips * refactor: typo (cherry picked from commit 3d872fe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clickup
app.clickup.com
https://fylein.slack.com/archives/C094U6MHXD2/p1772706099458349?thread_ts=1772691919.372699&cid=C094U6MHXD2
https://fylein.slack.com/archives/C094U6MHXD2/p1772693579099629?thread_ts=1772183282.711769&cid=C094U6MHXD2
Summary by CodeRabbit
Style
UI Improvements
Bug Fixes