Onboarding landing construction#642

Merged

DhaaraniCIT merged 13 commits intomasterfrom

xero-onboarding-landing

Mar 19, 2024

Contributor

DhaaraniCIT commented Mar 8, 2024

No description provided.


          Onboarding landing construction

4530bad

Contributor

coderabbitai bot commented Mar 8, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: review. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Fyle added 2 commits

March 8, 2024 13:03


          Onboarding landing construction

25bc615


          Merge branch 'master' into xero-onboarding-landing

5090dc9

Merge branch 'master' into xero-onboarding-landing

DhaaraniCIT requested a review from ashwin1111

March 8, 2024 07:52


          Merge branch 'master' into xero-onboarding-landing

ca89d77

Merge branch 'master' into xero-onboarding-landing

ashwin1111 reviewed

View reviewed changes

src/app/branding/branding-config.ts Outdated

                           SAGE300: `${brandingConfig.helpArticleDomain}/en/collections/215867-integrations-with-fyle`,
-                          BUSINESS_CENTRAL: `${brandingConfig.helpArticleDomain}/en/articles/8911018-how-to-configure-the-fyle-dynamics-365-business-central-integration`
+                          BUSINESS_CENTRAL: `${brandingConfig.helpArticleDomain}/en/articles/8911018-how-to-configure-the-fyle-dynamics-365-business-central-integration`,
+                          XERO: `${brandingConfig.helpArticleDomain}/en/articles/8911018-how-to-configure-the-fyle-dynamics-365-business-central-integration`

Contributor

ashwin1111 Mar 8, 2024

use right urls

src/app/branding/branding-config.ts Outdated

Comment on lines 136 to 142

+                              LANDING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration`,
+                              CONNECTOR: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0`,
+                              EMPLOYEE_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_d70f1d54cc`,
+                              EXPORT_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_dca1353686`,
+                              IMPORT_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_b8a2df129f`,
+                              ADVANCED_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_18c28de6c7`,
+                              SKIP_EXPORT: `${brandingConfig.helpArticleDomain}/en/articles/7044785-how-to-skip-exporting-specific-expenses-from-fyle-to-quickbooks-online`

Contributor

ashwin1111 Mar 8, 2024

use right urls

src/app/branding/branding-config.ts

                           SAGE300: `${brandingConfig.helpArticleDomain}/en/collections/215867-integrations-with-fyle`,
-                          BUSINESS_CENTRAL: `${brandingConfig.helpArticleDomain}/en/collections/215867-integrations-with-fyle`
+                          BUSINESS_CENTRAL: `${brandingConfig.helpArticleDomain}/en/collections/215867-integrations-with-fyle`,
+                          XERO: `${brandingConfig.helpArticleDomain}/en/collections/215867-integrations-with-fyle`

Contributor

ashwin1111 Mar 8, 2024

same

src/app/branding/branding-config.ts Outdated

Comment on lines 196 to 202

+                              LANDING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration`,
+                              CONNECTOR: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0`,
+                              EMPLOYEE_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_d70f1d54cc`,
+                              EXPORT_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_dca1353686`,
+                              IMPORT_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_b8a2df129f`,
+                              ADVANCED_SETTING: `${brandingConfig.helpArticleDomain}/en/articles/6208620-how-to-set-up-the-fyle-quickbooks-online-integration-v2-0#h_18c28de6c7`,
+                              SKIP_EXPORT: `${brandingConfig.helpArticleDomain}/en/articles/7044785-how-to-skip-exporting-specific-expenses-from-fyle-to-quickbooks-online`

Contributor

ashwin1111 Mar 8, 2024

same

src/app/branding/branding-config.ts Outdated

                           BUSINESS_CENTRAL: 'https://www.youtube.com/embed/2oYdc8KcQnk',
-                          TRAVELPERK: 'https://www.youtube.com/embed/2oYdc8KcQnk'
+                          TRAVELPERK: 'https://www.youtube.com/embed/2oYdc8KcQnk',
+                          XERO: 'https://www.youtube.com/embed/2oYdc8KcQnk'

Contributor

ashwin1111 Mar 8, 2024

use xero url

src/app/branding/branding-config.ts Outdated

                           BUSINESS_CENTRAL: 'https://www.youtube.com/embed/2oYdc8KcQnk',
-                          TRAVELPERK: 'https://www.youtube.com/embed/2oYdc8KcQnk'
+                          TRAVELPERK: 'https://www.youtube.com/embed/2oYdc8KcQnk',
+                          XERO: 'https://www.youtube.com/embed/2oYdc8KcQnk'

Contributor

ashwin1111 Mar 8, 2024

same

...grations/xero/xero-onboarding/xero-onboarding-landing/xero-onboarding-landing.component.html Outdated

+                  (warningAccepted)="acceptWarning($event)"
+                  [isWarningVisible]="isIncorrectXeroConnectedDialogVisible"
+                  [headerText]="'Incorrect account selected'"
+                  [contextText]="'You had previously set up the integration with a different QuickBooks Online account. Please choose the same to restore the settings'"

Contributor

ashwin1111 Mar 8, 2024

Xero account, not qbo

...tegrations/xero/xero-onboarding/xero-onboarding-landing/xero-onboarding-landing.component.ts Outdated

+                private checkProgressAndRedirect(): void {
+                  const onboardingState: XeroOnboardingState = this.workspaceService.getOnboardingState();
+                  if (onboardingState !== XeroOnboardingState.COMPLETE) {
+                    this.router.navigate(['integrations/xero/onboarding/connector']);

Contributor

ashwin1111 Mar 8, 2024

before redirecting to connector page, we should do a POST call to xero/tenants/

Contributor

ashwin1111 Mar 15, 2024

this is not fixed yet

src/app/shared/components/helper/app-landing-page-header/app-landing-page-header.component.html Outdated

                                   {{ isConnectionInProgress ? 'Disconnecting' : 'Disconnect' }}
                               </button>
-                              <button *ngIf="!isIntegrationConnected && (appName === AppName.QBD || appName === AppName.NETSUITE || appName === AppName.INTACCT || appName === AppName.SAGE300 || appName === AppName.BUSINESS_CENTRAL)" pButton type="button" class="p-button-raised" (click)="connect()">
+                              <button *ngIf="!isIntegrationConnected && (appName === AppName.QBD || appName === AppName.NETSUITE || appName === AppName.INTACCT || appName === AppName.SAGE300 || appName === AppName.BUSINESS_CENTRAL || appName === AppName.XERO)" pButton type="button" class="p-button-raised" (click)="connect()">

Contributor

ashwin1111 Mar 8, 2024

we should use custom button present in xero-app-2 here instead of Fyle button. The blue color one.

DhaaraniCIT requested a review from ashwin1111

March 12, 2024 11:55

ashwin1111 removed their request for review

March 12, 2024 14:42


          PR comments fix

f5875ce

DhaaraniCIT requested a review from ashwin1111

March 15, 2024 09:51

ashwin1111 removed their request for review

March 15, 2024 12:13

DhaaraniCIT and others added 2 commits

March 18, 2024 12:53


          Xero tenant connection (#646)

xero connector page construction


          PR comments fix

f978c30

DhaaraniCIT requested a review from ashwin1111

March 18, 2024 07:41


          Merge branch 'master' into xero-onboarding-landing

17602dc

Merge branch 'master' into xero-onboarding-landing

ashwin1111 reviewed

View reviewed changes

...tegrations/xero/xero-onboarding/xero-onboarding-landing/xero-onboarding-landing.component.ts Outdated

                 private checkProgressAndRedirect(): void {
                   const onboardingState: XeroOnboardingState = this.workspaceService.getOnboardingState();
                   if (onboardingState !== XeroOnboardingState.COMPLETE) {
+                    this.xeroConnectorService.postXeroTenants().subscribe();

Contributor

ashwin1111 Mar 18, 2024

@DhaaraniCIT everything after this line do it inside subscribe block


          PR comments fix

c89cd9a

DhaaraniCIT requested a review from ashwin1111

March 18, 2024 08:00

ashwin1111 approved these changes

View reviewed changes

Fyle and others added 4 commits

March 18, 2024 15:03


          Merge branch 'master' into xero-onboarding-landing

4d08703

Merge branch 'master' into xero-onboarding-landing


          Merge branch 'master' into xero-onboarding-landing

e6318ef

Merge branch 'master' into xero-onboarding-landing


          xero configuration setting (#673)

0114be4

xero configuration setting


          clone settings construction (#679)

cbc0da2

clone settings construction

DhaaraniCIT merged commit 0801d11 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet