Xero tenant connection #646

DhaaraniCIT · 2024-03-08T09:53:36Z

No description provided.

coderabbitai · 2024-03-08T09:53:40Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

ashwin1111 · 2024-03-12T14:49:58Z

src/app/core/models/branding/content-configuration.model.ts

+                userId: string;
+                companyId: string;
+                userPassword: string;
+                password: string;


these are specific to Intacct, please remove it off, 20-23

ashwin1111 · 2024-03-12T14:50:33Z

src/app/branding/branding-config.ts

+            configuration: {
+                connector: {
+                    stepName: 'Connect to Xero',
+                    subLabel: 'Expenses will be posted to the Xero Tenant Mapping selected here. Once configured, you can not change ' + brandingConfig.brandName + ' organization or Tenant Mapping.'


Tenant Mapping t and m should be small. c1 uses sentence case

ashwin1111 · 2024-03-12T14:51:11Z

src/app/core/models/branding/content-configuration.model.ts

+                        cccExpensePaymentType: string;
+                        cccExpensePaymentTypeSubLabel: string;
+                        creditCardVendor: string;
+                        creditCardVendorSublabel: string;
+                        chargeCard: string;
+                        chargeCardPlaceholder: string;
+                        chargeCardSublabel: string;
+                        cccExpenseState: string;
+                        cccExportGroup: string;
+                        employeeFieldMapping: string;
+                        creditCard: string;
+                        creditCardSubLabel: string;


clean up line 37 to 48, introduce keys that are used in Xero only

ashwin1111 · 2024-03-12T14:51:46Z

src/app/branding/branding-config.ts

+                    location: 'location',
+                    department: 'department',
+                    project: 'project',
+                    class: 'class',
+                    item: 'item'


551 - 555 is specific to Intacct

ashwin1111 · 2024-03-12T14:52:11Z

src/app/branding/branding-config.ts

+                    item: 'item'
+                },
+                done: {
+                    ctaText: '',


if these values are not required in xero, please don't add it to model

ashwin1111 · 2024-03-12T14:53:59Z

...ions/xero/xero-onboarding/xero-onboarding-connector/xero-onboarding-connector.component.html

+            <div>
+                <app-configuration-step-header
+                    [headerText]="'Connect to Xero Tenant'"
+                    [contentText]="'Connect to the Xero Tenant from which you would like to import and export data. The ' + brandingConfig.brandName + ' org and Xero Tenant cannot be changed once the configuration steps are complete.'"


same as above

ashwin1111 · 2024-03-12T15:00:37Z

...ations/xero/xero-onboarding/xero-onboarding-connector/xero-onboarding-connector.component.ts

+
+  showDisconnectXero: boolean;
+
+  tenantList: XeroDestinationAttributes[];


use common one

ashwin1111 · 2024-03-12T15:00:43Z

...ations/xero/xero-onboarding/xero-onboarding-connector/xero-onboarding-connector.component.ts

+
+  tenantList: XeroDestinationAttributes[];
+
+  xeroTenantselected: XeroDestinationAttributes;


ashwin1111 · 2024-03-12T15:02:42Z

...ations/xero/xero-onboarding/xero-onboarding-connector/xero-onboarding-connector.component.ts

+      this.getTenant();
+      this.isXeroConnected = false;
+      this.isContinueDisabled = true;
+      this.showOrHideDisconnectXero();


remove this and call showOrHideDisconnectXero() inside 221 block. isLoading should be set once both of these API calls are resolved

ashwin1111 · 2024-03-12T15:04:10Z

...ations/xero/xero-onboarding/xero-onboarding-connector/xero-onboarding-connector.component.ts

+    if (this.xeroTenantselected && !this.isContinueDisabled) {
+      this.xeroConnectionInProgress = true;
+      this.isContinueDisabled = true;
+      const tenantMappingPayload: TenantMappingPost = {


construct in model for consistency

xero onboarding export settings page construction

export settings basic functions

xero connector page construction

b8123a1

DhaaraniCIT changed the base branch from master to xero-onboarding-landing March 8, 2024 09:54

Xero connection save

7712beb

DhaaraniCIT requested a review from ashwin1111 March 12, 2024 11:55

ashwin1111 reviewed Mar 12, 2024

View reviewed changes

DhaaraniCIT and others added 3 commits March 15, 2024 14:19

xero onboarding export settings page construction (#653)

0635a15

xero onboarding export settings page construction

PR comments fix

a28d569

PR comments fix

f6c7031

DhaaraniCIT requested a review from ashwin1111 March 15, 2024 09:23

ashwin1111 approved these changes Mar 15, 2024

View reviewed changes

Xero onboarding import settings (#658)

dfba953

export settings basic functions

DhaaraniCIT merged commit 7587402 into xero-onboarding-landing Mar 18, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xero tenant connection #646

Xero tenant connection #646

DhaaraniCIT commented Mar 8, 2024

coderabbitai bot commented Mar 8, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024

ashwin1111 Mar 12, 2024


		showDisconnectXero: boolean;

		tenantList: XeroDestinationAttributes[];


		tenantList: XeroDestinationAttributes[];

		xeroTenantselected: XeroDestinationAttributes;

Xero tenant connection #646

Xero tenant connection #646

Conversation

DhaaraniCIT commented Mar 8, 2024

coderabbitai bot commented Mar 8, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Mar 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)