multi select css changes #839

DhaaraniCIT · 2024-06-06T13:24:57Z

No description provided.

coderabbitai · 2024-06-06T13:25:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ashwin1111 · 2024-06-07T14:53:40Z

src/app/shared/components/input/multi-select/multi-select.component.ts

+
+  @Input() displayAs: string;
+
+  @Input() isFilter: boolean = false;


better name

ashwin1111 · 2024-06-07T14:54:28Z

src/app/shared/components/input/multi-select/multi-select.component.ts

@@ -18,6 +19,38 @@ export class MultiSelectComponent {

  @Input() options: any[];

+  @Input() optionLabel: string;
+
+  @Input() displayAs: string;


better name

ashwin1111 · 2024-06-07T14:54:57Z

src/app/shared/components/input/multi-select/multi-select.component.ts

+
+  @Input() selectedValue: string | null;
+
+  @Output() multiSelectChange = new EventEmitter();


ashwin1111 · 2024-06-07T14:55:05Z

src/app/shared/components/input/multi-select/multi-select.component.ts

+
+  @Output() multiSelectChange = new EventEmitter();
+
+  @Output() removeItem = new EventEmitter();


onRemoveItem

ashwin1111 · 2024-06-07T14:55:57Z

...omponents/configuration/configuration-multi-select/configuration-multi-select.component.html

@@ -9,27 +9,10 @@ <h5 class="!tw-text-text-muted tw-text-14-px !tw-font-400 !tw-leading-4" [innerH
        </div>
    </div>
    <div class="tw-pl-34-px">
-        <p-multiSelect [options]="options" styleClass="tw-z-2 tw-py-8-px tw-px-12-px" [formControlName]="formControllerName" [defaultLabel]="placeholder" 


check other references and remove it off, few more pages are left

ashwin1111 · 2024-06-07T14:56:30Z

...omponents/configuration/configuration-multi-select/configuration-multi-select.component.html

@@ -9,27 +9,10 @@ <h5 class="!tw-text-text-muted tw-text-14-px !tw-font-400 !tw-leading-4" [innerH
        </div>
    </div>
    <div class="tw-pl-34-px">
-        <p-multiSelect [options]="options" styleClass="tw-z-2 tw-py-8-px tw-px-12-px" [formControlName]="formControllerName" [defaultLabel]="placeholder" 


how do we handle style in new component?

ashwin1111 · 2024-06-07T15:02:03Z

src/app/shared/components/input/multi-select/multi-select.component.html

+                </div>
+                <div *ngIf="selectedValue && form.value.email.length > 1" class="tw-pl-8-px">
+                    <p class="tw-flex tw-justify-center tw-items-center tw-p-5-px tw-h-24-px tw-w-24-px tw-bg-input-read-only-bg tw-text-12-px tw-text-text-muted tw-rounded-12-px">
+                        +{{ form.value.email.length - 1 }}


these are email specific logics, these shouldn't reside inside multi select. We should get template from parent component and render it

ashwin1111 · 2024-06-07T15:03:11Z

src/app/shared/components/input/multi-select/multi-select.component.html

+                </div>
+            </div>
+        </ng-template>
+        <ng-template let-value let-index="index" pTemplate="item">


same as above comment

ashwin1111 · 2024-06-07T15:03:40Z

src/styles.scss

-.p-multiselect {
-    @apply tw-h-40-px tw-flex tw-items-center lg:tw-w-300-px md:tw-w-260-px tw-border tw-border-solid tw-border-select-default-border tw-rounded-4-px #{!important};
-}
+// .p-multiselect {


remove commented lines

multi select css changes

1f7e69b

DhaaraniCIT requested a review from ashwin1111 June 6, 2024 13:25

ashwin1111 reviewed Jun 7, 2024

View reviewed changes

abhishek1234321 closed this Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi select css changes #839

multi select css changes #839

DhaaraniCIT commented Jun 6, 2024

coderabbitai bot commented Jun 6, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024

ashwin1111 Jun 7, 2024


		@Input() displayAs: string;

		@Input() isFilter: boolean = false;


		@Input() selectedValue: string \| null;

		@Output() multiSelectChange = new EventEmitter();


		@Output() multiSelectChange = new EventEmitter();

		@Output() removeItem = new EventEmitter();

multi select css changes #839

multi select css changes #839

Conversation

DhaaraniCIT commented Jun 6, 2024

coderabbitai bot commented Jun 6, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)