Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: unit test the intacct mapping page #983
test: unit test the intacct mapping page #983
Changes from all commits
403a3d9
e4fdd45
f3febbf
5044272
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure 'isLoading' state is properly managed
In the
triggerAutoMapEmployees
tests,component.isLoading
is expected to befalse
after the operation. However,isLoading
is never set totrue
before the operation starts. Consider settingcomponent.isLoading = true;
before triggering the method and updating the component code if necessary to reflect the loading state accurately.Apply this change to set
isLoading
totrue
before the operation:Ensure the component method
triggerAutoMapEmployees
correctly manages theisLoading
state.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider testing behavior through public methods instead of private methods
Testing private methods like
getDestinationField
ties your tests to the internal implementation, making refactoring more difficult. It's better to test the public methods or the overall behavior that relies ongetDestinationField
to ensure that changes in private methods do not require test modifications unless they affect external behavior.