fix: Manual workflow improvement #3479
Conversation
WalkthroughThe workflow in Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Workflow
participant BA as build-android
participant BI as build-ios
participant Slack as send-to-slack
GitHub->>BA: Trigger build-android
GitHub->>BI: Trigger build-ios
BA-->>GitHub: Return apkUrl
BI-->>GitHub: Return iosUrl
GitHub->>Slack: Trigger send-to-slack (after both succeed)
Slack-->>Slack: Dispatch Slack message with branch, apkUrl, iosUrl
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
PR description must contain a link to a ClickUp (case-insensitive) |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/manual-appflow-1.yml(4 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/manual-appflow-1.yml
[error] 82-82: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/manual-appflow-1.yml (3)
11-14: Build-Android Job: Power-packed and Precise!
Your new "build-android" job is configured like a Rajinikanth blockbuster—slick and efficient! The output variableapkUrlderived from thediwaiAndroidstep is spot on. Keep this momentum, my friend.
37-41: Build-iOS Job: Lightning Fast!
The introduction of the "build-ios" job is as dynamic as a supercharged performance. I see you've set the output variableiosUrlcorrectly. One small check: the job usesenvironment: stagingbut setsnative-configtoprod. Is that an intentional twist in the tale? Verify if that mix of staging and prod settings is deliberate.
65-82: Send-to-Slack Job: The Final Act!
This new "send-to-slack" job delivers notifications like a powerful dialogue—providing branch details, PR links, and both APK/IPA URLs! The integration of the Slack message is slick. Just ensure that the formatting (with\r\n) meets Slack's requirements. Overall, a master stroke in automation.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 82-82: no new line character at the end of file
(new-line-at-end-of-file)
| @@ -68,4 +79,4 @@ jobs: | |||
| with: | |||
| slack-bot-user-oauth-access-token: ${{ secrets.SLACK_BOT_USER_OAUTH_ACCESS_TOKEN }} | |||
| slack-channel: C029QPGHSQL | |||
| slack-text: ${{github.event.sender.login}} ran manual workflow on "${{ steps.get-branch.outputs._1 }}" branch \r\n PR link ${{github.event.pull_request.html_url}} \r\n \r\n *Description* \r\n ```${{github.event.pull_request.body}}``` \r\n \r\n APK Link ${{steps.diwaiAndroid.outputs.url}} \r\n IPA link ${{steps.diwaiIos.outputs.url}} | |||
| slack-text: ${{ github.event.sender.login }} ran manual workflow on "${{ steps.get-branch.outputs._1 }}" branch \r\n PR link ${{ github.event.pull_request.html_url }} \r\n \r\n *Description* \r\n ```${{ github.event.pull_request.body }}``` \r\n \r\n APK Link ${{ needs.build-android.outputs.apkUrl }} \r\n IPA link ${{ needs.build-ios.outputs.iosUrl }} | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Finishing Touch: Add a Newline!
Even the grandest performance needs a proper finish. YAMLlint has pointed out the absence of a newline at the end of the file. Please add one to bring this masterpiece to its perfect conclusion.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 82-82: no new line character at the end of file
(new-line-at-end-of-file)
Clickup
https://app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes
Summary by CodeRabbit