Skip to content

feat: Change to sage logo #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Change to sage logo #3986

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9118440
Change to sage logo
arjunaj5 Oct 14, 2025
140ffb8
Merge branch 'master' into Fyle-86d0k46y9
arjunaj5 Oct 15, 2025
a26b490
remove unwanted svg
arjunaj5 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/auth/switch-org/switch-org.page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="switch-org__toolbar__header-container">
<ion-icon
class="switch-org__toolbar__header-container__header"
src="../../../assets/svg/fyle-logo-dark.svg"
src="../../../assets/svg/sage-logo.svg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Logo asset path updated, but pattern is different, da!

You've switched from "../../../assets/svg/fyle-logo-dark.svg" to "../../../assets/svg/sage-logo.svg" using direct path with ion-icon. The change works, but notice that fy-opt-in.component.html uses the icon registry approach (mat-icon with svgIcon="sage-logo") while this file uses direct SVG path. Both are valid, but mixing patterns can make maintenance harder, boss!

Consider using the icon registry pattern here too for consistency:

     <div class="switch-org__toolbar__header-container">
-      <ion-icon
+      <mat-icon
         class="switch-org__toolbar__header-container__header"
-        src="../../../assets/svg/sage-logo.svg"
-      ></ion-icon>
+        svgIcon="sage-logo"
+      ></mat-icon>
     </div>

But if ion-icon is required for Ionic framework compatibility, the current approach is fine, thalaiva!

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
src="../../../assets/svg/sage-logo.svg"
<div class="switch-org__toolbar__header-container">
<mat-icon
class="switch-org__toolbar__header-container__header"
svgIcon="sage-logo"
></mat-icon>
</div>
🤖 Prompt for AI Agents 
In src/app/auth/switch-org/switch-org.page.html around line 11, the logo was
changed to a direct SVG path (src="../../../assets/svg/sage-logo.svg") which
mixes patterns with other components that use the registered SVG icon approach;
update this file to use the app's icon registry pattern (e.g., replace the
direct src usage with the component/style that uses the registered name such as
mat-icon svgIcon="sage-logo" or the equivalent registered icon usage in your
Ionic setup) so it uses the same registered SVG icon as
fy-opt-in.component.html; if ion-icon is strictly required for this page, leave
as-is but add a short inline comment explaining why this page differs from the
registry pattern.

></ion-icon>
</div>
</ion-toolbar>
Expand Down
4 changes: 2 additions & 2 deletions src/app/auth/switch-org/switch-org.page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
padding: 8px 0 0 12px;

&__header {
height: 30px;
width: 84px;
width: 200px;
height: 26px;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/components/fy-opt-in/fy-opt-in.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</ion-button>
</ion-buttons>
<ion-title class="text-center opt-in--title">
<mat-icon class="text-center opt-in--title__icon" svgIcon="fyle-logo-dark"></mat-icon>
<mat-icon class="text-center opt-in--title__icon" svgIcon="sage-logo"></mat-icon>
</ion-title>
</ion-toolbar>
</ion-header>
Expand Down
4 changes: 2 additions & 2 deletions src/app/shared/components/fy-opt-in/fy-opt-in.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
margin-right: 32px;

&__icon {
width: 70px;
height: 24px;
width: 200px;
height: 26px;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/icon/icon.providers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function provideIcons(): EnvironmentProviders {
'edit.svg',
'envelope.svg',
'fyle-logo-dark.svg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this?

'fyle-logo-light.svg',
'sage-logo.svg',
'file-pdf.svg',
'filter-applied.svg',
'filter.svg',
Expand Down
8 changes: 0 additions & 8 deletions src/assets/svg/fyle-logo-light.svg
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions src/assets/svg/fyle-logo.svg
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions src/assets/svg/sage-logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.