fix: Testing-29th-jan-2nd-commit#4098
fix: Testing-29th-jan-2nd-commit#4098amit429 wants to merge 1 commit intofyle-add-redirection-for-notificationsfrom
Conversation
WalkthroughAandavan, one line of logging has been added to the sendDeviceToken flow in the org-user service. The constructed payload is now logged before the POST call to /device_token. No control flow changes, no new features—just pure observation of the payload movement through the network. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/core/services/org-user.service.ts (1)
104-112:⚠️ Potential issue | 🟠 Major🚫 Don’t log device tokens in plaintext, boss.
Device tokens are sensitive identifiers; logging the raw payload risks leaking PII into logs. Please remove the console log or redact/gate it behind a safe debug logger.
🛠️ Suggested fix
const payload = { data: { tokens: [token], }, }; - console.log('payload', payload); + // Avoid logging raw device tokens (PII). If needed, log only metadata. + // this.logger.debug('sendDeviceToken payload', { tokenCount: payload.data.tokens.length });
|
not needed |
Clickup
Please add link here
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes
Summary by CodeRabbit