Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-theme.md #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ImmortalBoi
Copy link

I tried creating my own theme and followed the documentation, but let my IDE auto-import the variables because the page didn't include them.

However, I was stuck trying to implement a different interface than the one in the page. That's when I realised that I accidentally imported either an old version of the Theme or a different version, either way I think adding the import would be useful.

I tried creating my own theme and followed the documentation, but let my IDE auto-import the variables because the page didn't include them. 

However, I was stuck trying to implement a different interface than the one in the page. That's when I realised that I accidentally imported either an old version of the Theme or a different version, either way I think adding the import would be useful.
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree with the sentiment but not the block of import where the doc is showing how to create an empty struct.

How about just the v2 import when it is first used above the next code block.
Just a suggestion, what do you think?

@ImmortalBoi
Copy link
Author

Yeah, I agree. I just put it there because it seemed more convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants