Improve image docs #33
Conversation
There was a problem hiding this comment.
A great idea to improve this, however the statement "you need to
specify a minimum size for your image with Image.SetMinSize()." is not true.
Images will fill available space without any MinSize set. It is only needed if you want to ensure that it never becomes smaller than a certain size.
Thank you for your feedback. I reworked the description to reflect your correction. |
|
|
||
| In our example we use `theme.AccountIcon()`, because it is already available in the Fyne library. To use your own images you can bundle them into your project, which will make them available as Fyne resources. For more information please see [Bundling resources]({% link extend/bundle.md %}). | ||
|
|
||
| Please note that we are setting a size for the window. This is necessary, because images normally do not have a minimum size and Fyne would draw a window with zero width and height. For more details please see the section about [Fillmode](#fillmode). |
There was a problem hiding this comment.
It's not zero so this statement is incorrect - the width and height of the image would be 1, in addition a window is normally padded as well. I would consider rewording this to be less specific.
|
|
||
| ## Image from a URL | ||
|
|
||
| Images can also be created from URLs with `canvas.NewImageFromURI()`. This will fetch the image during runtime from a public image URL. |
There was a problem hiding this comment.
I find this misleading as you can't pass a URL into a URI method.
You might find it easier to use LoadResourceFromURLString instead.
I would like to propose an update to the page about
canvas.Image.The purpose of this update is to make it more clear how to use
canvas.Imageand to address commonly asked questions on the Discord help channel (e.g. not seeing the image because of missingSetMinSize()) .