Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/windows gopherjs #3327

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Conversation

Bluebugs
Copy link
Contributor

Description:

Properly warn user about gopherjs limitation on Windows.

Fixes #3161

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@Bluebugs Bluebugs changed the base branch from master to develop October 12, 2022 00:11
@coveralls
Copy link

coveralls commented Oct 12, 2022

Coverage Status

Coverage decreased (-0.04%) to 61.349% when pulling 72fd0b5 on Bluebugs:features/windows-gopherjs into 423d71f on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have any Windows computer to test it on at the moment but the code seems good and tests pass

@Bluebugs
Copy link
Contributor Author

Bluebugs commented Oct 12, 2022

I don’t have any Windows computer to test it on at the moment but the code seems good and tests pass

I have run manual test (on top of the automated one). It would have been nice if someone else was able to test too, but I guess merging it in develop and getting feedback during the release cycle is more likely to work in this case.

@Bluebugs Bluebugs merged commit 2d7554e into fyne-io:develop Oct 12, 2022
@Bluebugs Bluebugs deleted the features/windows-gopherjs branch October 12, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver: Web - "fyne serve" GOOS = Windows
3 participants