CMakeLists.txt install library #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fz-lyu
reviewed
Sep 22, 2022
| @PACKAGE_INIT@ | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/modbusppTargets.cmake") | ||
| check_required_components("@PROJECT_NAME@") No newline at end of file |
fz-lyu
reviewed
Sep 22, 2022
CMakeLists.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| cmake_minimum_required(VERSION 3.1) | |||
| project(modbuspp) | |||
| project(modbuspp VERSION 1.0.0) | |||
Owner
There was a problem hiding this comment.
Usually version # > 1.0 means it is safe to enter production. I would following the release version to be 0.3
fz-lyu
reviewed
Sep 22, 2022
| PUBLIC | ||
| . | ||
| ) | ||
| IF(BUILD_EXAMPLE) |
Owner
There was a problem hiding this comment.
Could you please update the README?
Owner
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CMakeLists.txt. Now 'make install' will create a complete install structure and the library can be found by other projects by "find_package(modbuspp)"
Build example is added as an option because the example file caused errors on the build and I didn't need the example for the installation to work.