Add C++ 17 no discard support #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like nodiscard was added to some functions with void return type somehow |
christophe-lunarg
force-pushed
the
add-no-discard
branch
from
d22f530
to
0ce1ceb
Compare
|
Yes, that’s still work in progress.
Le ven. 9 févr. 2024 à 07:13, Eyad Ahmed ***@***.***> a
écrit :
It seems like nodiscard was added to some functions with void return type
somehow
—
Reply to this email directly, view it on GitHub
<#1252 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO7ZXKJBBGB4J5QCK3N4BVTYSW5BNAVCNFSM6AAAAABDAOU5TKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGM4DQNZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
|
christophe-lunarg
force-pushed
the
add-no-discard
branch
16 times, most recently
from
9b3ce7e
to
13044d6
Compare
christophe-lunarg
force-pushed
the
add-no-discard
branch
from
13044d6
to
ff62f3b
Compare
dimateos
added a commit
to dimateos/Open-glm
that referenced
this pull request
Feb 15, 2024
Avoid merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably not exaustive but future contribution would be welcome!