set CMAKE_BUILD_TYPE only in top-level project #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @double-fault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_BUILD_TYPEshould only be set when the project being compiled is top-level. ThePROJECT_IS_TOP_LEVELvariable was added in cmake 3.21, hence a more hacky solution for older versions.Another option would be to simply display a message if
CMAKE_BUILD_TYPEis unspecified instead of defaulting it to Release.The issue with the current behavior is that setting the build type flag propagates to the parent project. In some code of mine I'm using spdlog as a git submodule (
add_subdirectory), and I have not specified build type - however spdlog sets it to Release which was causing some asserts in my code being compiled-out silently.As such I think it makes sense to not set any property which propagates to the parent project, since this is a library after all.