Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using HTTPretty together with the last version of
aiohttp
,aiohttp
failed to parse the response generated byHTTPretty
due to the way headers are separated.Specifically,
HTTPretty
separates them via the LF (\n
) control code whileaiohttp
expects CR LF (\r\n
).This behavior (on
aiohttp
's side) is also mentioned here aio-libs/aiohttp#7494 (comment) .By searching a bit on the Internet (eg. here) it seems that http parsers are expected to be lenient wrt parsing newlines, so I'm not sure this is technically a fault on
HTTPretty
's side.However I think it could be better to stay on the safe side and just use
\r\n
as separator for headers, which is the change I implemented with this PR.