Skip to content

Add cell-based markdown editor for pages #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 17, 2025

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Mar 7, 2025

Requires #19721. Extracted from #19226. This PR introduces a cell-based markdown editor as an alternative to the text-based editor for pages. The cell-based editor provides live previews but does not yet support inserting visualizations—this feature will be added in a separate PR. Users can seamlessly switch between the two editors. This change only impacts Pages, there are no changes to Reports at this time. There are some improvements and adjustments to this addition in the follow-up PR.

Screen.Recording.2025-03-15.at.10.11.32.AM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 25.0 milestone Mar 7, 2025
@guerler guerler marked this pull request as ready for review March 8, 2025 00:58
guerler added a commit to guerler/galaxy that referenced this pull request Mar 16, 2025
guerler added a commit to guerler/galaxy that referenced this pull request Mar 16, 2025
guerler added a commit to guerler/galaxy that referenced this pull request Mar 16, 2025
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool new functionality to be sure and I'm excited to see visualizations hooked into these. My wish list is UI for existing directive parameters beyond "which dataset/collection/etc...", getting monaco instead of ACE into the app, handling directives outside formal blocks (#19086 / #8516). My anxiety is this doesn't head in those directions but I understand we have different wish lists.

@guerler
Copy link
Contributor Author

guerler commented Mar 17, 2025

Thank you! I appreciate your feedback.

Regarding visualizations, our wish lists might align in some areas but differ slightly—I do think we need long-term supported, PDF-exportable visualizations, as well as support for more complex interactive ones like Vitessce. Particularly now that we have a solid visualization framework.

I’ll be switching from Ace to Monaco once #19434 is merged. Once we make the switch, we could also leverage autocomplete to assist in writing reports, potentially allowing for a purely text-based process with only the code editor visible.

I'll also take a look at the referenced PRs. Thanks again!

@guerler guerler merged commit bfb87a8 into galaxyproject:dev Mar 17, 2025
28 of 30 checks passed
guerler added a commit to guerler/galaxy that referenced this pull request Mar 18, 2025
@itisAliRH itisAliRH deleted the add_cell_editor branch April 10, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants