Skip to content

Use store to cache step jobs summary #20638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahmedhamidawan
Copy link
Member

No need to fetch it over and over if an invocation is terminal.

Can you open a separate PR for this please ?

Originally posted by @mvdbeek in #20624 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Jul 10, 2025
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.0, 25.1 Jul 10, 2025
@ahmedhamidawan
Copy link
Member Author

Please let me know if I should target a different branch. Seemed like a good fix against 24.2 to me.

@mvdbeek
Copy link
Member

mvdbeek commented Jul 10, 2025

I see I have successfully caused a lot of confusion. This is a nice optimization, but nothing we need to backport at all since it doesn't affect users in a direct way (you may get hit by rate limits, but the client handles that). dev would be fine here.

@ahmedhamidawan ahmedhamidawan changed the base branch from release_24.2 to dev July 10, 2025 15:15
@github-actions github-actions bot changed the title [24.2] Use store to cache step jobs summary Use store to cache step jobs summary Jul 10, 2025
@ahmedhamidawan ahmedhamidawan force-pushed the cache_steps_jobs_summary_in_store branch from 61a8d2e to 4e1b3ce Compare July 10, 2025 15:18
@mvdbeek mvdbeek merged commit 89b39be into galaxyproject:dev Jul 11, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants