-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add more info to inheritance chain #20701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sold on the end goal exactly but this particular implementation and augmentation to the API seems perfectly fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so awkward, I don't think this should be part of the API
It's part of an API that is already terribly awkward, so I guess it doesn't make things worse.
Yeah, it does look awkward to me too, but honestly I’m not sure what the ideal structure should be either. |
I think I would prefer that |
…h 'user_id' string in schema and update related logic in DatasetInheritanceChainEntry and tests.
a1b4166
to
d7b01fd
Compare
This PR adds a
same_user
flag to dataset inheritance metadata to help detect whether copied datasets come from the same user. The goal is to improve plagiarism detection while avoiding false positives and without exposing user IDs. I’m open to feedback on whether this approach is acceptable or if exposinguser_id
would be preferred for flexibility.This is needed because existing endpoints don’t reliably provide user info for inherited datasets, and accessing user IDs via history is only possible if the history is public or shared, which is often not the case.
This way, if the user copied a dataset, we should see somewhere from this endpoint that it is not from the user, for example:
How to test the changes?
(Select all options that apply)
License