Make workflow invocation tabs routable #20719
Open
+299
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahmedhamidawan please rebase the branch to include #20734 for fixing the failed client linting test error. |
The initial purpose of adding this was to prevent the page from reloading when you switch tabs. We set the boolean as soon as we know that the invocation exists in the store, and with this, when we change tabs there isn't a refresh every time. But we mustn't return from the watcher at this point, we must continue polling.
We used to lazy load the report tab when the state component had tabs. Now that we have nav with router instead, and also the fact that the report component itself is more efficient than in the past, it is okay to remove this functionality.
ahmedhamidawan
force-pushed
the
make_invocation_tabs_routable
branch
from
9289b40 to
ac778d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20133
make_invocation_tabs_routable.mp4
How to test the changes?
(Select all options that apply)
License