Skip to content

Hierarchical display collection dataset states #20731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 1, 2025

Should eventually address #20720 and all the other related issues.
There's an extra join here, but it's probably worth it ?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added the area/database Galaxy's database or data access layer label Aug 1, 2025
@mvdbeek mvdbeek force-pushed the hierarchical_display_collection_dataset_states branch 2 times, most recently from 49f3c9a to a8619a4 Compare August 2, 2025 09:38
@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 2, 2025

Hmm, so this works but there's now another obvious issue that is harder to address in a performant way. The collection's update_time doesn't update with content updates, so the update query for the history panel doesn't pick up when the datasets inside the collection change state. And propagating that up is messy with potentially many datasets competing to update the collection ... and because the dataset has a recursive relationship with the top level HDCA this is not easy or performant to do either. It might be safer to turn this around and make the HDCA update_time a subquery

@mvdbeek mvdbeek force-pushed the hierarchical_display_collection_dataset_states branch 3 times, most recently from 48a1cb8 to 03c921c Compare August 6, 2025 06:31
@mvdbeek mvdbeek force-pushed the hierarchical_display_collection_dataset_states branch 6 times, most recently from 4c036c8 to 1e22239 Compare August 8, 2025 08:00
@mvdbeek mvdbeek force-pushed the hierarchical_display_collection_dataset_states branch from 1e22239 to 896457e Compare August 8, 2025 10:55
@mvdbeek mvdbeek force-pushed the hierarchical_display_collection_dataset_states branch from 896457e to c5be2b1 Compare August 8, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant