Skip to content

Fix various collection descriptions in history panel. #20736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

Fixes #20730 - I had fixed it but only for flat sample sheets. I think Marius' screenshots were for paired sample sheets. Those should now be fixed and I've picked a better fallback than nested list - so things like say paired:paired are called collections and not nested lists.

Paired and unpaired sample sheets:

Screenshot 2025-08-04 at 10 58 12 AM

paired:paired collections left over from testing data landing requests:

Screenshot 2025-08-04 at 10 58 21 AM

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Create a paired sample sheet collection and look at history description of this dataset.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the improved_collection_summaries branch from cae855e to 32b2072 Compare August 5, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample sheet collection summary incorrect
1 participant