Sample Sheet Bug Fixes around Preserving Collection Metadata #20749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
sample_sheet_no_celery
branch
from
c64525a to
b453b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few different ways of collecting metadata after jobs and they seem to create collections in scarily different ways - as a result only the celery setup used by the API tests would actually preserve column definitions in the database after the data fetch tool creates those collections. This ports one of the sample sheet collection tests over to the integration test framework so we can test different metadata strategies - it would probably be nice to run a lot more of our data fetch tests in these new test cases but this PR only address the two specific bugs I've found so far.
How to test the changes?
(Select all options that apply)
License