Skip to content

Conversation

@enolfc
Copy link
Contributor

@enolfc enolfc commented Jan 28, 2026

Return redirection instead of a JSON with the redirect URI

In order to keep all existing functionality, adds a new param redirect that
if set to true it will return a HTTP redirect 302 with the expected URI to
start the authentication process. This is useful to get users authenticated
directly without the need to go through clicking the button

Deals with #21129

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

In order to keep all existing functionality, adds a new param `redirect` that
if set to `true` it will return a HTTP redirect 302 with the expected URI to
start the authentication process. This is useful to get users authenticated
directly without the need to go through clicking the button
@github-actions github-actions bot added this to the 26.1 milestone Jan 28, 2026
@bgruening
Copy link
Member

Thanks a lot @enolfc! I have tested this on the European Galaxy instance and it works nicely.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I would recommend avoiding using kwargs here and explicitly adding the optional parameter redirect to make it more readable 👍

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvdbeek mvdbeek requested a review from dannon February 3, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants