-
Notifications
You must be signed in to change notification settings - Fork 499
hopefully fixes lastz PAF output #7634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bernt-matthias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case.
|
@bernt-matthias while I agree with the sentiment of adding a test case, I feel trapped in a bit of a catch 22: I don't have a way to run lastz and have it produce PAF output to put in a test to compare to, which feels required for writing a real test. A minor additional issue is that I have no idea how to write tests in this framework, but that is at least surmountable. Do you have any suggestions? |
|
/me thinks to himself "there's probably a container somewhere that I could run interactively to make it do this" (but I don't know anything about that either, so I need guidance to get that far too) |
|
I see :) It's quite easy if you can run planemo. Add a test case (e.g. by copy pasting one of the existing) that sets the Let us know if you need help or just don't have the time. |
FOR CONTRIBUTOR: