Skip to content

Upgrade artifacts to v4 on builder.mdx #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

shanickcuello
Copy link
Contributor

@shanickcuello shanickcuello commented May 12, 2025

Changes

Bumped actions/upload-artifact from v3 to v4 to use the latest version.
Reason? Avoid this error: Error: Missing download info for actions/upload-artifact@v3

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • Documentation
    • Updated the GitHub Actions workflow example to use version 4 of the artifact upload action.

Copy link

coderabbitai bot commented May 12, 2025

Walkthrough

The documentation for a GitHub Actions workflow was updated to reference version 4 of the actions/upload-artifact action in place of version 3. No other workflow steps, logic, or environment variables were modified.

Changes

File(s) Change Summary
docs/03-github/04-builder.mdx Updated workflow example to use actions/upload-artifact@v4 instead of @v3.

Poem

A hop and a skip, the docs are renewed,
With artifact uploads now versioned and cued.
From v3 to v4, the change is quite neat,
Our builder hops forward, not missing a beat.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8acd3d2 and e4afb60.

📒 Files selected for processing (1)
  • docs/03-github/04-builder.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/03-github/04-builder.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Cat Gif

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/03-github/04-builder.mdx (1)

737-737: Confirm actions/upload-artifact@v4 compatibility and align examples
The workflow now references actions/upload-artifact@v4, which is the intended upgrade.

  1. Verify there are no breaking changes in v4 (inputs/behaviors remain identical to v3).
  2. For consistency, update the earlier snippet at lines 102–106 that still uses @v3 to @v4.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92691c9 and 8acd3d2.

📒 Files selected for processing (1)
  • docs/03-github/04-builder.mdx (1 hunks)

@davidmfinol davidmfinol merged commit 88916b3 into game-ci:main Jun 5, 2025
7 checks passed
@shanickcuello
Copy link
Contributor Author

@davidmfinol Should I remove the branch?

@davidmfinol
Copy link
Member

@shanickcuello Your changes have been merged, so feel free to remove your branch if you want

@shanickcuello shanickcuello deleted the patch-1 branch July 8, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants