Update node to v20 #509

davidmfinol · 2025-06-06T16:58:33Z

Changes

Update node to v20 to fix firebase deploy

Checklist

Read the contribution guide and accept the
code of conduct
Readme (updated or not needed)
Tests (added, updated or not needed)

Summary by CodeRabbit

Chores
- Updated all workflows and documentation to require Node.js version 20 instead of earlier versions.
- Adjusted minimum Node.js version in project configuration to 20.x.
Documentation
- Updated setup instructions and installation links in README and contributing guidelines to reference Node.js 20.

coderabbitai · 2025-06-06T16:58:41Z

Walkthrough

The project’s required Node.js version has been updated from 18.x (or 16.x in some places) to 20.x. This change is reflected in documentation, CI workflow configurations, and the package.json engines field to ensure consistency across development, deployment, and automated checks.

Changes

File(s)	Change Summary
.github/workflows/checks.yml	Updated Node.js version from 18 to 20 in all CI jobs.
.github/workflows/firebase-hosting-merge.yml .github/workflows/firebase-hosting-pull-request.yml	Updated Node.js version from 18 to 20 for Firebase deployment workflows.
CONTRIBUTING.md README.md	Updated documentation to require Node.js 20.x and updated installation links.
package.json	Changed `engines` field to require Node.js version >= 20.x.

Poem

🐇
Node hopped ahead, from eighteen to twenty,
In docs and in scripts, updates aplenty.
CI now runs on the latest and best,
Ensuring our code passes every test.
With engines aligned and instructions anew,
We leap into progress—cheers to the crew!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-06T16:58:46Z

github-actions · 2025-06-06T17:00:50Z

Visit the preview URL for this PR (updated for commit 8364ad4):

https://game-ci-5559f--pr509-node20-xrxs3mi9.web.app

_{(expires Fri, 13 Jun 2025 17:00:45 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

CONTRIBUTING.md (1)
21-21: Use correct spelling "Node.js" and version formatting.

The official spelling is “Node.js”, and it’s clearer to use a lowercase ‘x’ for version wildcards. For example:
- - [NodeJS](https://nodejs.org/) installed at v20.X.
+ - [Node.js](https://nodejs.org/) installed at v20.x.
🧰 Tools

🪛 LanguageTool

[uncategorized] ~21-~21: The official spelling of this programming framework is “Node.js”.
Context: ...he following tools to be installed. - NodeJS installed at v20....

(NODE_JS)
README.md (1)
38-43: Standardize "Node.js" spelling and version format.

Update references to use “Node.js” and lowercase ‘x’ in version wildcards. For example:
- This project has a hard dependency on Node20. You will need to make sure that you have the proper
- version of node installed to avoid errors.
+ This project has a hard dependency on Node.js v20.x. You will need to make sure that you have the proper
+ version of Node.js installed to avoid errors.

- [Install NodeJS v20 on Ubuntu](https://computingforgeeks.com/how-to-install-node-js-20-on-ubuntu/)
- [Install NodeJS v20 using brew](https://apple.stackexchange.com/a/207883)
+ [Install Node.js v20.x on Ubuntu](https://computingforgeeks.com/how-to-install-node-js-20-on-ubuntu/)
+ [Install Node.js v20.x using brew](https://apple.stackexchange.com/a/207883)
🧰 Tools

🪛 LanguageTool

[uncategorized] ~41-~41: The official spelling of this programming framework is “Node.js”.
Context: ... installed to avoid errors. - [Install NodeJS v20 on Ubuntu](https://computingforgeek...

(NODE_JS)

[uncategorized] ~42-~42: The official spelling of this programming framework is “Node.js”.
Context: ...stall-node-js-20-on-ubuntu/) - [Install NodeJS v20 using brew](https://apple.stackexch...

(NODE_JS)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88916b3 and 8364ad4.

📒 Files selected for processing (6)

.github/workflows/checks.yml (4 hunks)
.github/workflows/firebase-hosting-merge.yml (1 hunks)
.github/workflows/firebase-hosting-pull-request.yml (1 hunks)
CONTRIBUTING.md (1 hunks)
README.md (1 hunks)
package.json (1 hunks)

🧰 Additional context used

🪛 LanguageTool

CONTRIBUTING.md

[uncategorized] ~21-~21: The official spelling of this programming framework is “Node.js”.
Context: ...he following tools to be installed. - NodeJS installed at v20....

(NODE_JS)

README.md

[uncategorized] ~41-~41: The official spelling of this programming framework is “Node.js”.
Context: ... installed to avoid errors. - [Install NodeJS v20 on Ubuntu](https://computingforgeek...

(NODE_JS)

[uncategorized] ~42-~42: The official spelling of this programming framework is “Node.js”.
Context: ...stall-node-js-20-on-ubuntu/) - [Install NodeJS v20 using brew](https://apple.stackexch...

(NODE_JS)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build_and_preview

🔇 Additional comments (4)

package.json (1)

9-9: Engines field updated correctly.

The node engine requirement has been bumped to >= 20.x to align with the rest of the project. This change is consistent and ready to ship.

.github/workflows/firebase-hosting-pull-request.yml (1)

17-17: Node.js version for CI updated.

The actions/setup-node@v4 step now uses Node.js 20, matching the project-wide version bump. No further changes needed here.

.github/workflows/firebase-hosting-merge.yml (1)

19-19: Node.js version for CI updated.

The actions/setup-node@v4 step now uses Node.js 20, aligning with other workflows. This is good to merge.

.github/workflows/checks.yml (1)

15-15: Bump Node.js runtime to v20
The Node.js version has been updated to v20 across all workflow jobs to align with the PR objective and ensure CI consistency.

Also applies to: 26-26, 37-37, 48-48

Update node to v20

8364ad4

coderabbitai bot reviewed Jun 6, 2025

View reviewed changes

davidmfinol mentioned this pull request Jun 6, 2025

Update README.md #477

Closed

davidmfinol enabled auto-merge (squash) June 6, 2025 19:16

webbertakken approved these changes Jun 6, 2025

View reviewed changes

davidmfinol merged commit d50455d into main Jun 6, 2025
9 checks passed

davidmfinol deleted the node20 branch June 6, 2025 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update node to v20 #509

Update node to v20 #509

Uh oh!

davidmfinol commented Jun 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 6, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update node to v20 #509

Update node to v20 #509

Uh oh!

Conversation

davidmfinol commented Jun 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

davidmfinol commented Jun 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)